New issue
Advanced search Search tips

Issue 637951 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 635880
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

third_party/swiftshader should probably be in .gitignore

Project Member Reported by sdy@chromium.org, Aug 15 2016

Issue description

swiftshader is in DEPS (e3976c2e7d2ce17180ebf6d2a576f14c188c843d) but not in .gitignore (341fac67de9500a95d8ed16545a9b0e1f859991d). This means that, after a `gclient sync`, SwiftShader's files show up in git status as untracked.
 

Comment 1 by capn@chromium.org, Aug 15 2016

A similar request was made on: https://codereview.chromium.org/2224093003

I've just submitted a patch to remove the old (untracked) LICENSE and README.chromium files: https://codereview.chromium.org/2249693002/

Is this the issue you're describing?

Comment 2 by sdy@chromium.org, Aug 15 2016

I don't think so. The issue is that right now, if I check out master and do a `gclient sync`, my git status ends up looking like this:

    Untracked files:
      (use "git add <file>..." to include in what will be committed)
    
           	tests/
           	third_party/swiftshader/.dir-locals.el
           	third_party/swiftshader/.gitignore
           	third_party/swiftshader/AUTHORS.txt
           	third_party/swiftshader/Android.mk
           	third_party/swiftshader/BUILD.gn
           	third_party/swiftshader/CMakeLists.txt
           	third_party/swiftshader/CONTRIBUTING.txt
           	third_party/swiftshader/CONTRIBUTORS.txt
           	third_party/swiftshader/LICENSE.txt
           	third_party/swiftshader/README.md
           	third_party/swiftshader/docs/
           	third_party/swiftshader/include/
           	third_party/swiftshader/src/
           	third_party/swiftshader/tests/
           	third_party/swiftshader/third_party/

Comment 3 by sdy@chromium.org, Aug 15 2016

Description: Show this description

Comment 4 by capn@chromium.org, Aug 16 2016

Mergedinto: 635880
Status: Duplicate (was: Assigned)
Got fixed by reverting the patch from  Issue 635880 .

Comment 5 by sdy@chromium.org, Aug 17 2016

Cool, thank you!

Sign in to add a comment