New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637950 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 631271
issue 638086


Sign in to add a comment

[Sync] subfolders should have a better DEPS hierarchy

Project Member Reported by maxbogue@chromium.org, Aug 15 2016 
The sync subfolders should have a hierarchy like this, where things depend on their line and below, and only foo depends on foo_impl:

driver(_impl?)
syncable*
api(_impl?), engine(_impl)*
base, protocol

* sessions should be merged into engine (engine/cycles?)
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f727e610b5fdc72c17a0b62cc4793d1d72e542e8

commit f727e610b5fdc72c17a0b62cc4793d1d72e542e8
Author: maxbogue <maxbogue@chromium.org>
Date: Mon Aug 15 23:45:46 2016

[Sync] Clean up intra-sync DEPS significantly.

This change is cleaning up some of the DEPS weirdness left over from
the directory structure shuffle that was done when sync was moved to a
component. See the bug for more context.

- fake_encryptor moved from test/ to base/ next to its base class.
- commit_queue moved from engine_impl/ to engine/ because of uses in
  driver/.
- sync_string_conversions moved from base/ to engine/ because of
  dependencies on core/.
- model_type_registry moved from sessions_impl/ to engine_impl/ because
  of dependencies on core/ and it having little to do with sessions.

BUG= 637950 

Review-Url: https://codereview.chromium.org/2245073003
Cr-Commit-Position: refs/heads/master@{#412099}

[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/BUILD.gn
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/android/DEPS
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/api/DEPS
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/base/DEPS
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/base/cryptographer_unittest.cc
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/base/fake_encryptor.cc
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/base/fake_encryptor.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core/shared_model_type_processor.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core/shared_model_type_processor_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/js_sync_encryption_handler_observer.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/js_sync_encryption_handler_observer_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/js_sync_manager_observer.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/js_sync_manager_observer_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/model_type_connector_proxy_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/sync_encryption_handler_impl.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/sync_encryption_handler_impl_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/core_impl/test/fake_model_type_processor.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/driver/DEPS
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/driver/about_sync_util.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/driver/non_ui_model_type_controller_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/driver/ui_model_type_controller_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine/DEPS
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine/commit_queue.cc
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine/commit_queue.h
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine/sync_string_conversions.cc
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine/sync_string_conversions.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/DEPS
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/commit_processor.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/get_updates_delegate.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/get_updates_processor.h
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/model_type_registry.cc
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/model_type_registry.h
[rename] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/model_type_registry_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/model_type_worker.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/sessions_impl/DEPS
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/sessions_impl/sync_session_context.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/sync_tests.gypi
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/syncable/directory_unittest.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/syncable/syncable_unittest.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/test/engine/mock_model_type_processor.cc
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/test/engine/mock_model_type_worker.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/test/fake_sync_encryption_handler.h
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/tools/DEPS
[modify] https://crrev.com/f727e610b5fdc72c17a0b62cc4793d1d72e542e8/components/sync/tools/sync_client.cc

Comment 2 by maxbogue@chromium.org, Aug 16 2016

Blockedon: 638086

Comment 3 by maxbogue@chromium.org, Aug 19 2016 

Updated hierarchy goals copied from a doc:

Each folder can depend on folders within or below its own tier. Additionally, any folder foo_impl/ can depend on anything that foo/ can (including foo/), but only be depended on by foo/.

Tier 1

base/ - Useful things with no other dependencies
protocol/ - Sync protocol files

Tier 1.5

android/ - Low-level Android support code
js/ - Javascript bindings for sync

Tier 2

engine/ - The sync engine (things that run on the sync thread)
api/ - The model type interface (things that live on the model thread)
syncable/ - Directory-specific engine code (things that could be removed if all types were USS)

Tier 3

driver/ - Managing the sync engine (things that live on the UI thread)
device_info/ - Implementation of the device info data type

Tier 3.5

test/ - Code that exists only for testing (fake server)
tools/ - Scripts etc. (Python server...)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3067278a4670c40ad786742bbd47bacc36a5c1b3

commit 3067278a4670c40ad786742bbd47bacc36a5c1b3
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Aug 19 23:16:18 2016

[Sync] Move sessions/ to engine/cycle/ and rename things to match.

- Move everything in sessions/ to engine/cycle/.
- Move everything in sessions_impl/ to engine_impl/cycle/.
- Rename SyncSession* to SyncCycle* (within engine).
- Remove the syncer::sessions:: namespace entirely.
- Clean up deps.

BUG= 637950 
TBR=thestig,noyau

Review-Url: https://codereview.chromium.org/2258873003
Cr-Commit-Position: refs/heads/master@{#413278}

[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/p2p_sync_refresher.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/profile_sync_service_harness.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/retry_verifier.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/retry_verifier.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/sync/test/integration/updated_progress_marker_checker.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/chrome/browser/ui/webui/sync_internals_message_handler.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/browser_sync/browser/profile_sync_service.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/browser_sync/browser/profile_sync_service_mock.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/BUILD.gn
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core/DEPS
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core/internal_components_factory.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core/internal_components_factory_impl.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core/internal_components_factory_impl.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core/sync_manager.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core/test/test_internal_components_factory.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/DEPS
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/debug_info_event_listener.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/debug_info_event_listener.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/js_sync_manager_observer.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/js_sync_manager_observer.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/js_sync_manager_observer_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/sync_manager_impl.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/sync_manager_impl.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/core_impl/test/test_internal_components_factory.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/DEPS
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/about_sync_util.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/about_sync_util_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/backend_migrator_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/fake_sync_service.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/fake_sync_service.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host_core.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host_impl.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host_mock.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/glue/sync_backend_host_mock.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/driver/sync_service.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/DEPS
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/commit_counters.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/commit_counters.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/model_neutral_state.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/model_neutral_state.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/status_counters.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/status_counters.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/sync_cycle_snapshot.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/sync_cycle_snapshot.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/type_debug_info_observer.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/type_debug_info_observer.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/update_counters.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/cycle/update_counters.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/events/normal_get_updates_request_event.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/events/normal_get_updates_request_event.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine/events/poll_get_updates_request_event.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/DEPS
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/all_status.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/backoff_delay_provider.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/backoff_delay_provider.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/backoff_delay_provider_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/clear_server_data.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/clear_server_data.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/commit.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/commit.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/commit_contribution.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/commit_util.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/conflict_resolver.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/conflict_resolver.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/data_type_tracker.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/data_type_tracker.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/debug_info_getter.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/directory_type_debug_info_emitter.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/directory_type_debug_info_emitter.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/mock_debug_info_getter.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/mock_debug_info_getter.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/nudge_tracker.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/nudge_tracker.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/nudge_tracker_unittest.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/status_controller.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/status_controller.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/status_controller_unittest.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/sync_cycle.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/sync_cycle.h
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/sync_cycle_context.cc
[rename] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/sync_cycle_context.h
[add] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/test_util.cc
[add] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/cycle/test_util.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/directory_commit_contribution.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/directory_commit_contribution.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/directory_commit_contribution_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/directory_commit_contributor.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/directory_update_handler.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/directory_update_handler.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/directory_update_handler_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/get_commit_ids.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/get_updates_delegate.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/get_updates_delegate.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/get_updates_processor.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/get_updates_processor.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/get_updates_processor_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/model_type_registry.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/model_type_worker.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/model_type_worker.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/non_blocking_type_commit_contribution.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/non_blocking_type_commit_contribution.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/process_updates_util.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/process_updates_util.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/sync_cycle_event.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/sync_scheduler.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/sync_scheduler_impl.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/sync_scheduler_impl.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/sync_scheduler_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/syncer.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/syncer.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/syncer_proto_util.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/syncer_proto_util.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/syncer_proto_util_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/update_applicator.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/engine_impl/update_handler.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/protocol/client_debug_info.proto
[delete] https://crrev.com/b5587ce313138e508301052959470d80e3d1ea6f/components/sync/sessions/DEPS
[delete] https://crrev.com/b5587ce313138e508301052959470d80e3d1ea6f/components/sync/sessions_impl/DEPS
[delete] https://crrev.com/b5587ce313138e508301052959470d80e3d1ea6f/components/sync/sessions_impl/test_util.cc
[delete] https://crrev.com/b5587ce313138e508301052959470d80e3d1ea6f/components/sync/sessions_impl/test_util.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/test/engine/fake_sync_scheduler.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/test/engine/mock_update_handler.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/components/sync/test/engine/mock_update_handler.h
[delete] https://crrev.com/b5587ce313138e508301052959470d80e3d1ea6f/components/sync/test/sessions/test_scoped_session_event_listener.h
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
[modify] https://crrev.com/3067278a4670c40ad786742bbd47bacc36a5c1b3/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h

Comment 5 by maxbogue@chromium.org, Oct 6 2016

Labels: Sync-Code-Health

Comment 6 by maxbogue@chromium.org, Oct 6 2016

Labels: -Sync-Code-Health Hotlist-CodeHealth

Comment 7 by maxbogue@chromium.org, Oct 6 2016

Labels: -Pri-3 Pri-2
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b0bb91030096c9241d50ec723f63d0f19906b06

commit 2b0bb91030096c9241d50ec723f63d0f19906b06
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Nov 17 20:07:17 2016

[Sync] Move GenerateSyncableHash to base.

It's not only used by directory, so it doesn't make sense to live in
syncable.

BUG= 637950 

Review-Url: https://codereview.chromium.org/2502253003
Cr-Commit-Position: refs/heads/master@{#432937}

[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/BUILD.gn
[add] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/base/hash_util.cc
[add] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/base/hash_util.h
[rename] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/base/hash_util_unittest.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/engine_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/engine_impl/syncer_util.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/engine_impl/test_entry_factory.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/engine_impl/uss_migrator_unittest.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/engine_impl/worker_entity_tracker_unittest.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/model/DEPS
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/model/fake_model_type_sync_bridge.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/model_impl/DEPS
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/model_impl/processor_entity_tracker.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/model_impl/processor_entity_tracker_unittest.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/model_impl/shared_model_type_processor.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/model_neutral_mutable_entry.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/mutable_entry.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/parent_child_index_unittest.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/read_node.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/syncable_util.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/syncable_util.h
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/syncable/write_node.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/test/fake_server/bookmark_entity_builder.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync/test/fake_server/unique_client_entity.cc
[modify] https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06/components/sync_sessions/sessions_sync_manager.cc

Comment 9 by maxbogue@chromium.org, Nov 17 2016

Status: Fixed (was: Assigned)
DEPS are pretty much where we want them at this point, so I'm closing this bug.
►

Sign in to add a comment