Inline video overflows slate.com mobile layout; right side video controls unusable. |
||||||||
Issue descriptionVersion: Chrome 54 (dev) OS: Android (Nexus 6P) What steps will reproduce the problem? (1) Navigate to http://www.slate.com/blogs/five_ring_circus/2016/08/13/irish_rowers_gary_and_paul_o_donovan_have_been_giving_the_best_interviews.html (2) Try to play the inline video What is the expected output? Inline video playback What do you see instead? A video window that is too large for the current viewport. Image cut off, controls cut off (no way to go fullscreen, for example). Please use labels and text to provide additional information.
,
Aug 15 2016
The right side controls issue should be fixed with overflow menu enhancements, but there may still be an underlying layout issue here. +layout folk who might have an idea as well.
,
Aug 15 2016
,
Aug 16 2016
+rachelis@ and ainslie@ for UX feedback. This is a bug with the website: they have a fixed width for the video so we end up showing it outside of the viewport. It's not the first time we see issues like that and I wonder if we should have a way for users to work around this problem. One simple solution would be to expose a fullscreen item in the context menu for videos. It might not be very discoverable but would be a good workaround. Another solution would be to assume that the control's available size isn't the video width but the visible width so we would always show the controls. That solution might be weird because it would look like the video is cut. Note that the overflow menu enhancements would only help if we cut the controls where the viewport ends. Otherwise, the overflow will likely show outside of the viewport.
,
Aug 16 2016
I've added a screenshot. Trying it out, it is a frustrating problem. There isn't any way to scroll over or to put the video into fullscreen - though presumably, the developer has made the explicit decision to make the video a certain width. @ainslie - how have we addressed issues like this in the past? Do we have a thinking on whether we support the developer's truth or the user's experience?
,
Aug 16 2016
This fixed width issue is included in our Media-UX-2016 deck. It happens with YouTube embeds too. https://docs.google.com/presentation/d/1Woq3qr8FRIXdjJyqkQloI6qopR2FR-Wx5jblFPQHl0o/edit#slide=id.g14b0051447_1_0 One idea is for us to look at the width of our toolbar that's visible and then draw all of our controls in that available width. Per #4 that would be weird because the viewport would be clipped even if our controls weren't, but it would at least be more usable and would let you access fullscreen.
,
Aug 16 2016
Worth trying then. I think the challenge on the implementation is to differentiate the case where the controls are not visible inside the viewport and the case where the controls can't ever be visible because there is no side scrolling.
,
Aug 16 2016
Yes, definitely. :) Erm - I guess you'll look into that?
,
Aug 16 2016
I doubt this is something we will work on in Q3 but something to put in our Q4 candidate issues. I left the comment above as a note mostly ;)
,
Sep 12 2016
,
Oct 18 2016
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3347bb8ad251e778ed35c433c0246e0659f2402d commit 3347bb8ad251e778ed35c433c0246e0659f2402d Author: mlamouri <mlamouri@chromium.org> Date: Wed Nov 02 15:52:59 2016 Media controls max width is the width of the viewport. When a media element can't be shown in the viewport and horizontal scrolling is blocked, the controls should take this into considerations and don't get partially hidden. BUG= 637939 R=eae@chromium.org Review-Url: https://codereview.chromium.org/2470503003 Cr-Commit-Position: refs/heads/master@{#429288} [add] https://crrev.com/3347bb8ad251e778ed35c433c0246e0659f2402d/third_party/WebKit/LayoutTests/media/media-controls-overflow-hidden.html [add] https://crrev.com/3347bb8ad251e778ed35c433c0246e0659f2402d/third_party/WebKit/LayoutTests/media/media-controls-overflow-visible.html [modify] https://crrev.com/3347bb8ad251e778ed35c433c0246e0659f2402d/third_party/WebKit/Source/core/layout/LayoutMedia.cpp [modify] https://crrev.com/3347bb8ad251e778ed35c433c0246e0659f2402d/third_party/WebKit/Source/core/layout/LayoutMedia.h
,
Nov 2 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dalecur...@chromium.org
, Aug 15 2016