New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637923 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 637920



Sign in to add a comment

MojoGpuMemoryBufferManager should talk to mojom::GpuService to allocate gpu memory

Project Member Reported by sadrul@chromium.org, Aug 15 2016

Issue description

MojoGpuMemoryBufferManager should use mojom::GpuService::CreateGpuMemoryBuffer for allocating gpu memory.
 

Comment 2 Deleted

Comment 3 by sadrul@chromium.org, Aug 25 2016

Labels: Proj-Mustash-Mus-GPU
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/900faab623165140c2c34f7ba94cced55769691c

commit 900faab623165140c2c34f7ba94cced55769691c
Author: sadrul <sadrul@chromium.org>
Date: Wed Aug 31 00:40:02 2016

gfx: Struct traits for GpuMemoryBufferId and GpuMemoryBufferType.

BUG= 637923 

Review-Url: https://codereview.chromium.org/2295923002
Cr-Commit-Position: refs/heads/master@{#415521}

[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/common/gpu_type_converters.cc
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/common/gpu_type_converters.h
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/common/gpu_type_converters_unittest.cc
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/gpu/interfaces/gpu_service_internal.mojom
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/public/interfaces/gpu_memory_buffer.mojom
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/public/interfaces/gpu_service.mojom
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/ws/gpu_service_proxy.cc
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/services/ui/ws/gpu_service_proxy.h
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/ui/gfx/mojo/buffer_types.typemap
[rename] https://crrev.com/900faab623165140c2c34f7ba94cced55769691c/ui/gfx/mojo/buffer_types_traits.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5569cc1d0d05edce033dc92096ad5d5b03067907

commit 5569cc1d0d05edce033dc92096ad5d5b03067907
Author: sadrul <sadrul@chromium.org>
Date: Fri Sep 02 22:09:15 2016

gfx: Struct traits for GpuMemoryBufferHandle.

The remaining type-converter is for GpuMemoryBufferHandle. So introduce a
struct-trait for it instead. It also needs struct-traits for
NativePixmapPlane and NativePixmapHandle. Remove the type-converters,
since they are no longer needed. Also, expose NativePixmapPlane and
NativePixmapHandle types to non-ozone platforms, so we don't need some
special ozone-only mojom API.

BUG= 637923 
TBR=reveman@ for trivial components/exo change

Review-Url: https://codereview.chromium.org/2298003002
Cr-Commit-Position: refs/heads/master@{#416362}

[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/components/exo/display.h
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/services/ui/common/BUILD.gn
[delete] https://crrev.com/60fb6b0f601074d94dc03bbea9f1351f678f18fa/services/ui/common/gpu_type_converters.cc
[delete] https://crrev.com/60fb6b0f601074d94dc03bbea9f1351f678f18fa/services/ui/common/gpu_type_converters.h
[delete] https://crrev.com/60fb6b0f601074d94dc03bbea9f1351f678f18fa/services/ui/common/gpu_type_converters_unittest.cc
[delete] https://crrev.com/60fb6b0f601074d94dc03bbea9f1351f678f18fa/services/ui/common/mus_common_unittests_app_manifest.json
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/services/ui/public/cpp/gpu_service.cc
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/services/ui/public/interfaces/gpu_service.mojom
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/services/ui/ws/gpu_service_proxy.cc
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/tools/determinism/compare_build_artifacts.py
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/BUILD.gn
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/gpu_memory_buffer.h
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/ipc/gfx_param_traits_macros.h
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/mojo/buffer_types.typemap
[add] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/mojo/buffer_types_traits.cc
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/mojo/buffer_types_traits.h
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/mojo/struct_traits_unittest.cc
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/mojo/traits_test_service.mojom
[rename] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/native_pixmap_handle.cc
[rename] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/gfx/native_pixmap_handle.h
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/ozone/platform/drm/gpu/gbm_buffer.cc
[modify] https://crrev.com/5569cc1d0d05edce033dc92096ad5d5b03067907/ui/ozone/public/native_pixmap.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/763bd5900392427eff240119f238754c1e4923e1

commit 763bd5900392427eff240119f238754c1e4923e1
Author: sadrul <sadrul@chromium.org>
Date: Tue Sep 27 14:33:44 2016

services/ui: Add mojom API for creating/destroying gpu memory buffer.

Add struct-traits for gpu::SurfaceHandle, and use that to provide mojom API
for creating/destroying gpu memory buffer. This allows removing the direct
dependency of gpu code from ws code (which is a pre-requisite for the gpu
process split).

BUG= 637923 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2360203003
Cr-Commit-Position: refs/heads/master@{#421201}

[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/components/display_compositor/BUILD.gn
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/gpu/ipc/common/BUILD.gn
[add] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/gpu/ipc/common/surface_handle.mojom
[add] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/gpu/ipc/common/surface_handle.typemap
[add] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/gpu/ipc/common/surface_handle_struct_traits.h
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/gpu/ipc/common/typemaps.gni
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/services/ui/gpu/gpu_service_internal.cc
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/services/ui/gpu/gpu_service_internal.h
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/services/ui/gpu/interfaces/gpu_service_internal.mojom
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/services/ui/ws/DEPS
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/services/ui/ws/gpu_service_proxy.cc
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/services/ui/ws/mus_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/763bd5900392427eff240119f238754c1e4923e1/services/ui/ws/mus_gpu_memory_buffer_manager.h

Labels: Proj-Mustash
Components: Internals>MUS
Status: Fixed (was: Started)

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment