New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637917 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Unable to play back media downloaded from Pagalworld.co

Project Member Reported by mdw@chromium.org, Aug 15 2016

Issue description

Version: 54.0.2826.2
OS: Android MMB29K

What steps will reproduce the problem?
(1) Go to any page on pagalworld.co - e.g., http://pagalworld.co/files/11122/Freaky%20Ali%20(2016)%20HD%20Video%20Songs.html

(2) Download a video, e.g., "Din Mein Karengey Jagrata (Freaky Ali) (HD Android).mp4"

(3) Wait for download to complete

(4) Tap on notification or info bar when download completes.

What is the expected output?

The video or MP3 file should play back immediately.

What do you see instead?

See the toast: "Can't open file".

I believe this site is using Content-Type: application/force-download for its media assets. It is possible that this is confusing the Android download manager making it impossible to play back the file.

Note that this whole experience works beautifully in UC Browser, so I do consider this a Chrome bug, even if the fix is to avoid using the Android download manager for files like this.

 

Comment 1 by mdw@chromium.org, Sep 12 2016

Friendly ping :-)

Cc: -dfalcant...@chromium.org qin...@chromium.org
Mime type / media / download notifications -> Min.

Comment 3 by qin...@chromium.org, Sep 12 2016

Cc: -qin...@chromium.org
Labels: -Type-Bug -Pri-3 M-54 Pri-1 Type-Bug-Regression
Owner: qin...@chromium.org
Status: Started (was: Untriaged)

Comment 4 by qin...@chromium.org, Sep 12 2016

Labels: Merge-Request-54
https://codereview.chromium.org/2320313002/ should fix the issue, Chrome will update the MIME type before adding it to android DownloadManager.

Comment 5 by qin...@chromium.org, Sep 12 2016

BTW, in addition to the MIME type issue, b/30945409 is causing the issue that the intent cannot be opened by other apps.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23ad64c72dc2f116a7b73c2d6803f449ebba2553

commit 23ad64c72dc2f116a7b73c2d6803f449ebba2553
Author: qinmin <qinmin@chromium.org>
Date: Tue Sep 13 01:17:58 2016

Fix an issue when parsing extension from file name with white spaces

MimeTypeMap.getFileExtensionFromUrl() only works for encoded urls.
As a result, white space is not supported.
However, file name may contain white spaces.
This causes the method to return empty extensions.
Convert file name to encoded strings doesn't work directly.
For instance, URLEncoder.encode() converts white space to "+" instead of
"%20".
So this change just extract the extension from file name directly.

BUG= 637917 

Review-Url: https://codereview.chromium.org/2338593002
Cr-Commit-Position: refs/heads/master@{#418130}

[modify] https://crrev.com/23ad64c72dc2f116a7b73c2d6803f449ebba2553/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
[modify] https://crrev.com/23ad64c72dc2f116a7b73c2d6803f449ebba2553/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java

Comment 7 by dimu@chromium.org, Sep 13 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 13 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f4ea1eea72472d729b1eed1da19d5505d2535a

commit 95f4ea1eea72472d729b1eed1da19d5505d2535a
Author: Min Qin <qinmin@chromium.org>
Date: Tue Sep 13 18:27:06 2016

Fix an issue when parsing extension from file name with white spaces

MimeTypeMap.getFileExtensionFromUrl() only works for encoded urls.
As a result, white space is not supported.
However, file name may contain white spaces.
This causes the method to return empty extensions.
Convert file name to encoded strings doesn't work directly.
For instance, URLEncoder.encode() converts white space to "+" instead of
"%20".
So this change just extract the extension from file name directly.

TBR=dfalcantara@chromium.org
BUG= 637917 

Review-Url: https://codereview.chromium.org/2338593002
Cr-Commit-Position: refs/heads/master@{#418130}
(cherry picked from commit 23ad64c72dc2f116a7b73c2d6803f449ebba2553)

Review URL: https://codereview.chromium.org/2334163003 .

Cr-Commit-Position: refs/branch-heads/2840@{#335}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java
[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java

Comment 9 by qin...@chromium.org, Sep 13 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Works as per expected behavior, Downloaded video playback immediately.
Tested on latest M54 Beta.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f4ea1eea72472d729b1eed1da19d5505d2535a

commit 95f4ea1eea72472d729b1eed1da19d5505d2535a
Author: Min Qin <qinmin@chromium.org>
Date: Tue Sep 13 18:27:06 2016

Fix an issue when parsing extension from file name with white spaces

MimeTypeMap.getFileExtensionFromUrl() only works for encoded urls.
As a result, white space is not supported.
However, file name may contain white spaces.
This causes the method to return empty extensions.
Convert file name to encoded strings doesn't work directly.
For instance, URLEncoder.encode() converts white space to "+" instead of
"%20".
So this change just extract the extension from file name directly.

TBR=dfalcantara@chromium.org
BUG= 637917 

Review-Url: https://codereview.chromium.org/2338593002
Cr-Commit-Position: refs/heads/master@{#418130}
(cherry picked from commit 23ad64c72dc2f116a7b73c2d6803f449ebba2553)

Review URL: https://codereview.chromium.org/2334163003 .

Cr-Commit-Position: refs/branch-heads/2840@{#335}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java
[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/95f4ea1eea72472d729b1eed1da19d5505d2535a/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java

Comment 12 by mdw@chromium.org, Dec 6 2016

Cc: dah...@chromium.org
Status: Assigned (was: Verified)
This seems to have regressed in 56.0.2924.13.

To repro:

1) Go to:
http://pagalworld.co/filedownload/11330/103428/So%20Much%20in%20Love%20-%20Himesh%20Reshammiya%20MP4.html

2) Click on [Download File] link which is:
http://dl.enjoypur.vc/upload_file/367/382/7491/PagalWorld%20-%20Bollywood%20Mp4%20Video%20Songs%202016/Aap%20Se%20Mausiiquii%20(2016)%20Mp4%20Video%20Songs/So%20Much%20in%20Love%20-%20Himesh%20Reshammiya%20MP4.mp4

The MP4 file downloads in Chrome, but cannot be played back from within Chrome (I see a black screen with the media controls). The file does play back in UC Video and MX Player.
Status: Fixed (was: Assigned)
Per the discussion in  crbug.com/657590 , this is not a regression of this bug, but rather an instance of crbug.com/658290. Changing this to fixed.

Sign in to add a comment