New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637914 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug

Blocked on:
issue 638411



Sign in to add a comment

Run exo wayland server in mus+ash as an independent mus client

Project Member Reported by penghuang@chromium.org, Aug 15 2016

Issue description

Run exo wayland server in mus+ash
 

Comment 1 by sadrul@chromium.org, Aug 15 2016

To clarify: the exo-wayland server in this case would run as a mus client?
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76977a523349abd17da5e57f6935ed73e9d35856

commit 76977a523349abd17da5e57f6935ed73e9d35856
Author: penghuang <penghuang@chromium.org>
Date: Tue Aug 16 15:40:07 2016

Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolates
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG= 637914 

Review-Url: https://codereview.chromium.org/2242283002
Cr-Commit-Position: refs/heads/master@{#412250}

[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/BUILD.gn
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/gamepad.cc
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/gamepad.h
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/keyboard.cc
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/keyboard.h
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/pointer.cc
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/pointer.h
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/shell_surface.cc
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/shell_surface.h
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/touch.cc
[modify] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/wayland/server.cc
[add] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/wm_helper.cc
[add] https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856/components/exo/wm_helper.h

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c

commit 608523d443e9a619abb5f8da7ed2dd7e08ba3f3c
Author: penghuang <penghuang@chromium.org>
Date: Thu Aug 18 17:05:28 2016

exo: Run exo in mus+ash

Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.

BUG= 637914 
TEST=manually with https://github.com/phuang/waylandcxx

Review-Url: https://codereview.chromium.org/2250863003
Cr-Commit-Position: refs/heads/master@{#412861}

[modify] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/chrome/browser/chrome_browser_main_extra_parts_exo.cc
[modify] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/chrome/browser/chrome_browser_main_extra_parts_exo.h
[modify] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/BUILD.gn
[modify] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/test/exo_test_base.cc
[modify] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/test/exo_test_base.h
[modify] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/wm_helper.cc
[modify] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/wm_helper.h
[add] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/wm_helper_ash.cc
[add] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/wm_helper_ash.h
[add] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/wm_helper_mus.cc
[add] https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c/components/exo/wm_helper_mus.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa981039ea66bac847c08c6d68e5cd011f3a1c2f

commit aa981039ea66bac847c08c6d68e5cd011f3a1c2f
Author: penghuang <penghuang@chromium.org>
Date: Mon Aug 22 12:43:24 2016

arc: Use exo::WMHelper to abserve window focus.

In mus+ash, toplevel windows don't share the same focus_client,
so we have to use exo::WMHelper for handling window focus.

BUG= 637914 

Review-Url: https://codereview.chromium.org/2259243002
Cr-Commit-Position: refs/heads/master@{#413433}

[modify] https://crrev.com/aa981039ea66bac847c08c6d68e5cd011f3a1c2f/components/arc/ime/arc_ime_service.cc
[modify] https://crrev.com/aa981039ea66bac847c08c6d68e5cd011f3a1c2f/components/arc/ime/arc_ime_service.h

Blockedon: 638411
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 23 2016

Labels: Proj-Mustash
Components: Internals>MUS
Labels: Proj-Mustash-Milestone-Salamander
Summary: Run exo wayland server in mus+ash as an independent mus client (was: Run exo wayland server in mus+ash)
We do not need this for tadpole. So setting milestone to salamander.
Status: WontFix (was: Assigned)
I think we will not run exo as a separate mus client. It should be in ash or ws process. So mark it as wontfix
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment