New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637911 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

'NoneType' object has no attribute 'download_start_time' from run_suite

Reported by jrbarnette@chromium.org, Aug 15 2016

Issue description

This elm canary just failed:
    https://uberchromegw.corp.google.com/i/chromeos/builders/elm-release/builds/304

Here's the exception:
  Unhandled run_suite exception: 'NoneType' object has no attribute 'download_start_time'
  Traceback (most recent call last):
    File "/usr/local/autotest/site_utils/run_suite.py", line 1708, in main
      (code, output_dict) = main_without_exception_handling(options)
    File "/usr/local/autotest/site_utils/run_suite.py", line 1632, in main_without_exception_handling
      output_dict = collector.get_results_dict()
    File "/usr/local/autotest/site_utils/run_suite.py", line 1372, in get_results_dict
      'download_start' : str(self.timings.download_start_time),
  AttributeError: 'NoneType' object has no attribute 'download_start_time'
  Will return from run_suite with status: INFRA_FAILURE

The problem doesn't seem to happen very often, but I see no reason
to suspect the problem will be isolated to elm, so sheriffs and gardeners
should be on the lookout.

 
Cc: dnojiri@chromium.org shuqianz@chromium.org snanda@chromium.org youcheng@chromium.org jrbarnette@chromium.org sduvvuri@chromium.org
 Issue 628642  has been merged into this issue.
Status: Started (was: Assigned)
This is caused by run() returning early when there are no test views (per comment, can be caused by a suite job aborted in starting state), and objects not being instantiated properly, and code rot (run_suite.py would benefit from refactoring).
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2c5d44bfb681fa8568ffcbdd48a318312841137b

commit 2c5d44bfb681fa8568ffcbdd48a318312841137b
Author: Allen Li <ayatane@chromium.org>
Date: Tue Aug 16 00:58:58 2016

[autotest] Fix timings being None

We fix a type error caused by the accursed NULL style value.  Remember
kids, because dynamic typing isn't exciting enough, any variable could
potentially be None.

BUG= chromium:637911 
TEST=Run run_suite.py with monkeypatched empty _test_view

Change-Id: I80b96ae705026268c874995330ac1208a3e1d389
Reviewed-on: https://chromium-review.googlesource.com/370938
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>

[modify] https://crrev.com/2c5d44bfb681fa8568ffcbdd48a318312841137b/site_utils/run_suite.py

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 9 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 10 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment