Issue metadata
Sign in to add a comment
|
VoiceOver refreshes constantly on some pages |
||||||||||||||||||||||||
Issue descriptionWhen loading some pages with Mac OS X 10.11 and VoiceOver on, Chrome refreshes constantly. Example url that seems to trigger it a lot: http://www.theverge.com/2016/2/11/10970876/twitter-os-x-update-safari-browser-bug-fix I think the problem is Chrome's code to refresh the page when we see a new live region. This was necessary to work around issues in older OS X versions but seems to make things worse in new versions. Let's see if switching to "live region created" notifications fixes it.
,
Aug 30 2016
,
Aug 30 2016
Per chat with nektar@, We will wait until this change is baked/verified in canary and safe to merge to M53.
,
Aug 30 2016
,
Aug 31 2016
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 2 2016
Please merge your change to M54 (branch: 2840) before 5:00 PM PST Monday [09/05] if you would like to make it to M54 Beta promotion on Thursday [09/08].
,
Sep 3 2016
How is this change looking in Canary?
,
Sep 4 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12d413a4df12250b61fa1041492b3b90d219bd54 commit 12d413a4df12250b61fa1041492b3b90d219bd54 Author: Nektarios <nektar@chromium.org> Date: Tue Sep 06 13:46:54 2016 Merge to 54: On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document. BUG= 637895 TESTED=Voiceover R=dmazzoni@chromium.org Review-Url: https://codereview.chromium.org/2297433002 Cr-Commit-Position: refs/heads/master@{#415413} (cherry picked from commit a95b71765f7160f1e5d7b09ede730d223492a595) Review URL: https://codereview.chromium.org/2315733002 . Cr-Commit-Position: refs/branch-heads/2840@{#166} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/accessibility/browser_accessibility_manager.h [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/accessibility/browser_accessibility_manager_mac.mm [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Sep 6 2016
How is this change looking in Canary? Will it be a safe merge to M53? We're cutting M53 Stable RC today so we can take this change in if all looks good in Canary otherwise it will have to wait for next stable refresh if any (by then it will be baked in Beta too).
,
Sep 6 2016
Fix appears to work fine in Canary. 1. I tested manually. 2. I haven't heard any user complaints which would usually come in loud and fast if something is wrong. Having said that, I want to test with M53 manually. What's the best way to do that?
,
Sep 6 2016
Fix has to be merged to M53, then we need to trigger new M53 build for testing.
,
Sep 6 2016
Approving merge to M53 branch 2785 based on comment #12 and per chat with nektar@. He will manually verify the change on M53 once build is ready with fix merged.
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/204aa6ad2d6605a0e050a6266c6864aa714ffcf3 commit 204aa6ad2d6605a0e050a6266c6864aa714ffcf3 Author: Nektarios <nektar@chromium.org> Date: Tue Sep 06 16:13:19 2016 Merge to 53: On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document. BUG= 637895 TESTED=Voiceover R=dmazzoni@chromium.org Review-Url: https://codereview.chromium.org/2297433002 Cr-Commit-Position: refs/heads/master@{#415413} (cherry picked from commit a95b71765f7160f1e5d7b09ede730d223492a595) Review URL: https://codereview.chromium.org/2309853004 . Cr-Commit-Position: refs/branch-heads/2785@{#829} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/204aa6ad2d6605a0e050a6266c6864aa714ffcf3/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/204aa6ad2d6605a0e050a6266c6864aa714ffcf3/content/browser/accessibility/browser_accessibility_manager.h [modify] https://crrev.com/204aa6ad2d6605a0e050a6266c6864aa714ffcf3/content/browser/accessibility/browser_accessibility_manager_mac.mm [modify] https://crrev.com/204aa6ad2d6605a0e050a6266c6864aa714ffcf3/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/204aa6ad2d6605a0e050a6266c6864aa714ffcf3/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Sep 7 2016
Tried to verify the issue on Mac 10.11.6 using 54.0.2840.15 and 53.0.2785.101. nektar@ : There is a little difference when compared to last stable 52.0.2743.116. But not so sure if its fine, could you please review the attaches screen cast of 53.0.2785.101 and confirm.
,
Sep 7 2016
nektar@, could you please check and confirm c#16? I am seeing the same behavior on Win7 64-bit OS for Canary#55.0.2853.0. Thank you!
,
Sep 7 2016
The behavior in the video is fine. However, in order to trigger the bug you have to interact with the HTML contents. Right after navigating to the page: 1. Ctrl-Option-Cmd-right to get to the end of the window where the HTML contents are. 2. Ctrl-option-shift-down to interact with the HTML contents. Tab is not always reliable on the Mac. Ctrl-option-left and ctrl-option-right are the Voiceover navigation keys. Is there a link to the M53 build I could install?
,
Sep 7 2016
Fixed verified manually with M53 stable. You may go ahead.
,
Sep 7 2016
Thank you so much! Appreciate your help.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12d413a4df12250b61fa1041492b3b90d219bd54 commit 12d413a4df12250b61fa1041492b3b90d219bd54 Author: Nektarios <nektar@chromium.org> Date: Tue Sep 06 13:46:54 2016 Merge to 54: On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document. BUG= 637895 TESTED=Voiceover R=dmazzoni@chromium.org Review-Url: https://codereview.chromium.org/2297433002 Cr-Commit-Position: refs/heads/master@{#415413} (cherry picked from commit a95b71765f7160f1e5d7b09ede730d223492a595) Review URL: https://codereview.chromium.org/2315733002 . Cr-Commit-Position: refs/branch-heads/2840@{#166} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/accessibility/browser_accessibility_manager.h [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/accessibility/browser_accessibility_manager_mac.mm [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/12d413a4df12250b61fa1041492b3b90d219bd54/content/browser/renderer_host/render_widget_host_view_mac.mm |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 30 2016