New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637891 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ kbr@chromium.org
dtu@chromium.org
█ benhenry@chromium.org
█ smut@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 637965

Participants' hotlists:
speed-ops-backlog


Sign in to add a comment

Add tests to ensure HiDPI laptops are really running at high resolution

Project Member Reported by sullivan@chromium.org, Aug 15 2016 
In https://bugs.chromium.org/p/chromium/issues/detail?id=636755#c13, we discover that our MacBook Pro Retinas were likely not running at retina resolution. We'd like to add a test to ensure this doesn't happen in the future. We have MacBook Pro Retinas and also a HiDPI windows laptop that could be affected.

Ken, have you hit this issue in GPU testing? Any advice on how we could add a test for this?

Comment 1 by kbr@chromium.org, Aug 15 2016 

In GPU testing we did find that attaching an external display to the Retina MacBook Pros caused them to lose the high-DPI nature of the internal display.

I think you should be able to add a test that only runs on these bots which asserts that window.devicePixelRatio is 2, or at least, greater than 1.

Comment 2 by sullivan@chromium.org, Aug 15 2016

Blockedon: 637965

Comment 3 by benhenry@google.com, Aug 15 2016

Cc: smut@chromium.org
Sana may know something that can help here.

Comment 4 by benhenry@chromium.org, Aug 16 2016

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)

Comment 5 by mar...@chromium.org, Aug 18 2016 

Here's the code in Swarming to detect hidpi:
https://github.com/luci/luci-py/blob/master/appengine/swarming/swarming_bot/api/platforms/osx.py#L247

I parses "system_profiler SPDisplaysDataType -xml" output. I should probably change the 'any' at line 251 to 'all' and that would fix the problem permanently.

Comment 6 by petrcermak@chromium.org, Oct 5 2016

Cc: -petrcermak@chromium.org

Comment 7 by petrcermak@chromium.org, Oct 5 2016

Cc: -petrcermak@chromium.org

Comment 8 by benhenry@chromium.org, Feb 14 2017 

I just added this to the perf backlog. It seems something easy to add.

Comment 9 by benhenry@chromium.org, Mar 10 2017

Components: Speed>Benchmarks>Waterfall
Labels: -Performance-Waterfall
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment