New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637883 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 641951



Sign in to add a comment

Remove a invisible shelf flag for arc++

Project Member Reported by osh...@chromium.org, Aug 15 2016

Issue description

Invisible auto hide shelf is added in https://codereview.chromium.org/2248773002/ for arc++ windows to address the issue  crbug.com/634566 .

Remove the flag once MD-ash is launched because auto hide shelf is always invisible.

 
Labels: Needs-Feedback
Tom, can you see how UI review would feel if we were to make the new immersive mode default everywhere in M55 (i.e., no shelf hints visible at bottom and no tab hints visible at top when in immersive)?

Doing so would help simplify code, and IMO the immersive mode changes aren't really "material design" anyway so I don't see why they'd need to be tied to the MD shelf/menu launch.
Blockedon: 641951
Labels: Proj-MaterialDesign-CrOS
Status: Assigned (was: Untriaged)
Oshima, FYI Yi is in the process of enabling the new immersive style by default: https://codereview.chromium.org/2326703002/
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787

commit 0fbf3db90eebb9d08218dc41b2ddf7b9ad721787
Author: oshima <oshima@chromium.org>
Date: Fri Sep 30 17:39:24 2016

Revert auto-hide-invisible mode for ARC++

This was added in https://codereview.chromium.org/2248773002
to implement MD's new auto hide behavior for ARC++ windows. This is now default, so reverting that part.

BUG= 637883 

Review-Url: https://codereview.chromium.org/2368343002
Cr-Commit-Position: refs/heads/master@{#422147}

[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/ash/common/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/ash/common/shelf/shelf_layout_manager.h
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/ash/common/wm/immersive_context_ash.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/ash/common/wm/window_state.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/ash/common/wm/window_state.h
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/chrome/browser/notifications/fullscreen_notification_blocker.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/0fbf3db90eebb9d08218dc41b2ddf7b9ad721787/components/exo/shell_surface.cc

Comment 7 by osh...@chromium.org, Sep 30 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 12 2016

Labels: -Merge-TBD

Sign in to add a comment