Issue metadata
Sign in to add a comment
|
Notification button does not show properly when shelf orientation changes |
||||||||||||||||||||||
Issue descriptionVersion: Chrome @411418 OS: Chrome OS What steps will reproduce the problem? (1) build chrome (2) change shelf orientation from bottom to left What is the expected output? The background of notification button does not change size as shelf alignment changes. What do you see instead? The height of the background of the notification button is decrease. When the shelf is set to bottom, then the background of the notification button is decreased significantly. Please use labels and text to provide additional information.
,
Aug 15 2016
,
Aug 15 2016
,
Aug 15 2016
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e311188e565ea85ccc4ad8f0aeee03eab488bb23 commit e311188e565ea85ccc4ad8f0aeee03eab488bb23 Author: yiyix <yiyix@chromium.org> Date: Mon Aug 15 21:53:27 2016 Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG= 637882 Review-Url: https://codereview.chromium.org/2247893002 Cr-Commit-Position: refs/heads/master@{#412060} [modify] https://crrev.com/e311188e565ea85ccc4ad8f0aeee03eab488bb23/ash/common/system/web_notification/web_notification_tray.cc
,
Aug 16 2016
Thank you for fixing that. The original issue (Issue 633399) is for M53, so let me change the target.
,
Aug 16 2016
yoshiki@, are you going to handle the merge back into 53? If so please mark yourself as the owner of this bug.
,
Aug 16 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 18 2016
Let me merge.
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c1257266665f6b80473a17347edfda7fd7f57f9 commit 9c1257266665f6b80473a17347edfda7fd7f57f9 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Aug 18 01:12:10 2016 Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG= 637882 Review-Url: https://codereview.chromium.org/2247893002 Cr-Commit-Position: refs/heads/master@{#412060} (cherry picked from commit e311188e565ea85ccc4ad8f0aeee03eab488bb23) Review URL: https://codereview.chromium.org/2256053002 . Cr-Commit-Position: refs/branch-heads/2785@{#650} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/9c1257266665f6b80473a17347edfda7fd7f57f9/ash/common/system/web_notification/web_notification_tray.cc
,
Aug 18 2016
Merged. Thank you for fixing this!
,
Aug 19 2016
Verified on ChromeOS:8530.63.0/chrome:53.0.2785.72
,
Aug 19 2016
Issue 639020 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yiyix@chromium.org
, Aug 15 20164.9 KB
4.9 KB View Download
16.2 KB
16.2 KB View Download