New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637875 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Flakiness dashboard script error when testType= used validly but yields no results

Project Member Reported by dbeam@chromium.org, Aug 15 2016

Issue description

maps_pixel_test flaked and my unrelated change was implicated.  I wanted to help the sheriff with more resources to understand the flakiness of some tests, but loading:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=maps_pixel_test

is throwing a script error

there is an empty array in builders.testTypeToBuilder['maps_pixel_test'], but we're not handling when a valid builder+test combo yields no results (empty array).
 
2016-08-15-104117_1164x983_scrot.png
234 KB View Download
2016-08-15-104128_1163x984_scrot.png
259 KB View Download
2016-08-15-104149_1161x983_scrot.png
216 KB View Download
2016-08-15-104256_645x380_scrot.png
67.9 KB View Download

Comment 1 by dbeam@chromium.org, Aug 15 2016

Labels: -OS-Linux OS-All

Comment 2 by estaab@chromium.org, Aug 21 2016

Owner: estaab@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7d702289691c58830d668dd64d3f3e4f5e27bf0c

commit 7d702289691c58830d668dd64d3f3e4f5e27bf0c
Author: Erik Staab <estaab@google.com>
Date: Mon Aug 22 20:35:11 2016

test-results: show navbar and message when no builders exist for a test type.

BUG= 637875 

Change-Id: I878bddedd5af3db01c74626da06c924893d5e48b
Reviewed-on: https://chromium-review.googlesource.com/373372
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7d702289691c58830d668dd64d3f3e4f5e27bf0c/go/src/infra/appengine/test-results/frontend/static/dashboards/flakiness_dashboard.js

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7d702289691c58830d668dd64d3f3e4f5e27bf0c

commit 7d702289691c58830d668dd64d3f3e4f5e27bf0c
Author: Erik Staab <estaab@google.com>
Date: Mon Aug 22 20:35:11 2016

test-results: show navbar and message when no builders exist for a test type.

BUG= 637875 

Change-Id: I878bddedd5af3db01c74626da06c924893d5e48b
Reviewed-on: https://chromium-review.googlesource.com/373372
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7d702289691c58830d668dd64d3f3e4f5e27bf0c/go/src/infra/appengine/test-results/frontend/static/dashboards/flakiness_dashboard.js

Comment 5 by estaab@chromium.org, Aug 27 2016

Status: Fixed (was: Started)

Sign in to add a comment