ShelfLayoutManagerTest.ShutdownHandlesWindowActivation is flaky; crashes intermittently |
||||
Issue descriptionShelfLayoutManagerTest.ShutdownHandlesWindowActivation seems to crash repeatedly sometimes. Based on the dashboard it looks like it's been doing this for a while. For example see https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/272022/steps/ash_unittests%20%28with%20patch%29%20on%20Windows-7-SP1/logs/stdio where it has the following backtrace: views::Widget::GetNativeWindow [0x00D7C9AE+0] ash::WmLookupAura::GetWindowForWidget [0x00A482A9+11] ash::ShelfLayoutManager::IsShelfWindow [0x00A10D2E+60] ash::ShelfLayoutManager::UpdateAutoHideForMouseEvent [0x00A113F6+42] ash::WmShelfAura::AutoHideEventHandler::OnMouseEvent [0x00A3FF7E+44] ui::EventHandler::OnEvent [0x00CEEAFA+41] ui::EventDispatcher::DispatchEvent [0x00CEFBDE+61] ui::EventDispatcher::DispatchEventToEventHandlers [0x00CEFD3D+121] ui::EventDispatcher::ProcessEvent [0x00CEFEA7+89] ui::EventDispatcherDelegate::DispatchEventToTarget [0x00CEFDE8+42] ui::EventDispatcherDelegate::DispatchEvent [0x00CEFC85+135] ui::EventProcessor::OnEventFromSource [0x00CF0DC1+308] ui::EventSource::DeliverEventToProcessor [0x00CF09C1+80] ui::EventSource::SendEventToProcessor [0x00CF0AA2+214] ash::AshWindowTreeHostPlatform::DispatchEvent [0x00A5027F+171] ui::WinWindow::OnMouseRange [0x011F0664+124] ui::WinWindow::_ProcessWindowMessage [0x011F0929+141] ui::WinWindow::ProcessWindowMessage [0x011F07BF+36] gfx::WindowImpl::OnWndProc [0x00D15157+44] gfx::WindowImpl::WndProc [0x00D153AE+154] base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc> [0x00D14C5A+37] gapfnScSendMessage [0x750C62FA+818] GetThreadDesktop [0x750C6D3A+215] CharPrevW [0x750C77C4+312] DispatchMessageW [0x750C788A+15] base::MessagePumpForUI::ProcessMessageHelper [0x00AB1C57+199] base::MessagePumpForUI::ProcessPumpReplacementMessage [0x00AB1D7D+237] base::MessagePumpForUI::ProcessMessageHelper [0x00AB1C35+165] base::MessagePumpForUI::DoRunLoop [0x00AB1346+70] base::MessagePumpWin::Run [0x00AB1FAA+74] base::MessageLoop::RunHandler [0x00A647C7+103] base::RunLoop::RunUntilIdle [0x00A5F38D+45] ash::test::AshTestHelper::RunAllPendingInMessageLoop [0x00A53C90+101] ash::test::AshTestBase::TearDown [0x00A51847+27] testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x00CB20BF+32] testing::Test::Run [0x00CB8821+126] testing::TestInfo::Run [0x00CB8981+126] testing::TestCase::Run [0x00CB88AC+133] testing::internal::UnitTestImpl::RunAllTests [0x00CB8C2C+434] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00CB2103+32] testing::UnitTest::Run [0x00CB8A55+133] base::TestSuite::Run [0x00AC50BC+95] base::LaunchUnitTests [0x00AC6418+746] base::LaunchUnitTests [0x00AC6178+74] main [0x005C0777+77] __scrt_common_main_seh [0x01353299+255] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255) BaseThreadInitThunk [0x75AF336A+18] RtlInitializeExceptionChain [0x77709882+99] RtlInitializeExceptionChain [0x77709855+54]
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d69609e8385c0204b1baadc261711fe7ebd7a05 commit 1d69609e8385c0204b1baadc261711fe7ebd7a05 Author: bsep <bsep@chromium.org> Date: Mon Aug 15 18:40:04 2016 Disable ShutdownHandlesWindowActivation due to flaky crashes. TBR=jonross BUG= 637873 Review-Url: https://codereview.chromium.org/2249673002 Cr-Commit-Position: refs/heads/master@{#412000} [modify] https://crrev.com/1d69609e8385c0204b1baadc261711fe7ebd7a05/ash/shelf/shelf_layout_manager_unittest.cc
,
Aug 15 2016
I've been working on this code recently, so I'll take this. bsep, thanks for filing and disabling, but please only disable tests on affected platforms; this shouldn't have been disabled on Linux and especially not Chrome OS (where the shelf is used).
,
Aug 15 2016
My bad, I misread the results and thought it was only running on Windows. I'll re-patch it to only disable it on Windows.
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7686bf2e576e1c2985b8255e05ac798ebfbcf126 commit 7686bf2e576e1c2985b8255e05ac798ebfbcf126 Author: bsep <bsep@chromium.org> Date: Mon Aug 15 20:42:14 2016 Renable ShutdownHandlesWindowActivation on non-Windows platforms. TBR=msw BUG= 637873 Review-Url: https://codereview.chromium.org/2244243003 Cr-Commit-Position: refs/heads/master@{#412037} [modify] https://crrev.com/7686bf2e576e1c2985b8255e05ac798ebfbcf126/ash/shelf/shelf_layout_manager_unittest.cc
,
Jan 7 2017
Ash doesn't run on Windows anymore.
,
Jan 24 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bsep@chromium.org
, Aug 15 2016Status: Assigned (was: Untriaged)