New issue
Advanced search Search tips

Issue 637872 link

Starred by 1 user
Status: Fixed
Owner:
qin...@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester

Project Member Reported by nyquist@chromium.org, Aug 15 2016 
The following test fails:
org.chromium.chrome.browser.contextmenu.ContextMenuTest#testSaveVideo

The first failing build:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/5074

Probable culprit CL:
https://codereview.chromium.org/2239063004

This seems to be related:
7c40f:  08-12 18:25:39.251 26789 26789 E art     : JNI ERROR (app bug): expected jboolean (0/1) but got value of 16 as argument 11 to org.chromium.chrome.browser.contextmenu.ContextMenuParams org.chromium.chrome.browser.contextmenu.ContextMenuParams.create(int, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, boolean, java.lang.String, int, boolean)
7c40f:  08-12 18:25:39.346 26789 26789 F art     : art/runtime/java_vm_ext.cc:410] JNI DETECTED ERROR IN APPLICATION: bad arguments passed to org.chromium.chrome.browser.contextmenu.ContextMenuParams org.chromium.chrome.browser.contextmenu.ContextMenuParams.create(int, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, boolean, java.lang.String, int, boolean) (see above for details)

Comment 1 by nyquist@chromium.org, Aug 15 2016

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cb73c80e01b0a28c76586b25d0f6accd1e09231

commit 0cb73c80e01b0a28c76586b25d0f6accd1e09231
Author: nyquist <nyquist@chromium.org>
Date: Mon Aug 15 18:36:33 2016

Revert of Fix an issue that "save video" context menu appears for MSE video (patchset #1 id:1 of https://codereview.chromium.org/2239063004/ )

Reason for revert:
Breaks Marshmallow Tablet Tester.
See  https://crbug.com/637872  for details.

Original issue's description:
> Fix an issue that "save video" context menu appears for MSE video
>
> We should use media_flags to determine if a video can be saved.
>
> BUG= 637010 
>
> Committed: https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e
> Cr-Commit-Position: refs/heads/master@{#411807}

TBR=yfriedman@chromium.org,dalecurtis@chromium.org,qinmin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 637010 ,  637872 

Review-Url: https://codereview.chromium.org/2244343002
Cr-Commit-Position: refs/heads/master@{#411997}

[modify] https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
[modify] https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231/chrome/browser/ui/android/context_menu_helper.cc

Comment 4 by qin...@chromium.org, Aug 16 2016

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment