New issue
Advanced search Search tips

Issue 637866 link

Starred by 1 user
Status: Fixed
Owner:
r...@chromium.org
Closed: Aug 2016
Cc:
h...@chromium.org
infe...@chromium.org
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 637864
issue 638314
Blocking:
issue 636558



Sign in to add a comment

Roll clang past r278571

Project Member Reported by r...@chromium.org, Aug 15 2016 
We need to pick up is the inliner/inalloca bugfix for WinASan.

This morning we had a lot of redness due to James Molloy's SimplifyCFG change, which I reverted. Still looking through the rest of the bots.

Comment 1 by r...@chromium.org, Aug 15 2016 

 http://crbug.com/637864  looks like it will be hard. We need someone who knows how to replicate the iOS build to get a reduction.

Comment 2 by r...@chromium.org, Aug 16 2016

Blockedon: 638314
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92c4889905b14456f84a4631eafb168328b5f8a5

commit 92c4889905b14456f84a4631eafb168328b5f8a5
Author: guidou <guidou@chromium.org>
Date: Thu Aug 18 10:14:35 2016

Revert of Roll clang 277962:278861 (patchset #5 id:80001 of https://codereview.chromium.org/2241413003/ )

Reason for revert:
This is suspect of breaking Mac 10.9 builder.

See
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/28850

Sample logs:
Retrying 1 test (retry #1)
[0817/224954:ERROR:kill_posix.cc(84)] Unable to terminate process group 8687: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2060/2060] ThreadTest.StartWithOptions_StackSize (CRASHED)
Retrying 1 test (retry #2)
[0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8688: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2061/2061] ThreadTest.StartWithOptions_StackSize (CRASHED)
Retrying 1 test (retry #3)
[0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8689: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2062/2062] ThreadTest.StartWithOptions_StackSize (CRASHED)
1 test crashed:
    ThreadTest.StartWithOptions_StackSize (../../base/threading/thread_unittest.cc:135)
Tests took 21 seconds.
Additional test environment:
    CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox
    LANG=en_US.UTF-8
Command: ./base_unittests --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-summary-output=/b/swarm_slave/w/ionk6XHB/output.json

Original issue's description:
> Roll clang 277962:278861
>
> BUG= 636558 , 637866 
>
> Committed: https://crrev.com/29ecb32ba7b5ca183782c5f5d2b7a1ae23309edb
> Cr-Commit-Position: refs/heads/master@{#412745}

TBR=rnk@chromium.org,dcheng@chromium.org,dpranke@chromium.org,inferno@chromium.org,hans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636558 , 637866 

Review-Url: https://codereview.chromium.org/2249163007
Cr-Commit-Position: refs/heads/master@{#412785}

[modify] https://crrev.com/92c4889905b14456f84a4631eafb168328b5f8a5/base/threading/thread_unittest.cc
[modify] https://crrev.com/92c4889905b14456f84a4631eafb168328b5f8a5/build/config/compiler/BUILD.gn
[modify] https://crrev.com/92c4889905b14456f84a4631eafb168328b5f8a5/tools/clang/scripts/update.py
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b557e12b23a45aaff07428fc164934020e10c4ff

commit b557e12b23a45aaff07428fc164934020e10c4ff
Author: hans <hans@chromium.org>
Date: Fri Aug 19 01:24:02 2016

Revert of Roll clang 277962:278861 (patchset #6 id:100001 of https://codereview.chromium.org/2241413003/ )

Reason for revert:
This broke the build on a certain Mac builder:
https://build.chromium.org/p/chromium/builders/Mac/builds/18669

It looks like the build is timing out maybe? All other Mac
builders seem happy though, which makes this confusing, but
the buildbot logs very clearly implicate the roll: the same
kind of error happened last time it landed, and it went away
on the previous revert.

Original issue's description:
> Roll clang 277962:278861
>
> BUG= 636558 , 637866 
>
> Committed: https://crrev.com/df7510f96322254211068a52c2b459c0fe0b2090
> Cr-Commit-Position: refs/heads/master@{#412943}

TBR=rnk@chromium.org,dcheng@chromium.org,dpranke@chromium.org,inferno@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636558 , 637866 

Review-Url: https://codereview.chromium.org/2257333002
Cr-Commit-Position: refs/heads/master@{#412999}

[modify] https://crrev.com/b557e12b23a45aaff07428fc164934020e10c4ff/base/threading/thread_unittest.cc
[modify] https://crrev.com/b557e12b23a45aaff07428fc164934020e10c4ff/build/config/compiler/BUILD.gn
[modify] https://crrev.com/b557e12b23a45aaff07428fc164934020e10c4ff/tools/clang/scripts/update.py

Comment 8 by thakis@chromium.org, Aug 30 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment