Site Details page no longer accessible |
||
Issue descriptionUnder Site Settings, click on All Sites (or any category with data in it) and try to click on a site. Expected: Site Details page comes up. Actual results: Blank page, no error. I notice that if I hard-code a route-path for site_details then it starts working again... but only for the category I hard-code it to. I suspect this CL: https://codereview.chromium.org/2224163002
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6 commit 1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6 Author: tommycli <tommycli@chromium.org> Date: Wed Aug 17 19:06:01 2016 Settings: Fix Site Details subpage routing Goal is: A site details subpage that's accessible both from /siteSettings/all, /siteSettings/bluetooth, /siteSettings/plugins, etc. (all the categories). Previous way it was done was: Separate route for each category, so there was /siteSettings/all/details, /siteSettings/bluetooth/details, /siteSettings/plugins/details. And it relied on a quirk of how settings-animated-pages used to work to coalesce all those routes to a single card. New way I'm proposing: One single /siteSettings/siteDetails route. But here are some extra needed changes: - settings-animated-pages must slide right / left based on route depth instead of based on .contains() - subpage-back button needs to call window.history.back() whenever there is a previous route, even if the previous route doesn't strictly contain the current route. I think the above two changes are harmless and the new version is overall an improvement. BUG= 637865 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2249873003 Cr-Commit-Position: refs/heads/master@{#412605} [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/browser/resources/settings/route.js [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/browser/resources/settings/settings_page/settings_subpage.js [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/test/data/webui/settings/route_tests.js [modify] https://crrev.com/1e19d86e3aaafb89470cbc5b5d8b74695b49f2d6/chrome/test/data/webui/settings/settings_subpage_test.js
,
Aug 17 2016
Hopefully this is fixed finnur. Feel free to reopen if anything is still broken. |
||
►
Sign in to add a comment |
||
Comment 1 by tommycli@chromium.org
, Aug 16 2016