New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Use testharness.js instead of js-test.js in fast/images/

Project Member Reported by siva.gun...@samsung.com, Aug 15 2016

Issue description

Use testharness.js instead of js-test.js in fast/images/
 
Labels: OS-All
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d3156f22a42e0da256c80134684ebfb7d99225c

commit 7d3156f22a42e0da256c80134684ebfb7d99225c
Author: siva.gunturi <siva.gunturi@samsung.com>
Date: Tue Aug 16 14:28:30 2016

Use testharness.js instead of js-test.js in fast/images.

This patch uses testharness.js instead of js-test.js.
Other changes involved are
1. Move image-error-event-not-firing.html to http/tests/images/.
Make sure the destination url used in the test exists.
2.Add test images to http/tests/resources folder.
3.Change DOCTYPE declarations.

BUG= 637859 .

Review-Url: https://codereview.chromium.org/2227423002
Cr-Commit-Position: refs/heads/master@{#412230}

[delete] https://crrev.com/0906a0189f972bf46ea3b877a0a8648d057e478b/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout-expected.txt
[modify] https://crrev.com/7d3156f22a42e0da256c80134684ebfb7d99225c/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html
[delete] https://crrev.com/0906a0189f972bf46ea3b877a0a8648d057e478b/third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing-expected.txt
[delete] https://crrev.com/0906a0189f972bf46ea3b877a0a8648d057e478b/third_party/WebKit/LayoutTests/fast/images/image-error-event-not-firing.html
[delete] https://crrev.com/0906a0189f972bf46ea3b877a0a8648d057e478b/third_party/WebKit/LayoutTests/fast/images/natural-dimensions-correct-after-image-reset-expected.txt
[modify] https://crrev.com/7d3156f22a42e0da256c80134684ebfb7d99225c/third_party/WebKit/LayoutTests/fast/images/natural-dimensions-correct-after-image-reset.html
[add] https://crrev.com/7d3156f22a42e0da256c80134684ebfb7d99225c/third_party/WebKit/LayoutTests/http/tests/images/image-error-event-not-firing.html

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79331e5aff1549688db5bcde820812827e6fbd97

commit 79331e5aff1549688db5bcde820812827e6fbd97
Author: siva.gunturi <siva.gunturi@samsung.com>
Date: Tue Aug 16 14:56:25 2016

Use testharness.js instead of js-test.js in fast/images.

This patch replaces js-test.js with testharness.js in
1.Onload event after reloading image test.
2.Document add remove listener test.
and changes DOCTYPE declarations in
border.html and cmyk-jpeg-with-color-profile.html.

BUG= 637859 

Review-Url: https://codereview.chromium.org/2246303003
Cr-Commit-Position: refs/heads/master@{#412235}

[modify] https://crrev.com/79331e5aff1549688db5bcde820812827e6fbd97/third_party/WebKit/LayoutTests/fast/images/border.html
[modify] https://crrev.com/79331e5aff1549688db5bcde820812827e6fbd97/third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html
[delete] https://crrev.com/e99b9c69a63d7857dd397ae2e488a16cc8e7c48d/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener-expected.txt
[modify] https://crrev.com/79331e5aff1549688db5bcde820812827e6fbd97/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html
[delete] https://crrev.com/e99b9c69a63d7857dd397ae2e488a16cc8e7c48d/third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-broken-image-load-expected.txt
[modify] https://crrev.com/79331e5aff1549688db5bcde820812827e6fbd97/third_party/WebKit/LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-broken-image-load.html

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23

commit f6ceacf5494a9fff8d53c86d6a39f19f954c8e23
Author: siva.gunturi <siva.gunturi@samsung.com>
Date: Wed Aug 17 11:54:01 2016

Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG= 638288 ,  637859 

Review-Url: https://codereview.chromium.org/2250323002
Cr-Commit-Position: refs/heads/master@{#412501}

[modify] https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50cc56a7af56811b317d2af42d9f22fc4ffba3e0

commit 50cc56a7af56811b317d2af42d9f22fc4ffba3e0
Author: siva.gunturi <siva.gunturi@samsung.com>
Date: Thu Aug 18 12:11:08 2016

Use document.ElementFromPoint instead of eventsender.

This patch takes care of TODO to replace
eventsender with document.ElementFromPoint.

BUG= 637859 

Review-Url: https://codereview.chromium.org/2244333004
Cr-Commit-Position: refs/heads/master@{#412801}

[modify] https://crrev.com/50cc56a7af56811b317d2af42d9f22fc4ffba3e0/third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd18b4775d4038af7512dfc72b2bc17425faabb

commit 0fd18b4775d4038af7512dfc72b2bc17425faabb
Author: siva.gunturi <siva.gunturi@samsung.com>
Date: Fri Aug 19 14:50:41 2016

Convert image size and zoom level test to testharness.js

1.Remove zoomed-offset-size-expected.txt.
2.Simply code to test whether image size is changed when
zoom level is altered.

BUG= 637859 

Review-Url: https://codereview.chromium.org/2260773002
Cr-Commit-Position: refs/heads/master@{#413146}

[modify] https://crrev.com/0fd18b4775d4038af7512dfc72b2bc17425faabb/third_party/WebKit/LayoutTests/fast/images/zoomed-offset-size-expected.txt
[modify] https://crrev.com/0fd18b4775d4038af7512dfc72b2bc17425faabb/third_party/WebKit/LayoutTests/fast/images/zoomed-offset-size.html

Status: Fixed (was: Started)

Sign in to add a comment