New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637854 link

Starred by 1 user
Status: Verified
Owner:
osh...@chromium.org
Closed: Aug 2016
Cc:
█ skuhne@chromium.org
█ kuscher@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[Arc++] immersive fullscreen should have black background that covers entire screen if pillar/letter boxed

Project Member Reported by osh...@chromium.org, Aug 15 2016 

immersive fullscreen should have black background that covers entire screen

Comment 1 by keta...@chromium.org, Aug 15 2016 

Oshima@ do you have any mocks/UI design for this work? Have we just started the work or do we already have CLs for this? Is this for Arc++?

Comment 2 by osh...@chromium.org, Aug 15 2016

Summary: immersive fullscreen should have black background that covers entire screen if pillar/letter boxed (was: immersive fullscreen should have black background that covers entire screen)

Comment 3 by osh...@chromium.org, Aug 15 2016 

It's just a black background. Here is how it will look.

Comment 4 by osh...@chromium.org, Aug 16 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2251543002/

Comment 5 by keta...@chromium.org, Aug 17 2016

Summary: [Arc++] immersive fullscreen should have black background that covers entire screen if pillar/letter boxed (was: immersive fullscreen should have black background that covers entire screen if pillar/letter boxed)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c81e0cce848adda65b4e78b1a6a51e6670296e5f

commit c81e0cce848adda65b4e78b1a6a51e6670296e5f
Author: oshima <oshima@chromium.org>
Date: Thu Aug 18 17:13:14 2016

Add solid black background for arc immersive fullscreen.

BUG= 637854 

Review-Url: https://codereview.chromium.org/2251543002
Cr-Commit-Position: refs/heads/master@{#412865}

[modify] https://crrev.com/c81e0cce848adda65b4e78b1a6a51e6670296e5f/components/exo/shell_surface.cc
[modify] https://crrev.com/c81e0cce848adda65b4e78b1a6a51e6670296e5f/components/exo/shell_surface_unittest.cc

Comment 7 by osh...@chromium.org, Aug 19 2016

Labels: Merge-Request-53

Comment 8 by dimu@chromium.org, Aug 19 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 9 by osh...@chromium.org, Aug 19 2016

Labels: -Merge-Approved-53 merge-merged-2785
Status: Fixed (was: Started)
Committed in 6002f379e9052cda4a3573391d79179c95d3c97e.

Comment 10 by osh...@chromium.org, Aug 19 2016

Labels: -Hotlist-Merge-Approved

Comment 11 by abod...@chromium.org, Oct 5 2016

Status: Verified (was: Fixed)
ChromeOS build 8530.96.0 / 53.0.2785.154
►

Sign in to add a comment