New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637844 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 628263
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

regression in system_health.memory_desktop at 405210:405235

Project Member Reported by petrcermak@chromium.org, Aug 15 2016

Issue description

Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Aug 15 2016

Mergedinto: 628263
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add benchmark that imitates news reading.
Author  : ulan
Commit description:
  
Each story in the benchmark does the following:
1. Load the main page.
2. Open and scroll the first news item.
3. Go back to the main page and scroll it.
4. Open and scroll the second news item.
5. Go back to the main page and scroll it.
6. etc.

This workflow is interesting because it is close to real world
and generates a lot of garbage by creating and discarding pages.

A couple of websites crash with OOM on svelte device, so by
tracking and optimizing for this benchmark we can improve
user experience on low-memory devices.

*** NOTE TO SHERRIF ***
Regressions are expected in system_health.memory_mobile and
system_health.memory_desktop for the following stories:
- load:news:cnn
- load:social:facebook
- load:news:qq
- load:news:reddit
- load:social:twitter

If there are failing tests in form of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*
please do not revert this CL but instead disabling failing
test by adding them into the _DISABLE_TESTS list in
tools/perf/benchmarks/system_health_smoke_test.py

BUG=589726
CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2118293002
Cr-Commit-Position: refs/heads/master@{#405212}
Commit  : 5b1847df818e5be4592e9a6ac4832350bb663023
Date    : Wed Jul 13 17:39:28 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N  Good?
chromium@405209  26708234  72687.2  5  good
chromium@405211  26756891  43684.0  5  good
chromium@405212  27726015  123794   5  bad    <--
chromium@405213  27749876  71418.9  4  bad
chromium@405216  27761215  53309.4  5  bad
chromium@405222  27731955  31032.3  5  bad
chromium@405235  27713613  83588.5  5  bad

Bisect job ran on: win_perf_bisect
Bug ID: 637844

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_news-memory:chrome:all_processes:reported_by_chrome:winheap:effective_size_avg/load_news_qq
Relative Change: 3.76%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6832
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004250664634466656


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5794270078828544

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment