The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7a5d36f502f953bdceaeb9a4c31ab621f89be08

commit f7a5d36f502f953bdceaeb9a4c31ab621f89be08
Author: ricea <ricea@chromium.org>
Date: Thu Aug 18 15:40:10 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259813002
Cr-Commit-Position: refs/heads/master@{#412840}

[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/content/browser/content_password_manager_driver_factory.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/content/renderer/credential_manager_client.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/affiliation_fetch_throttler_unittest.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/export/password_csv_writer_unittest.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/export/password_exporter.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/password_store_default_unittest.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/password_store_factory_util.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/f7a5d36f502f953bdceaeb9a4c31ab621f89be08/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b385fe1ca886bbfbc38648f1498a154ac85925a

commit 2b385fe1ca886bbfbc38648f1498a154ac85925a
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 08:35:08 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256193002
Cr-Commit-Position: refs/heads/master@{#413087}

[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/autocomplete/autocomplete_classifier_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/autocomplete/shortcuts_backend_factory.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/bookmarks/bookmark_model_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/bookmarks/startup_task_runner_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/favicon/favicon_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/google/google_url_tracker_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/history/history_client_impl.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/history/history_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/history/web_history_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/ios_chrome_io_thread.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/ios_chrome_main_parts.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/metrics/ios_chrome_origins_seen_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/net/ios_chrome_url_request_context_getter.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/search_engines/template_url_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/services/gcm/ios_chrome_gcm_profile_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/signin/account_consistency_service_factory.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/signin/gaia_cookie_manager_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/signin/signin_client_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/suggestions/suggestions_service_factory.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/sync/sync_setup_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/translate/translate_accept_languages_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/chrome/browser/web_data_service_factory.cc
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/crnet/crnet_environment.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/net/crn_http_protocol_handler.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/2b385fe1ca886bbfbc38648f1498a154ac85925a/ios/web/webui/url_data_manager_ios_backend.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4bfd81cdab01a081b08d362b864df0dcac4740a

commit c4bfd81cdab01a081b08d362b864df0dcac4740a
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 12:06:54 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2255133002
Cr-Commit-Position: refs/heads/master@{#413112}

[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/lib/browser/headless_devtools.cc
[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/lib/headless_browser_context_browsertest.cc
[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/public/internal/value_conversions.h
[modify] https://crrev.com/c4bfd81cdab01a081b08d362b864df0dcac4740a/headless/test/headless_browser_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d689a77f1fcbd63909fc6eebf3df553715fef9bf

commit d689a77f1fcbd63909fc6eebf3df553715fef9bf
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 12:25:21 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252343002
Cr-Commit-Position: refs/heads/master@{#413116}

[modify] https://crrev.com/d689a77f1fcbd63909fc6eebf3df553715fef9bf/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/d689a77f1fcbd63909fc6eebf3df553715fef9bf/components/omnibox/browser/base_search_provider.cc
[modify] https://crrev.com/d689a77f1fcbd63909fc6eebf3df553715fef9bf/components/omnibox/browser/history_url_provider_unittest.cc
[modify] https://crrev.com/d689a77f1fcbd63909fc6eebf3df553715fef9bf/components/omnibox/browser/omnibox_edit_unittest.cc
[modify] https://crrev.com/d689a77f1fcbd63909fc6eebf3df553715fef9bf/components/omnibox/browser/scored_history_match_unittest.cc
[modify] https://crrev.com/d689a77f1fcbd63909fc6eebf3df553715fef9bf/components/omnibox/browser/shortcuts_backend_unittest.cc
[modify] https://crrev.com/d689a77f1fcbd63909fc6eebf3df553715fef9bf/components/omnibox/browser/shortcuts_provider_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec

commit ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 14:18:40 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256943003
Cr-Commit-Position: refs/heads/master@{#413134}

[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl_unittest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/renderer/throttling_helper_unittest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
[modify] https://crrev.com/ed4d66a321cf2f053ce0c3c81e8ad51a453d75ec/third_party/WebKit/Source/platform/scheduler/test/renderer_scheduler_test_support.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7344d1ab4a98fedab5e75070a8b03aa894ff3b74

commit 7344d1ab4a98fedab5e75070a8b03aa894ff3b74
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 14:26:24 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2258493003
Cr-Commit-Position: refs/heads/master@{#413137}

[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/base/cast_sys_info_android.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/base/cast_sys_info_util_simple.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/base/device_capabilities_impl.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/base/device_capabilities_impl_unittest.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/browser/test/chromecast_browser_test_helper_default.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/crash/linux/crash_testing_utils.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/crash/linux/dump_info.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/crash/linux/synchronized_minidump_manager.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/media/cdm/cast_cdm_proxy.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/media/cma/base/multi_demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc
[modify] https://crrev.com/7344d1ab4a98fedab5e75070a8b03aa894ff3b74/chromecast/net/connectivity_checker_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5ddf366ba98d052497b5dc56187704f914ec8f6

commit c5ddf366ba98d052497b5dc56187704f914ec8f6
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 16:14:46 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2258523003
Cr-Commit-Position: refs/heads/master@{#413159}

[modify] https://crrev.com/c5ddf366ba98d052497b5dc56187704f914ec8f6/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc
[modify] https://crrev.com/c5ddf366ba98d052497b5dc56187704f914ec8f6/mojo/public/cpp/bindings/lib/router.cc
[modify] https://crrev.com/c5ddf366ba98d052497b5dc56187704f914ec8f6/mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c0773df4a2c301b1d109c9a1ce50b2181fceb50

commit 6c0773df4a2c301b1d109c9a1ce50b2181fceb50
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 16:33:29 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254873004
Cr-Commit-Position: refs/heads/master@{#413163}

[modify] https://crrev.com/6c0773df4a2c301b1d109c9a1ce50b2181fceb50/tools/battor_agent/battor_connection_impl.cc
[modify] https://crrev.com/6c0773df4a2c301b1d109c9a1ce50b2181fceb50/tools/battor_agent/battor_connection_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a40b2de1242abca45b546dc13114d1a5aaa41134

commit a40b2de1242abca45b546dc13114d1a5aaa41134
Author: ricea <ricea@chromium.org>
Date: Fri Aug 19 17:03:22 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2260443002
Cr-Commit-Position: refs/heads/master@{#413171}

[modify] https://crrev.com/a40b2de1242abca45b546dc13114d1a5aaa41134/mash/browser/browser.cc
[modify] https://crrev.com/a40b2de1242abca45b546dc13114d1a5aaa41134/mash/task_viewer/task_viewer.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9462d4d25114bbdfa25f6e1ca28eca3303e8286

commit c9462d4d25114bbdfa25f6e1ca28eca3303e8286
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 02:40:28 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257763002
Cr-Commit-Position: refs/heads/master@{#413387}

[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/app_list/app_list_presenter_delegate_factory.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/common/shelf/shelf_button.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/display/display_change_observer_chromeos_unittest.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/display/display_manager.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/display/extended_mouse_warp_controller.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/host/ash_window_tree_host_unified.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/metrics/task_switch_metrics_recorder.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/mus/root_window_controller.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/shell.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/sysui/sysui_application.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/wm/drag_window_controller.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/wm/overview/scoped_overview_animation_settings_factory_aura.cc
[modify] https://crrev.com/c9462d4d25114bbdfa25f6e1ca28eca3303e8286/ash/wm/window_mirror_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799a1fd2f3dcb409f751b950f767db427664cbd1

commit 799a1fd2f3dcb409f751b950f767db427664cbd1
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 02:45:53 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256813005
Cr-Commit-Position: refs/heads/master@{#413388}

[modify] https://crrev.com/799a1fd2f3dcb409f751b950f767db427664cbd1/components/browser_sync/browser/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/799a1fd2f3dcb409f751b950f767db427664cbd1/components/browser_sync/browser/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/799a1fd2f3dcb409f751b950f767db427664cbd1/components/browser_sync/browser/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/799a1fd2f3dcb409f751b950f767db427664cbd1/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/799a1fd2f3dcb409f751b950f767db427664cbd1/components/browser_sync/browser/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/799a1fd2f3dcb409f751b950f767db427664cbd1/components/browser_sync/browser/profile_sync_test_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e

commit 68860bd0684a7cfdc2bf07ff768bd540a60a6e9e
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 02:48:56 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253233004
Cr-Commit-Position: refs/heads/master@{#413390}

[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/base/chromium_url_request.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/chromoting_client.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/dual_buffer_frame_consumer.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/gl_desktop.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/gl_renderer_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/jni/chromoting_jni_instance.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/jni/chromoting_jni_runtime.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/jni/jni_gl_display_handler.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/plugin/chromoting_instance.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/plugin/pepper_port_allocator_factory.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/plugin/pepper_url_request.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/client/software_video_renderer_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/basic_desktop_environment.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/client_session.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/continue_window_android.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/continue_window_chromeos.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/continue_window_linux.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/continue_window_mac.mm
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/continue_window_win.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/desktop_session_agent.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/desktop_session_proxy.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/disconnect_window_android.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/disconnect_window_chromeos.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/disconnect_window_linux.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/disconnect_window_mac.mm
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/disconnect_window_win.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/fake_desktop_environment.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/fake_host_extension.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/ipc_desktop_environment.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/mouse_cursor_monitor_proxy_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/pairing_registry_delegate_linux.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/pairing_registry_delegate_win.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/pam_authorization_factory_posix.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/setup/host_starter.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/setup/me2me_native_messaging_host_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/token_validator_factory_impl.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/token_validator_factory_impl_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/host/win/session_desktop_environment.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/authenticator.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/chromium_port_allocator_factory.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/connection_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/fake_authenticator.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/fake_video_renderer.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/http_ice_config_request_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/ice_transport_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/negotiating_authenticator_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/pairing_registry_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/ssl_hmac_channel_authenticator.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/stream_message_pipe_adapter.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/transport_context.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/video_frame_pump.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/video_frame_pump_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/protocol/webrtc_transport.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/signaling/server_log_entry.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/signaling/xmpp_signal_strategy_unittest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/test/fake_port_allocator.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/test/protocol_perftest.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/test/test_chromoting_client.cc
[modify] https://crrev.com/68860bd0684a7cfdc2bf07ff768bd540a60a6e9e/remoting/test/test_chromoting_client_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf

commit eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 02:47:27 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259753003
Cr-Commit-Position: refs/heads/master@{#413389}

[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/app_list/search/mixer_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/arc/notification/arc_notification_item.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/aura/window.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/base/ime/input_method_factory.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/base/ime/linux/fake_input_method_context_factory.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/base/nine_image_painter_factory.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/compositor/layer_owner.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/display/chromeos/update_display_configuration_task_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/event.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/event_processor_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/gestures/blink/web_gesture_curve_impl.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/ozone/device/device_manager.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/ozone/device/udev/device_manager_udev.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/ozone/evdev/event_converter_test_util.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/ozone/evdev/event_factory_evdev.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/ozone/evdev/input_device_factory_evdev.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/platform/platform_event_source.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/platform/x11/x11_event_source_glib.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/platform/x11/x11_event_source_libevent.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/test/event_generator.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/test/test_event_target.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/events/x/events_x_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/gfx/image/image.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/gl/gl_context.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/message_center/message_center_impl_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/message_center/message_center_tray.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/message_center/views/message_popup_collection_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/common/display_snapshot_proxy.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/common/native_display_delegate_ozone.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/demo/ozone_demo.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/caca/ozone_platform_caca.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/cast/client_native_pixmap_factory_cast.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/cast/overlay_manager_cast.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/cast/ozone_platform_cast.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/gpu/screen_manager.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/host/drm_display_host.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/host/drm_display_host_manager.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/host/drm_overlay_manager.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/headless/ozone_platform_headless.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/wayland/fake_server.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/wayland/wayland_connection.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/wayland/wayland_surface_factory.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/ozone/platform/x11/ozone_platform_x11.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/touch_selection/touch_handle_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/touch_selection/touch_selection_controller_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/border.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/controls/menu/menu_scroll_view_container.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/mus/native_widget_mus_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/mus/views_mus_test_suite.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/mus/window_tree_host_mus.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/painter.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/style/mac/dialog_button_border_mac_unittest.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/style/platform_style.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/style/platform_style_mac.mm
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/test/combobox_test_api.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/views/view.cc
[modify] https://crrev.com/eb5cdbe2b1cb6dedbb51c544b0cc94b20984eadf/ui/wm/core/focus_controller_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f

commit 5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 02:51:03 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252373002
Cr-Commit-Position: refs/heads/master@{#413392}

[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/extensions_api_client.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/hid/hid_apitest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/hid/hid_device_manager.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/idle/idle_api_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/networking_config/networking_config_service.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/networking_config/networking_config_service_factory.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/serial/serial_connection.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/sockets_udp/sockets_udp_api_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/storage/storage_api_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/api/usb/usb_apitest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/event_listener_map_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/event_router_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/extension_function.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/extension_throttle_manager.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/guest_view/extension_options/extension_options_guest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/guest_view/extension_view/extension_view_guest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/guest_view/web_view/web_view_find_helper.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/lazy_background_task_queue_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/load_monitoring_extension_host_queue_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/mojo/stash_backend.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/user_script_loader.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/value_store/legacy_value_store_factory.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/browser/value_store/value_store_change_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/common/permissions/settings_override_permission.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/common/value_counter.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/renderer/event_bindings.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/renderer/i18n_custom_bindings.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/renderer/script_injection_manager.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/shell/browser/shell_extension_system.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/shell/browser/shell_extensions_browser_client.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/shell/browser/shell_native_app_window_aura_unittest.cc
[modify] https://crrev.com/5e27337b381e1ee8c487f4b4cab71a9a0e6d1b0f/extensions/shell/browser/shell_url_request_context_getter.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04dff7f22bbbbfe8b696e7f0dba2c11fdb6f38ed

commit 04dff7f22bbbbfe8b696e7f0dba2c11fdb6f38ed
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 03:04:42 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254973004
Cr-Commit-Position: refs/heads/master@{#413394}

[modify] https://crrev.com/04dff7f22bbbbfe8b696e7f0dba2c11fdb6f38ed/ppapi/proxy/audio_encoder_resource.cc
[modify] https://crrev.com/04dff7f22bbbbfe8b696e7f0dba2c11fdb6f38ed/ppapi/proxy/flash_font_file_resource.cc
[modify] https://crrev.com/04dff7f22bbbbfe8b696e7f0dba2c11fdb6f38ed/ppapi/proxy/video_encoder_resource.cc
[modify] https://crrev.com/04dff7f22bbbbfe8b696e7f0dba2c11fdb6f38ed/ppapi/proxy/vpn_provider_resource.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85bddde312d17e38e859de39f861711d504732b6

commit 85bddde312d17e38e859de39f861711d504732b6
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 03:16:30 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259823003
Cr-Commit-Position: refs/heads/master@{#413396}

[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/file/file_service.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/background/tests/background_shell_unittest.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/public/cpp/interface_registry.h
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/public/cpp/lib/interface_registry.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/public/cpp/lib/service_context_ref.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/public/cpp/lib/service_test.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/runner/child/test_native_main.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/runner/host/in_process_native_runner.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/runner/host/out_of_process_native_runner.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/shell/tests/connect/connect_unittest.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/public/cpp/tests/window_server_shelltest_base.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/public/cpp/window_tree_client.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/surfaces/display_compositor.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/ws/display_manager.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/ws/modal_window_controller.cc
[modify] https://crrev.com/85bddde312d17e38e859de39f861711d504732b6/services/ui/ws/window_tree.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6affa5574c8085dfc255f13ff49cb19edbc96ad9

commit 6affa5574c8085dfc255f13ff49cb19edbc96ad9
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 03:28:04 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254183002
Cr-Commit-Position: refs/heads/master@{#413397}

[modify] https://crrev.com/6affa5574c8085dfc255f13ff49cb19edbc96ad9/storage/browser/blob/blob_async_builder_host.cc
[modify] https://crrev.com/6affa5574c8085dfc255f13ff49cb19edbc96ad9/storage/browser/fileapi/isolated_file_system_backend.cc
[modify] https://crrev.com/6affa5574c8085dfc255f13ff49cb19edbc96ad9/storage/browser/fileapi/local_file_util.cc
[modify] https://crrev.com/6affa5574c8085dfc255f13ff49cb19edbc96ad9/storage/browser/fileapi/native_file_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fccaf874e0338cd3a27c0ef71c635399d2197de2

commit fccaf874e0338cd3a27c0ef71c635399d2197de2
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 03:38:45 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259523003
Cr-Commit-Position: refs/heads/master@{#413399}

[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/permission_reporter.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
[modify] https://crrev.com/fccaf874e0338cd3a27c0ef71c635399d2197de2/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c

commit df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 03:39:50 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2257713003
Cr-Commit-Position: refs/heads/master@{#413400}

[modify] https://crrev.com/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c/gpu/command_buffer/tests/gl_compressed_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c/gpu/ipc/client/android/in_process_surface_texture_manager.cc
[modify] https://crrev.com/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c/gpu/ipc/service/gpu_command_buffer_stub.cc
[modify] https://crrev.com/df0a9da0c9e6b7ceed46e057ea5ad87a97932b9c/gpu/tools/compositor_model_bench/render_models.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e66e6f17755de8d0082593183f7d67ce13cb57

commit 08e66e6f17755de8d0082593183f7d67ce13cb57
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 04:24:55 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256733004
Cr-Commit-Position: refs/heads/master@{#413404}

[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/api/model_type_service_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core/model_type_store_impl.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core/processor_entity_tracker_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core/shared_model_type_processor.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core/shared_model_type_processor_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core_impl/attachments/attachment_service_impl_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core_impl/model_type_connector_proxy_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core_impl/sync_manager_impl.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/core_impl/test/fake_sync_manager.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/device_info/device_info_service.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/device_info/device_info_service_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/driver/fake_sync_client.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/driver/fake_sync_service.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/driver/generic_change_processor_factory.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/driver/non_ui_model_type_controller_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/driver/sync_policy_handler_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/driver/ui_model_type_controller_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/engine_impl/cycle/nudge_tracker.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/engine_impl/directory_update_handler_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/engine_impl/model_type_registry_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/engine_impl/model_type_worker.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/tools/sync_client.cc
[modify] https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57/components/sync/tools/sync_listen_notifications.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb

commit da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb
Author: ricea <ricea@chromium.org>
Date: Mon Aug 22 05:28:17 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2258833002
Cr-Commit-Position: refs/heads/master@{#413409}

[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/animation/animation_host.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/animation/animation_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/animation/transform_operations_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/blink/web_content_layer_impl.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/debug/micro_benchmark_controller.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/debug/micro_benchmark_controller_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/layers/layer_impl.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/layers/texture_layer.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/output/bsp_tree.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/output/gl_renderer.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/output/gl_renderer_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/output/overlay_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/output/software_renderer.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/playback/clip_path_display_item.h
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/playback/compositing_display_item.h
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/playback/filter_display_item.h
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/playback/float_clip_display_item.h
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/playback/transform_display_item.h
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/test/fake_image_serialization_processor.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/test/fake_painted_scrollbar_layer.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/test/pixel_test.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/test/remote_proto_channel_bridge.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/test/test_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/test/test_shared_bitmap_manager.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/tiles/eviction_tile_priority_queue.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/tiles/picture_layer_tiling_set.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/tiles/picture_layer_tiling_set_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/tiles/raster_tile_priority_queue_all.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/tiles/software_image_decode_controller.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/trees/remote_channel_impl.cc
[modify] https://crrev.com/da4bffb6ef5cb7c8894c64d4666ac6a5da4d80fb/cc/trees/threaded_channel.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8133ff702313ecbb52f3903838418cf5de676ab5

commit 8133ff702313ecbb52f3903838418cf5de676ab5
Author: ricea <ricea@chromium.org>
Date: Wed Aug 24 02:42:18 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2255093003
Cr-Commit-Position: refs/heads/master@{#413952}

[modify] https://crrev.com/8133ff702313ecbb52f3903838418cf5de676ab5/chromeos/binder/service_manager_proxy_unittest.cc
[modify] https://crrev.com/8133ff702313ecbb52f3903838418cf5de676ab5/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/8133ff702313ecbb52f3903838418cf5de676ab5/chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc
[modify] https://crrev.com/8133ff702313ecbb52f3903838418cf5de676ab5/chromeos/network/network_state_unittest.cc
[modify] https://crrev.com/8133ff702313ecbb52f3903838418cf5de676ab5/chromeos/network/onc/onc_translator_onc_to_shill.cc
[modify] https://crrev.com/8133ff702313ecbb52f3903838418cf5de676ab5/chromeos/network/shill_property_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebb92b4123f784b2fc950a2e762b0ef2c8342764

commit ebb92b4123f784b2fc950a2e762b0ef2c8342764
Author: ricea <ricea@chromium.org>
Date: Wed Aug 24 02:43:17 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2258823002
Cr-Commit-Position: refs/heads/master@{#413953}

[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/aw_browser_policy_connector.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/browser_view_renderer.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/browser_view_renderer_unittest.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/net/android_stream_reader_url_request_job.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/net/aw_request_interceptor.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/native/android_protocol_handler.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/native/aw_contents.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/native/aw_contents_client_bridge_unittest.cc
[modify] https://crrev.com/ebb92b4123f784b2fc950a2e762b0ef2c8342764/android_webview/native/aw_web_resource_response_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3

commit 46ad5f4fc0f8d35f71c890431e8e4518d228f2e3
Author: ricea <ricea@chromium.org>
Date: Wed Aug 24 02:44:55 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257103002
Cr-Commit-Position: refs/heads/master@{#413954}

[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/arc/arc_policy_bridge.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/certificate_provider/thread_safe_certificate_map.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/display/display_preferences_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/file_system_provider/operations/operation.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/file_system_provider/provided_file_system.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/file_system_provider/service.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/net/proxy_config_handler.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/platform_keys/key_permissions.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/platform_keys/platform_keys_service.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/platform_keys/platform_keys_service_factory.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_local_account_external_data_manager.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_local_account_policy_provider.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_local_account_policy_store.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/extension_cache_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/remote_commands/device_commands_factory_chromeos.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/upload_job_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/user_cloud_external_data_manager.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/power/extension_event_observer.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.cc
[modify] https://crrev.com/46ad5f4fc0f8d35f71c890431e8e4518d228f2e3/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f0ae4df06a2a8c764c3659679525a201d7a20e7

commit 1f0ae4df06a2a8c764c3659679525a201d7a20e7
Author: ricea <ricea@chromium.org>
Date: Wed Aug 24 02:52:19 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252113004
Cr-Commit-Position: refs/heads/master@{#413956}

[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/1f0ae4df06a2a8c764c3659679525a201d7a20e7/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6983d553d1cd861d8f7c42a07ee209da696e1d5

commit b6983d553d1cd861d8f7c42a07ee209da696e1d5
Author: ricea <ricea@chromium.org>
Date: Wed Aug 24 03:19:43 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2250433006
Cr-Commit-Position: refs/heads/master@{#413966}

[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/client/core/compositor/blob_image_serialization_processor.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/client/feature/compositor/blimp_compositor_manager_unittest.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/client/feature/compositor/blimp_input_manager.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/engine/renderer/engine_image_serialization_processor.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/blimp_message_checkpointer_unittest.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/blimp_message_multiplexer.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/blimp_message_output_buffer.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/blimp_message_thread_pipe.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/blimp_message_thread_pipe_unittest.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/blob_channel/blob_channel_integration_test.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/engine_connection_manager_unittest.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/tcp_engine_transport.cc
[modify] https://crrev.com/b6983d553d1cd861d8f7c42a07ee209da696e1d5/blimp/net/thread_pipe_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c937aa64f5309be50d077dd0d29014cf2d0e9b3

commit 0c937aa64f5309be50d077dd0d29014cf2d0e9b3
Author: ricea <ricea@chromium.org>
Date: Thu Aug 25 05:24:04 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254833003
Cr-Commit-Position: refs/heads/master@{#414312}

[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/bluetooth_advertisement_unittest.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/dbus/bluetooth_le_advertisement_service_provider.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/test/bluetooth_gatt_server_test.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/bluetooth/test/bluetooth_test.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/geolocation/location_arbitrator_impl.cc
[modify] https://crrev.com/0c937aa64f5309be50d077dd0d29014cf2d0e9b3/device/test/usb_test_gadget_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb40326f4ba96cb2691e33855d07a75cbb9c57b7

commit bb40326f4ba96cb2691e33855d07a75cbb9c57b7
Author: ricea <ricea@chromium.org>
Date: Thu Aug 25 05:26:51 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

BUG=637812

Review-Url: https://codereview.chromium.org/2254173002
Cr-Commit-Position: refs/heads/master@{#414315}

[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/child_discardable_shared_memory_manager.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/child_shared_bitmap_manager.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/push_messaging/push_provider.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/resource_dispatcher.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/resource_dispatcher_unittest.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/service_worker/web_service_worker_registration_impl.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/shared_memory_data_consumer_handle.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/shared_memory_data_consumer_handle_unittest.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/shared_memory_received_data_factory.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/url_response_body_consumer.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/web_data_consumer_handle_impl_unittest.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/bb40326f4ba96cb2691e33855d07a75cbb9c57b7/content/child/web_url_loader_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edb3f078970c02c48cb0eccc07170e9463f63eda

commit edb3f078970c02c48cb0eccc07170e9463f63eda
Author: ricea <ricea@chromium.org>
Date: Thu Aug 25 06:44:15 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2255123002
Cr-Commit-Position: refs/heads/master@{#414343}

[modify] https://crrev.com/edb3f078970c02c48cb0eccc07170e9463f63eda/apps/saved_files_service.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cdd7ebe8bd324d3174e8ec3253190908e717a36

commit 3cdd7ebe8bd324d3174e8ec3253190908e717a36
Author: ricea <ricea@chromium.org>
Date: Thu Aug 25 09:43:39 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253943004
Cr-Commit-Position: refs/heads/master@{#414375}

[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/audio/fake_audio_input_stream.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/audio/fake_audio_log_factory.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/base/android/media_codec_decoder_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/base/android/media_codec_player_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/base/decoder_buffer_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/base/fake_demuxer_stream.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/base/media_tracks.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/base/stream_parser_buffer.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/capture/video/fake_video_capture_device_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/cast/test/sender.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/cast/test/simulator.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/cast/test/utility/in_process_receiver.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/cdm/simple_cdm_allocator.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/formats/mpeg/adts_stream_parser_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/formats/mpeg/mpeg1_audio_stream_parser_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/midi/midi_manager_alsa.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/midi/midi_manager_android.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/midi/usb_midi_device_factory_android.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/common/media_type_converters.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/common/media_type_converters_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/common/mojo_decoder_buffer_converter.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/common/mojo_decoder_buffer_converter_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/services/android_mojo_media_client.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/services/main.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/services/mojo_cdm_allocator.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/services/mojo_media_application_factory.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/mojo/services/test_mojo_media_client.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/muxers/webm_muxer.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/muxers/webm_muxer_unittest.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/renderers/mock_gpu_video_accelerator_factories.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/3cdd7ebe8bd324d3174e8ec3253190908e717a36/media/test/pipeline_integration_test_base.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/175211e0e340c1e0a01286b96aca51e700294b5b

commit 175211e0e340c1e0a01286b96aca51e700294b5b
Author: ricea <ricea@chromium.org>
Date: Mon Aug 29 04:06:48 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2247183007
Cr-Commit-Position: refs/heads/master@{#414972}

[modify] https://crrev.com/175211e0e340c1e0a01286b96aca51e700294b5b/sandbox/mac/bootstrap_sandbox.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc3c05e020ebed67cf32ff9648e7ed2b0e9f82c3

commit bc3c05e020ebed67cf32ff9648e7ed2b0e9f82c3
Author: ricea <ricea@chromium.org>
Date: Mon Aug 29 05:48:30 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256183002
Cr-Commit-Position: refs/heads/master@{#414976}

[modify] https://crrev.com/bc3c05e020ebed67cf32ff9648e7ed2b0e9f82c3/google_apis/drive/base_requests.cc
[modify] https://crrev.com/bc3c05e020ebed67cf32ff9648e7ed2b0e9f82c3/google_apis/gcm/engine/connection_factory_impl_unittest.cc
[modify] https://crrev.com/bc3c05e020ebed67cf32ff9648e7ed2b0e9f82c3/google_apis/gcm/tools/mcs_probe.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7

commit 91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7
Author: ricea <ricea@chromium.org>
Date: Tue Aug 30 08:47:14 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257113002
Cr-Commit-Position: refs/heads/master@{#415247}

[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/autofill_private/autofill_util.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/chrome_extensions_api_client.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/dial/dial_registry.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/management/management_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/mdns/mdns_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/messaging/extension_message_port.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/networking_private/networking_private_ui_delegate_factory_impl.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/omnibox/omnibox_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/permissions/permissions_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/sessions/sessions_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/socket/combined_socket_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/socket/socket_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/storage/sync_storage_backend.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/tabs/windows_event_router.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_action_runner.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_action_test_util.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_action_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_disabled_ui.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_garbage_collector_factory.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_install_prompt_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_reenabler.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_resource_protocols.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/extension_web_ui_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/menu_manager_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/navigation_observer.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/permissions_updater_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/update_install_gate_unittest.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/webstore_install_with_prompt.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/webstore_standalone_installer.cc
[modify] https://crrev.com/91d6fc12ddbd78adc66ca00d54a9c318b4e3b6b7/chrome/browser/extensions/webstore_startup_installer.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fcde24af7919904a7f2f9b9d452da8c575095db

commit 8fcde24af7919904a7f2f9b9d452da8c575095db
Author: ricea <ricea@chromium.org>
Date: Wed Aug 31 06:21:34 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252293003
Cr-Commit-Position: refs/heads/master@{#415572}

[modify] https://crrev.com/8fcde24af7919904a7f2f9b9d452da8c575095db/tools/gn/command_desc.cc
[modify] https://crrev.com/8fcde24af7919904a7f2f9b9d452da8c575095db/tools/gn/desc_builder.cc
[modify] https://crrev.com/8fcde24af7919904a7f2f9b9d452da8c575095db/tools/gn/functions_unittest.cc
[modify] https://crrev.com/8fcde24af7919904a7f2f9b9d452da8c575095db/tools/gn/json_project_writer.cc
[modify] https://crrev.com/8fcde24af7919904a7f2f9b9d452da8c575095db/tools/gn/parser.cc
[modify] https://crrev.com/8fcde24af7919904a7f2f9b9d452da8c575095db/tools/gn/xcode_object.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29649b991045c05394dc42641068934b9d494e80

commit 29649b991045c05394dc42641068934b9d494e80
Author: ricea <ricea@chromium.org>
Date: Wed Aug 31 09:30:21 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253053003
Cr-Commit-Position: refs/heads/master@{#415592}

[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/bluetooth/web_bluetooth_impl.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/gpu/frame_swap_message_queue.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/gpu/frame_swap_message_queue_unittest.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/history_controller.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/input/input_event_filter.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/media/android/media_player_renderer_client_factory.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/media/gpu/rtc_video_encoder_unittest.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/media/renderer_gpu_video_accelerator_factories.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/media/rtc_certificate_generator.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/pepper/content_renderer_pepper_host_factory.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/push_messaging/push_messaging_dispatcher.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/29649b991045c05394dc42641068934b9d494e80/content/renderer/render_view_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85ec579564402fad9b6f0d593decf686846fb61f

commit 85ec579564402fad9b6f0d593decf686846fb61f
Author: ricea <ricea@chromium.org>
Date: Wed Aug 31 09:34:10 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257793002
Cr-Commit-Position: refs/heads/master@{#415593}

[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/arc/arc_service_manager.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/autofill/content/browser/content_autofill_driver_factory.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/bookmarks/browser/bookmark_index_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/browsing_data/core/counters/browsing_data_counter.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/browsing_data/core/counters/history_counter.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/cast_certificate/cast_cert_validator.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/cast_certificate/cast_crl.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/certificate_reporting/error_reporter.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/component_updater/component_updater_service_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/content_settings/core/browser/content_settings_utils.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/content_settings/core/browser/website_settings_registry_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/cronet/android/cronet_data_reduction_proxy.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/cronet/android/url_request_context_adapter.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/cronet/ios/test/cronet_bidirectional_stream_test.mm
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/devtools_http_handler/devtools_http_handler_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/display_compositor/buffer_queue.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/display_compositor/compositor_overlay_candidate_validator_android.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/dom_distiller/core/distillable_page_detector_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/dom_distiller/core/dom_distiller_store_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/domain_reliability/monitor.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/drive/chromeos/file_system/download_operation.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/drive/chromeos/search_metadata.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/drive/resource_metadata_storage.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/exo/buffer.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/exo/display.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/exo/shared_memory.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/exo/shared_memory_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/exo/sub_surface_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/exo/wayland/server.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/feedback/anonymizer_tool.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/feedback/feedback_data_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/feedback/feedback_uploader_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/guest_view/browser/guest_view_message_filter.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/history/core/browser/visitsegment_database.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/history/core/test/history_client_fake_bookmarks.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/history/core/test/history_service_test_util.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/invalidation/impl/gcm_invalidation_bridge.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/invalidation/impl/sync_system_resources.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/invalidation/impl/ticl_invalidation_service_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/metrics/file_metrics_provider.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/metrics/metrics_log_manager_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/metrics/metrics_service.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/navigation_interception/intercept_navigation_delegate.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/navigation_interception/intercept_navigation_throttle_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/ntp_snippets/ntp_snippets_database.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/ntp_snippets/ntp_snippets_fetcher_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/prefs/in_memory_pref_store_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/prefs/json_pref_store_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/prefs/overlay_user_pref_store_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/prefs/pref_value_map_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/prefs/testing_pref_store.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/rappor/rappor_service.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/safe_browsing_db/database_manager_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/search_engines/default_search_policy_handler.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/search_engines/default_search_policy_handler_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/search_engines/search_engine_data_type_controller_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/search_engines/template_url_service_util_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/search_provider_logos/logo_cache.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/signin/core/browser/test_signin_client.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/signin/core/browser/webdata/token_web_data.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/ssl_errors/error_classification_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/subresource_filter/content/browser/subresource_filter_navigation_throttle_unittests.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/subresource_filter/core/browser/ruleset_service_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/suggestions/image_encoder_ios.mm
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/sync_sessions/favicon_cache_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/sync_sessions/revisit/bookmarks_page_revisit_observer_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/sync_sessions/revisit/page_revisit_broadcaster.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/sync_sessions/revisit/typed_url_page_revisit_observer.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/sync_sessions/sync_sessions_metrics_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/syncable_prefs/pref_service_syncable_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/test_runner/tracked_dictionary.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/test_runner/web_test_interfaces.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/translate/core/browser/translate_ui_delegate_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/undo/undo_manager_test.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/url_matcher/url_matcher_factory.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/user_prefs/tracked/segregated_pref_store_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/variations/service/variations_service.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/variations/service/variations_service_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/web_resource/web_resource_service.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/webcrypto/algorithms/sha.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/wifi_sync/wifi_credential.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/wifi_sync/wifi_credential_syncable_service_factory.cc
[modify] https://crrev.com/85ec579564402fad9b6f0d593decf686846fb61f/components/wifi_sync/wifi_credential_syncable_service_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f9699d9be6dd32931c9e694f61b3022346f4e5

commit 34f9699d9be6dd32931c9e694f61b3022346f4e5
Author: ricea <ricea@chromium.org>
Date: Wed Aug 31 10:14:30 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2251263003
Cr-Commit-Position: refs/heads/master@{#415600}

[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/android/infobars/confirm_infobar.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/android/infobars/save_password_infobar.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/android/infobars/translate_infobar.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/arc/arc_app_model_builder.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/extension_app_model_builder.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/launcher_page_event_dispatcher.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/search/search_controller_factory.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/search/search_resource_manager.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/ash/app_list/app_list_service_ash.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/browser_window_state.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/extensions/extension_enable_flow.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/omnibox/omnibox_controller_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/startup/default_browser_infobar_delegate_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/tabs/pinned_tab_service_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/certificate_selector_browsertest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/dropdown_bar_view.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/frame/test_with_browser_view.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/sync/one_click_signin_dialog_view_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/options/home_page_overlay_handler.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/options/preferences_browsertest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/options/startup_pages_handler.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/policy_ui_browsertest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/settings/certificates_handler.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/34f9699d9be6dd32931c9e694f61b3022346f4e5/chrome/browser/ui/webui/sync_internals_message_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55d8215215c10a413f227b8bcf0e3a826e7b5b2a

commit 55d8215215c10a413f227b8bcf0e3a826e7b5b2a
Author: ricea <ricea@chromium.org>
Date: Thu Sep 01 11:32:30 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252353002
Cr-Commit-Position: refs/heads/master@{#415929}

[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/browser/android/policy_converter.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/browser/autofill_policy_handler_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/browser/configuration_policy_handler_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/browser/proxy_policy_handler_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/async_policy_provider_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/component_cloud_policy_service.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/external_policy_data_fetcher.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/mock_cloud_external_data_manager.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/policy_header_io_helper_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/policy_header_service.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/generate_policy_source_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/policy_bundle_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/policy_loader_ios_unittest.mm
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/policy_loader_mac_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/policy_loader_win_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/policy_map_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/policy_service_impl_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/policy_statistics_collector_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/preg_parser_win_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/proxy_policy_provider_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/registry_dict_win_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/remote_commands/test_remote_command_job.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/schema_map_unittest.cc
[modify] https://crrev.com/55d8215215c10a413f227b8bcf0e3a826e7b5b2a/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641bb021db42cdfd711a97bdc16077c64bb87aea

commit 641bb021db42cdfd711a97bdc16077c64bb87aea
Author: ricea <ricea@chromium.org>
Date: Fri Sep 02 02:51:09 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2256173002
Cr-Commit-Position: refs/heads/master@{#416174}

[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/blob_storage/blob_url_request_job_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/bluetooth/frame_connected_bluetooth_devices_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/browser_main_loop.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/download/download_request_core.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/fileapi/dragged_file_util_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/fileapi/transient_file_util_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/loader/async_revalidation_driver_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/loader/upload_data_stream_builder.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/media/android/url_provision_fetcher.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/media/capture/screen_capture_device_android.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/media/capture/web_contents_video_capture_device_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/plugin_private_storage_helper.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/input/synthetic_pointer.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/media/media_stream_dispatcher_host.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/media/video_capture_buffer_pool.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/media/video_capture_controller.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/render_view_host_factory.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/resource_context_impl.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/streams/stream_url_request_job_unittest.cc
[modify] https://crrev.com/641bb021db42cdfd711a97bdc16077c64bb87aea/content/browser/webui/url_data_manager_backend.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4b8464d50e235b25ceb2872d44d09a258837f2

commit 9b4b8464d50e235b25ceb2872d44d09a258837f2
Author: ricea <ricea@chromium.org>
Date: Fri Sep 02 06:44:35 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2250023005
Cr-Commit-Position: refs/heads/master@{#416203}

[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/cryptauth/cryptauth_client_impl.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/cryptauth/cryptauth_enrollment_manager.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/cryptauth/cryptauth_enrollment_manager_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/cryptauth/sync_scheduler_impl.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/cryptauth_enroller_factory_impl.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/device_to_device_authenticator.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/device_to_device_secure_context_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/fake_connection.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/messenger_impl.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/remote_device_life_cycle_impl.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/throttled_bluetooth_connection_finder_unittest.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/unlock_manager.cc
[modify] https://crrev.com/9b4b8464d50e235b25ceb2872d44d09a258837f2/components/proximity_auth/webui/proximity_auth_webui_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4fe03704abb4c3628cddff5c7aa8f82b86b2b21

commit d4fe03704abb4c3628cddff5c7aa8f82b86b2b21
Author: ricea <ricea@chromium.org>
Date: Mon Sep 05 05:06:18 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2255143002
Cr-Commit-Position: refs/heads/master@{#416495}

[modify] https://crrev.com/d4fe03704abb4c3628cddff5c7aa8f82b86b2b21/ipc/attachment_broker_privileged.cc
[modify] https://crrev.com/d4fe03704abb4c3628cddff5c7aa8f82b86b2b21/ipc/ipc_channel_factory.cc
[modify] https://crrev.com/d4fe03704abb4c3628cddff5c7aa8f82b86b2b21/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/d4fe03704abb4c3628cddff5c7aa8f82b86b2b21/ipc/ipc_perftest_support.cc
[modify] https://crrev.com/d4fe03704abb4c3628cddff5c7aa8f82b86b2b21/ipc/ipc_test_base.cc

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1a4a6d92f4cbd63066ed9bde05adb2ce3d4dae0c

commit 1a4a6d92f4cbd63066ed9bde05adb2ce3d4dae0c
Author: sdefresne <sdefresne@google.com>
Date: Tue Sep 06 08:44:40 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1a4a6d92f4cbd63066ed9bde05adb2ce3d4dae0c

commit 1a4a6d92f4cbd63066ed9bde05adb2ce3d4dae0c
Author: sdefresne <sdefresne@google.com>
Date: Tue Sep 06 08:44:40 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2deef68d60652155b338b88b1acc1f4be1c51ee3

commit 2deef68d60652155b338b88b1acc1f4be1c51ee3
Author: ricea <ricea@chromium.org>
Date: Fri Sep 09 08:04:07 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259823002
Cr-Commit-Position: refs/heads/master@{#417532}

[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/base/chunked_upload_data_stream.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/base/elements_upload_data_stream_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/cert/internal/path_builder.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/cert/internal/signature_algorithm.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/cert_net/cert_net_fetcher_impl_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/cookies/cookie_monster.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/dns/dns_session.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/dns/dns_transaction_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/dns/host_resolver_impl_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/ftp/ftp_network_layer.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/bidirectional_stream.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/http_auth_handler_factory.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/http_auth_handler_negotiate_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/http_cache.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/http_cache_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/http_stream_parser_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/mock_http_cache.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/http/transport_security_state.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/log/net_log_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/dhcp_proxy_script_fetcher_factory.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/mock_proxy_resolver.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/mojo_proxy_resolver_factory_impl.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/mojo_proxy_resolver_impl.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_resolver_factory_mojo_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_resolver_v8_tracing_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_script_fetcher_impl_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_service.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_service_mojo.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_service_mojo_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/proxy/proxy_service_v8.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/quic/chromium/crypto_test_utils_chromium.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/quic/chromium/quic_end_to_end_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/quic/test_tools/quic_test_packet_maker.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/server/http_server.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/server/web_socket_encoder.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/spdy/spdy_test_util_common.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/ssl/default_channel_id_store_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/ssl/ssl_platform_key_chromecast.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/ssl/ssl_platform_key_mac.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/ssl/ssl_platform_key_nss.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/ssl/test_ssl_private_key.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/test/embedded_test_server/request_handler_util.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/test/url_request/url_request_hanging_read_job.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/test/url_request/url_request_mock_data_job.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/tools/cert_verify_tool/verify_using_path_builder.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/tools/get_server_time/get_server_time.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_fetcher_impl_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_context_builder_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_data_job_fuzzer.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_simple_job_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_test_job.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/url_request/view_cache_helper_unittest.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/websockets/websocket_channel_test.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/websockets/websocket_deflate_predictor_impl_test.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/websockets/websocket_stream.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/websockets/websocket_stream_cookie_test.cc
[modify] https://crrev.com/2deef68d60652155b338b88b1acc1f4be1c51ee3/net/websockets/websocket_stream_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86fa1dd92331ce969c55ade017aab9950e0c5156

commit 86fa1dd92331ce969c55ade017aab9950e0c5156
Author: ricea <ricea@chromium.org>
Date: Tue Sep 13 05:59:45 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Additional changes: Four C-style casts have been changed to static_cast. One instance of using "" to construct an empty string has been changed to std::string().

BUG=637812

Review-Url: https://codereview.chromium.org/2334613003
Cr-Commit-Position: refs/heads/master@{#418180}

[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/bottombar/overlay_panel_content.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/compositor/tab_content_manager.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/data_usage/data_use_matcher.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/history_report/delta_file_backend_leveldb.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/android/usb/web_usb_chooser_service_android.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/apps/drive/drive_app_provider_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/autocomplete/autocomplete_classifier_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/autocomplete/shortcuts_backend_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/bookmarks/bookmark_model_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/bookmarks/managed_bookmark_service_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/browsing_data/browsing_data_remover.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/browsing_data/hosted_apps_counter.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/browsing_data/media_licenses_counter.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/browsing_data/media_licenses_counter_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/content_settings/local_shared_objects_container.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/devtools/device/adb/mock_adb_server.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/devtools/device/usb/android_usb_device.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/devtools/remote_debugging_server.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/download/download_dir_policy_handler.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/download/download_dir_policy_handler_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/engagement/site_engagement_score.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/favicon/favicon_service_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/file_select_helper.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/history/chrome_history_client.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/history/history_service_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/io_thread.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/media_galleries/linux/mtp_read_file_worker.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/metrics/subprocess_metrics_provider.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/metrics/subprocess_metrics_provider_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/disk_cache_dir_policy_handler.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/predictor_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/password_manager/password_store_win_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/password_manager/password_store_x_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/password_manager/update_password_infobar_delegate_android.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/permissions/chooser_context_base.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/permissions/delegation_tracker.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/cloud/policy_header_service_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/javascript_policy_handler_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/policy_network_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/policy_startup_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/prefs/command_line_pref_store.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/prefs/profile_pref_store_manager_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/prefs/proxy_policy_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/profiles/profile_statistics_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/search/contextual_search_policy_handler_android_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/search/hotword_installer_browsertest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/search/hotword_service_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/search_engines/chrome_template_url_service_client.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/search_engines/template_url_service_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/services/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sessions/persistent_tab_restore_service_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sessions/tab_loader.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/shell_integration_win.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/signin/chrome_proximity_auth_client.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/signin/easy_unlock_app_manager_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/signin/test_signin_client_builder.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/ssl/chrome_expect_ct_reporter.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/ssl/ssl_client_auth_requestor_mock.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/supervised_user/child_accounts/child_account_service.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync/profile_sync_test_util.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync/sync_global_error_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/sync_file_system/local/local_file_sync_context.cc
[modify] https://crrev.com/86fa1dd92331ce969c55ade017aab9950e0c5156/chrome/browser/usb/usb_chooser_context.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c39556939fdc7a522d9092f8a45e783550322c8

commit 0c39556939fdc7a522d9092f8a45e783550322c8
Author: ricea <ricea@chromium.org>
Date: Thu Sep 15 06:47:33 2016

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812

Review-Url: https://codereview.chromium.org/2341693002
Cr-Commit-Position: refs/heads/master@{#418795}

[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/installer/util/beacons.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/installer/util/browser_distribution.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/installer/util/lzma_file_allocator_unittest.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/installer/util/scoped_user_protocol_entry_unittest.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/renderer/extensions/extension_localization_peer_unittest.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/renderer/pepper/pepper_helper.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/service/service_process.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/service/service_process_prefs.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/test/base/chrome_render_view_test.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/test/chromedriver/net/url_request_context_getter.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/utility/importer/edge_database_reader_win.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/utility/safe_browsing/mac/hfs.cc
[modify] https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8/chrome/utility/safe_browsing/mac/udif.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5958170d51988d8dcf087e48e42beab44bb1a066

commit 5958170d51988d8dcf087e48e42beab44bb1a066
Author: ricea <ricea@chromium.org>
Date: Thu Sep 15 11:11:23 2016

Hide WrapUnique() -> MakeUnique() change from blame

There are a large number of mechanical changes of usages of WrapUnique()
to MakeUnique(). The blame information for these is not useful as it
does not reflect the people responsible for the code.

Add the relevant commits to .git-blame-ignore-revs so that they will be
skipped by git hyper-blame.

R=mgiuca@chromium.org
BUG=637812

Review-Url: https://codereview.chromium.org/2288683002
Cr-Commit-Position: refs/heads/master@{#418833}

[modify] https://crrev.com/5958170d51988d8dcf087e48e42beab44bb1a066/.git-blame-ignore-revs

Some other cleanups that could be done: https://docs.google.com/document/d/18yWr9i9N3EkFdLWOWJHLY_x25TsmhzCHpcJj5nyvkdQ/edit

I don't have time to get to these in the foreseeable future. I haven't filed feature requests for them because without a clear assignee such issues are just taking up space.