Could you provide screenshots of actual/expected behavior? I'm a little confused right now as to what I should see. Also, the testcase links to various stylesheets, are they necessary to reproduce this bug?

The new behavior matches Firefox which makes me suspect this was an intentional fix to improve compatibility.

David, could you comment?

Rob did some height work in this rough timeframe:
https://blink.lc/chromium/log/third_party/WebKit?qt=author&q=hogan

But it'd be great if we could get some more info (like comment 2 describes) and have TE team run a bisect.

Yes, the style sheet is needed to reproduce the issue.

Deleted: Chrome53Regression.zip 472 KB

Chrome53Regression.zip 472 KB Download

Deleted: Chrome52.png 137 KB

	Chrome52.png 137 KB View Download

Deleted: RegressionInChrome53Beta.png 113 KB

	RegressionInChrome53Beta.png 113 KB View Download

Sorry for not uploading the style sheet in our original version of the repro...I added the complete repor above in Chrome53Regression.zip.

TE team, can you bisect using the repro in comment 6? And note in the original description that the behavior changed between chrome 52 and 53.

But SAP folks, if this indeed gets us closer to the spec and the other browsers then we may not revert to the old behavior. Could you give us a timeline of when you can make the site work with the new behavior?

You are probably looking for a change made after 397778 (known good), but no later than 397799 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/16c5f9e182d412046291088ab782579f315bf100..28307938a3f600ff4ade76939ae7c03f617b7df5


My guess is  robhogan's change in https://chromium.googlesource.com/chromium/src/+/28307938a3f600ff4ade76939ae7c03f617b7df5
"Percent height content should respect the fixed height of its containing cell"

We cannot fix all our scenarios, as the behavior was changed in an inconsistent way. The new uploaded reppro (Repro2.html) shows an example which works in Firefox. It does not work in IE and in Chrome (also previous versions). To get it working in Chrome and IE, we had to add the 1px height for the TD tag with the red background color. Noe this does no longer work in Chrome 53 beta, so we have no solution for this scenario. 
The behavior was changed but it is not consistent with other browsers.

Deleted: Chrome53Regression.zip 476 KB

Chrome53Regression.zip 476 KB Download

Here's a reduction. I suspect our behaviour is correct because it's consistent in both cases where the content of the cell is a div and a table, whereas FF is not.

That said, I can't see why there should not be a green square in both cases. The cell gets a height that both the table and the div should take 100% of.

The spec on this has changed over time. See https://drafts.csswg.org/css2/visudet.html#the-height-property. 

The section on percentage now reads:
 "<percentage>
 Specifies a percentage height. The percentage is calculated with respect to the
 height of the generated box's containing block. If the height of the containing
 block is not specified explicitly (i.e., it depends on content height), and this
 element is not absolutely positioned, the used height is calculated as if 'auto'
 was specified."

The last clause used to read: "the value computes to 'auto'." 

mstensho: a penny for your thoughts.

Deleted: 637811-2.html 772 bytes

637811-2.html 772 bytes View Download

I think https://bugs.chromium.org/p/chromium/issues/detail?id=353580 is also related.

Francois: as the author of https://drafts.csswg.org/css-tables-3 could you also take a look here and provide some guidance?

You had some relevant comments at https://lists.w3.org/Archives/Public/www-style/2016Apr/0310.html

So what is your suggestion to get both scenarios working in Chrome?
In our scenarios, the actual height of the table is not known, as the content is generated during runtime. So we cannot simply add a fixed height to the table cell containing the DIV tag. 

The spec change ("computed height becomes auto" vs. "height calculated as if it were auto") shouldn't affect layout, right? It should only affect things like explicit inheritance and getComputedStyle(), right?

About the test: What Gecko does makes no sense to me. I'm guessing it was an attempt to be compatible with older versions of IE and Netscape. The height of the inner DIV / TABLE should be treated as auto.

Minimal test case that shows the difference between Chrome and Edge. Is this what demonstrates the recent change in Chrome?

Deleted: chrome-vs-edge.html 459 bytes

chrome-vs-edge.html 459 bytes View Download

Yes, this is basically the same example that I had attached in my first upload.
It works (blue box is NOT collapsed) in IE, Edge and Chrome (before 53 beta). It does not work (blue box collapses) in Chrome 53 beta and Firefox.

Yes, this is my change. The percent height on the div is now respecting the specified height on its containing block, the 1px on the cell, ignoring the fact that the actual height on the cell can be greater.

https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5


Which is correct, the Chrome/FF approach or the Edge/IE one?

Francois, can you chime in?

@mstento re #15: the height of the containing block has been specified explicitly (as a percentage) so why should the div/table should be treated as auto?

What is it that makes the percentage on the cell not 'specified explicitly'? The fact that it computes to auto because there's no value for it be a 100% of? When the spec said 'computes to  auto' this made sense, does it still hold now that wording has gone away?

But the outer table heights are auto, so there's nothing to resolve the percentages against.

I really don't think the wording changes in the spec are supposed to make a difference for us here.

<div id="outer">
    <div id="middle" style="height:100%">
        <div id="inner" style="height:100%;">

The containing block of #middle has auto height, which means that #middle needs to ignore the percentage and behave as auto-height. Since #middle does that, #inner also needs to ignore its percentage and behave as auto-height.

I agree with you, but I do find it hard to reconcile with the wording of the spec. Unless it's covered elsewhere.

The cell has a height in this case (that is not related to its containing block but comes from the rest of the table) so arguably we should resolve the percentage against that.

If we shouldn't do that - but only use the height on the container that we compute for it from its own containing blocks - then we're doing the test case in #16 correctly I think. Do you agree?

I guess the question is whether we should use the actual height of the container (table-cell in this case), as opposed to using the computed height?

Exactly. Your line of reasoning leads me to think we should only care about the computed height (1px) but it seems kind of daft to ignore the actual height of the cell. You would expect using the actual height to be the common sense solution.

The problem is that cells get height for reasons not related to their style or content and as they are pretty unique in this the spec is geared towards expecting actual height as a function of style/content only.

Since Francois is writing the css-tables-3 spec I think we need his guidance here before deciding what to do. Unless you can think of a compelling reason that sends us in a particular direction?

So the question is: when does a container prevent percentage resolution on its children?

<td>
    foo
    <div style="height:100%;">

So here the spec kicks in and forces computed-ish height on the DIV to become auto.

<td style="height:1px;">
    foo
    <div style="height:100%;">

Here the TD has a computed height of 1px, and we can use that to resolve the height of the DIV (i.e. make it 1px "tall").

Or should we use the TD's actual height all of a sudden, just because it has a computed height that's ignored for all practical purposes? That certainly makes no sense to me.

I think we should either *always* resolve TD children percentages against the actual height of the TD (and ignore TD computed height for percentage resolution), or base the decision on whether the TD has a resolvable computed height or not (and use THAT, not actual height).

The reason for not basing any percentage resolution on actual containing block heights is mainly fear of circular dependencies and unpredictable behavior, I guess. It's only safe to use used height when resolving percentages on absolutely positioned descendants, which is why the spec allows that particular case.

But, then again, as you say, tables are unique, and that's sadly in the short bus kind of way. :(

This should not be unconfirmed. Marking assigned as there's active discussions & an owner

Thanks for looping me in.

I can confirm that the current Chrome behavior according to this issue looks like a bug, based on both css 2.1 and the current spec.

The first regression I can think of is the following one: The "height" property on a cell does not affect the cell height, only the row height. This can be confirmed in a case where cells need to baseline-align: https://jsfiddle.net/qxvf1xfe/. You can check this in Webkit, EdgeHTML, Trident and Presto (as well as older Blink builds).

Indeed, it seems that while Firefox was the only browser to exhibit the wrong behavior for years, Chrome regressed at some point. See the following email for w3c test cases covering the issue, and the Firefox issue opened to fix the issue (and all the dupes):
http://www.w3.org/mid/20121128013939.GA30344@crum.dbaron.org
https://bugzilla.mozilla.org/show_bug.cgi?id=569645

Now, when you realize that the "height" property of a table-cell does *not* set the height of the cell box (even its original one), it makes even less sense to resolve percentages based on it. 

The behavior the css-tables-3 spec currently specifies is the following one:
> Computing the row minimum heights
> ====================================
> The minimun height of a row (without spanning-related height distribution) is defined as the height of an hypothetical linebox containing the cells originating in the row and where cells spanning multiple rows are considered having a height of 0px (but their correct baseline). In this hypothetical linebox, cell heights are considered auto, but their other properties are conserved. 
> For the purpose of calculating this height, descendants of table cells whose height depends on percentages of their parent cell' height are considered to have an auto height if they have overflow set to visible, and a 0px height if they have not. 
> https://drafts.csswg.org/css-tables-3/#row-layout

Then, once the final height of the rows/cells have been computed (after height distribution):
> Once the final size of the table and the rows has been determined, the content of the table-cells must also go through a second layout pass, where this time percentage-based heights are resolved against their parent cell height. 
> https://drafts.csswg.org/css-tables-3/#computing-the-table-height

As mentioned in one of the emails about the topic, we have a sufficient amount of compat issues around <td><div style="height:100%;overflow:auto/scroll">...</div></td> that we want to fix the issue in Edge to match how Chrome used to work in this case (considering height:0px for minimum height, then height:100% of cell height in second pass).

What are your thoughs on that behavior? 
Does anyone know why the cell 'height' behavior was modified in Chrome?

 Issue 638959  has been merged into this issue.

Francois: thanks for your feedback.

Could you take a look at my testcases? Are they correct per your spec?

Deleted: percent-height-content-in-fixed-height-cell-and-fixed-height-from-row.html 638 bytes

percent-height-content-in-fixed-height-cell-and-fixed-height-from-row.html 638 bytes View Download

Deleted: percent-height-content-in-fixed-height-cell-with-height-from-row.html 622 bytes

percent-height-content-in-fixed-height-cell-with-height-from-row.html 622 bytes View Download

Deleted: percent-height-content-in-percent-height-cell-with-height-from-row.html 738 bytes

percent-height-content-in-percent-height-cell-with-height-from-row.html 738 bytes View Download

First and third look ok to me.

The second one looks wrong at first glance. The row should end up being 50px tall because the height defined on the cell applies to the row as a min-height instead. That is what the working group resolved and that browsers except Firefox used to do. 

That being said, I think there is some gap in the spec because this is not being mentioned clearly. It should happen in "Import the relevant section of §3.8.3 Computing Column Measures here." but in the mean time I just added the following text just before to make it explicit. 

> Since during row layout the specified heights of cells in the row were ignored and cells that were spanning more than one rows have not been sized correctly, their height will need to be eventually distributed to the set of rows they spanned. 
> 
> This is done by running the same algorithm as the column measurement for spans N>1, with the span=1 value being initialized with the largest of the resulting height of the previous row layout, and the largest specified height of cells that span this row only. 

Cells that span multiple rows will definitely be handled in the section that will follow (as they are for cells that spanned multiple columns in width-calculation).

That makes sense, thanks for clarifying.

I'm looking at this now. It may take a while though, and if people have tests feel free to add them here. I aim to have a CL for next week sometime.

Since this is a high priority regression, once a fix is available we would like to request a merge back to M53. Otherwise we will be in the unfortunate position of communicating to customers that they should pin on M52 until M54 is in stable effectively skipping M53.

+Krishna, any thoughts on the timeline required for a fix that can still make it back into M53?

M53 timeline, if fix is landed/baked/verified in Canary latest before tomorrow 5:00 PM PT, then we can take it in for First M53 stable release.

For second M53 Stable release, fix has to be merged to M53 latest by 5:00 PM PT on (09/06).

Adding "Release-Block-Stable" label for M53 per internal mail thread so it can be tracked.

Just for clarity's sake, @Rob it seems like we're targeting September 6 to have this fix in. If not, can we revert the change that caused the bug and land it again in tandem with this patch when it's fixed?

I think the easiest thing to do to resolve this for M53 is just revert these three now, and then I can work on the correct fix at my own pace. I'll submit a CL to revert them all together.

https://blink.lc/chromium/commit/third_party/WebKit?id=1da432b8b1e60df27ed36d2a6439392d2048551e
https://blink.lc/chromium/commit/third_party/WebKit?id=1afb8400a1d933cd50a16947899b0d88d2d30fb0
https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f93d796537bd28f6c22e6d4165ad9846952cd54

commit 0f93d796537bd28f6c22e6d4165ad9846952cd54
Author: robhogan <robhogan@gmail.com>
Date: Wed Aug 31 09:11:12 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

BUG= 637811 , 627305 ,623026, 465096 , 468699 

Review-Url: https://codereview.chromium.org/2296883002
Cr-Commit-Position: refs/heads/master@{#415588}

[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/Source/core/layout/LayoutBox.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3

commit 4985ab595ba0ab57bf6a3dae7708f82b93fb85c3
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Aug 31 10:14:38 2016

Auto-rebaseline for r415588

https://chromium.googlesource.com/chromium/src/+/0f93d7965

BUG= 637811 
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2298713002 .

Cr-Commit-Position: refs/heads/master@{#415601}

[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/mac/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/mac/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/win/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/win/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/4985ab595ba0ab57bf6a3dae7708f82b93fb85c3/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt

 Issue 642700  has been merged into this issue.

@robhogan: Observing the attached screen-shot as the output. Could you please confirm if this is the expected one.

Tested it on Windows 7, 8.1 & 10.

Attached previous version and latest Canary version screen-shots.

Thank you.

Deleted: 637811.png 106 KB

	637811.png 106 KB View Download

Deleted: 637811 - Old Version.png 31.5 KB

	637811 - Old Version.png 31.5 KB View Download

Yup, that's the expected rendering of the OP. You can also try the test in #6.

Prudhvi, could you please verify this bug on latest Canary. also try the test in #6. Thank you.

I have rechecked this using latest Chrome Canary(55.0.2846.4) on Windows 7,8.1 and 10 with all available test pages provided in different comments#bugreport, 6 and 16, Where in when I tried testpage from comment#12 I don't see a green box below robhogan@ can you please confirm if what I am seeing is expected or not.

Yes that's fine. comment #12 is a separate issue, we've always rendered it that way.

Thank you  robhogan@ for confirmation. If all looks good, could you please request a merge to M53 by applying "Merge-Request-53" label. Thank you.

Please request a merge to M54 as well.

[Automated comment] Less than a week to go before stable on M53, we might already have a stable candidate build. Manual review required.

Your change meets the bar and is auto-approved for M54 (branch: 2840)

[Automated comment] Less than a week to go before stable on M53, we might already have a stable candidate build. Manual review required.

Approving merge to M53 branch 2785 based on comment #41, #42, #44 and #45. Please merge the fix ASAP so we can take it for this week Stable cut. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79c700b4447ef59138eaa437501c4539f18856d

commit e79c700b4447ef59138eaa437501c4539f18856d
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Sep 05 18:14:51 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

Reverts:
https://blink.lc/chromium/commit/third_party/WebKit?id=1afb8400a1d933cd50a16947899b0d88d2d30fb0
https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5

TBR=eae@chromium.org

BUG= 637811 , 627305 , 623026 ,465096, 468699

Review URL: https://codereview.chromium.org/2309903002 .

Cr-Commit-Position: refs/branch-heads/2785@{#824}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/f72812fd4fc8d47803ecb6921e4e78c762ecf56f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/f72812fd4fc8d47803ecb6921e4e78c762ecf56f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/Source/core/layout/LayoutBox.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2ee19735711589f6842da1b5f1f1a37072082c

commit ff2ee19735711589f6842da1b5f1f1a37072082c
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Sep 05 18:21:52 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

Reverts:

https://blink.lc/chromium/commit/third_party/WebKit?id=1da432b8b1e60df27ed36d2a6439392d2048551e
https://blink.lc/chromium/commit/third_party/WebKit?id=1afb8400a1d933cd50a16947899b0d88d2d30fb0
https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5

TBR=eae@chromium.org
BUG= 637811 , 627305 , 623026 ,465096, 468699

Review URL: https://codereview.chromium.org/2309893002 .

Cr-Commit-Position: refs/branch-heads/2840@{#157}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Tested the issue on windows 7 and 10 using chrome version 54.0.2840.14 with the below repro steps from comment #0.seeing the same output as mentioned in comment #41.fix is working fine.

Also tested the issue with comment #6 and 16.Please find the attached screen shots for all.

Adding TE-Verified labels.

Thanks,

Deleted: 637811.png 81.9 KB

	637811.png 81.9 KB View Download

Deleted: 637811(C#0).png 71.9 KB

	637811(C#0).png 71.9 KB View Download

Verified the fix on Windows 7 for Google Chrome Version - 53.0.2785.97 

Screen-recording is attached.

Thank you.

Deleted: 637811.mp4 250 KB

	637811.mp4 250 KB View Download

Verified the issue on windows 7 and 10 using chrome stable version #53.0.2785.101 as per the steps in comment #0. 
Observed that the DIV tag surrounding the inner table did not collapse as expected.

Hence, the fix is working fine.

Attaching a screencast for reference

Thanks,

Deleted: 637811.mp4 312 KB

	637811.mp4 312 KB View Download

This patch is now pushing out to stable channel in version 53.0.2785.101.

Removing "ReleaseBlock-Stable" label as bug is fixed/verified on M53 and M54.

Based on #37, leaving this bug open.

Thank you Rob!

Verified the fix on Windows 7 for Google Chrome Stable Version - 53.0.2785.113 

Screen-recording is attached.

TE-Verified Labels are attached.

Deleted: 637811 - 53.0.2785.113.mp4 184 KB

	637811 - 53.0.2785.113.mp4 184 KB View Download

Francois:

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose height depends on percentages of their parent cell' height are considered to have an auto height if they have overflow set to *visible or hidden* or if they are replaced elements, and a 0px height if they have not."

Am I right in thinking that the addition of *hidden* above means that the attached case should now expect a height of 2002 rather than 202?

Deleted: percent-height-content-in-fixed-height-cell.html 702 bytes

percent-height-content-in-fixed-height-cell.html 702 bytes View Download

Correct. The behavior you see in Firefox isn't due to overflow-y:scroll but to the fact that they don't take the minimum content height of the cell into account when there is a height specified on the cell, which isn't the interoperable behavior.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2ee19735711589f6842da1b5f1f1a37072082c

commit ff2ee19735711589f6842da1b5f1f1a37072082c
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Sep 05 18:21:52 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

Reverts:

https://blink.lc/chromium/commit/third_party/WebKit?id=1da432b8b1e60df27ed36d2a6439392d2048551e
https://blink.lc/chromium/commit/third_party/WebKit?id=1afb8400a1d933cd50a16947899b0d88d2d30fb0
https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5

TBR=eae@chromium.org
BUG= 637811 , 627305 , 623026 ,465096, 468699

Review URL: https://codereview.chromium.org/2309893002 .

Cr-Commit-Position: refs/branch-heads/2840@{#157}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/Source/core/layout/LayoutBox.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5243ab8c1a95305aff233a6175aa3a1f94d092f

commit b5243ab8c1a95305aff233a6175aa3a1f94d092f
Author: robhogan <robhogan@gmail.com>
Date: Tue Nov 01 21:07:40 2016

Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

BUG= 637811 , 627305 ,623026, 465096 , 468699 

Review-Url: https://codereview.chromium.org/2441373002
Cr-Commit-Position: refs/heads/master@{#429109}

[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-and-fixed-height-from-row-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-and-fixed-height-from-row.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-with-height-from-row-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-with-height-from-row.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-with-height-from-row-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-with-height-from-row.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-auto-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-auto-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-hidden-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-hidden-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-scroll-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-scroll-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-visible-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-visible-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-replaced-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-replaced-content-in-cell.html
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a2d5f1f813d651af000fa65a358a97ccb87ad95

commit 2a2d5f1f813d651af000fa65a358a97ccb87ad95
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Nov 01 23:32:17 2016

Auto-rebaseline for r429109

https://chromium.googlesource.com/chromium/src/+/b5243ab8c

BUG= 637811 
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2469973002 .

Cr-Commit-Position: refs/heads/master@{#429155}

[modify] https://crrev.com/2a2d5f1f813d651af000fa65a358a97ccb87ad95/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2a2d5f1f813d651af000fa65a358a97ccb87ad95/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png
[modify] https://crrev.com/2a2d5f1f813d651af000fa65a358a97ccb87ad95/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt
[modify] https://crrev.com/2a2d5f1f813d651af000fa65a358a97ccb87ad95/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png
[modify] https://crrev.com/2a2d5f1f813d651af000fa65a358a97ccb87ad95/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt

Did the change from comment 66 resolve the issue?