New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637754 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 638761
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 638761



Sign in to add a comment

apprtc loopback does not connect

Project Member Reported by wuchengli@chromium.org, Aug 15 2016

Issue description

Version: CrOS veyron_minnie 8707.0.0 (Aug 14)
I also saw this on oak and nyan-big.

What steps will reproduce the problem?
(1) Go to apprtc.appspot.com/?debug=loopback&vsc=VP8.
(2) Press Join.

What is the expected output?
The call connects. The window shows the remote and local videos.

What do you see instead?
The window showed the local video only and the call did not connect. The log showed the error message below.

[1:15:0815/141736:ERROR:webrtc_video_capturer_adapter.cc(230)] NOTREACHED() hit.

void WebRtcVideoCapturerAdapter::OnFrameCaptured(
    const scoped_refptr<media::VideoFrame>& video_frame) {
  if (!(video_frame->IsMappable() &&
        (video_frame->format() == media::PIXEL_FORMAT_I420 ||
         video_frame->format() == media::PIXEL_FORMAT_YV12 ||
         video_frame->format() == media::PIXEL_FORMAT_YV12A))) {
    // Since connecting sources and sinks do not check the format, we need to
    // just ignore formats that we can not handle.
    NOTREACHED();
    return;
  }

https://cs.chromium.org/chromium/src/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc?q=webrtc_video_capturer_adapter.cc&sq=package:chromium&l=230


Other:
Hangout worked fine. Tomas. Can you help triage this? Thanks.

 
Owner: emir...@chromium.org
Emircan. Maybe this is caused by https://codereview.chromium.org/2182183007 (Handle scaling frames in RTCVideoEncoder)?

I found disabling HW encode fixed this. Disabling HW decode did not make a difference.
Cc: wuchengli@chromium.org
Owner: pbos@chromium.org
wuchengli@, i wont be able to reproduce/test as I will be OOO until 22nd. I can take a look after that. I don't think that CL is the reason as it only adds the libyuv::scale code which applies and produces frames thag are mappable. Pbos@, can you take a look to see how webrtc sends non-mappable frames?

Comment 3 by pbos@chromium.org, Aug 15 2016

Cc: magjed@chromium.org sprang@chromium.org posciak@chromium.org mflodman@chromium.org
Owner: wuchengli@chromium.org
I've transitioned teams, +cc'ing some people since I'm not sure how urgent this is but I'm not a good owner.
Labels: videoshortlist
I'll take a look tomorrow.
Blockedon: 638761
Possibly a duplicate of  issue 638761 ?
Mergedinto: 638761
Status: Duplicate (was: Assigned)
Yes. It should be a dup.

Sign in to add a comment