New issue
Advanced search Search tips

Issue 637671 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ash_unittests on Ubuntu-12.04 are failing on Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by hirosh...@chromium.org, Aug 15 2016

Issue description

WindowCycleControllerTest.CycleMruPanelDestroyed
WindowCycleControllerTest.AlwaysOnTopMultipleRootWindows
WindowCycleControllerTest.CyclePanelsDestroyed
WindowCycleControllerTest.SelectingHidesAppList
WindowCycleControllerTest.AlwaysOnTopMultiWindow
WindowCycleControllerTest.AlwaysOnTopWindow

First bad build:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15311

 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece

commit 9ab053f5fdca88cb43cd1a70a06fba521d1f8ece
Author: hiroshige <hiroshige@chromium.org>
Date: Mon Aug 15 08:57:15 2016

Revert "Enable ash window cycle UI by default."

Reason for revert:
Suspected to cause  crbug.com/637671 :
failures in ash_unittests on Linux Chromium OS ASan LSan Tests (1)

Original issue's description:
> Enable ash window cycle UI by default.
>
> I removed the enable flag without replacing it with a disable flag
> because I don't foresee a need for individuals to disable this feature.
> In the case that we decide against launching, this patch should be
> reverted (which is the same thing we'd have to do if we changed it to
> a disable flag).
>
> BUG=626111
> Committed: https://crrev.com/f7648dcc7f7474f89028af0e4643678a6a97a846
> Cr-Commit-Position: refs/heads/master@{#411909}

This reverts commit f7648dcc7f7474f89028af0e4643678a6a97a846.

BUG=626111, 637671 
TBR=jamescook@chromium.org,varkha@chromium.org,sky@chromium.org,estade@chromium.org

Review-Url: https://codereview.chromium.org/2249583002
Cr-Commit-Position: refs/heads/master@{#411949}

[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/common/ash_switches.cc
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/common/ash_switches.h
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/common/wm/window_cycle_controller.cc
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/common/wm/window_cycle_list.cc
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/common/wm/window_cycle_list.h
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ash/wm/window_mirror_view.cc
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/chrome/app/generated_resources.grd
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/chrome/browser/about_flags.cc
[modify] https://crrev.com/9ab053f5fdca88cb43cd1a70a06fba521d1f8ece/ui/app_list/presenter/app_list_presenter_impl.cc

Labels: VerifyIn-54
bulk verified
Status: Verified (was: Fixed)

Sign in to add a comment