New issue
Advanced search Search tips

Issue 637664 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

webkit_tests is failing on WebKit Linux ASAN/MSAN

Project Member Reported by hirosh...@chromium.org, Aug 15 2016

Issue description

Log:
13:46:00.538 24964 worker/6 virtual/spv2/fast/clip/010.html started
...
13:46:01.056 24964 renderer crash, pid = None, error_line = #CRASHED - renderer
13:46:01.057 24964 killed pid 31017
13:46:01.057 24964 worker/6: TypeError('run_command() got an unexpected keyword argument 'input'') raised:
13:46:01.102 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 256, in run
13:46:01.102 24964       worker.handle(message.name, message.src, *message.args)
13:46:01.102 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 257, in handle
13:46:01.102 24964       device_failed = self._run_test(test_input, test_list_name)
13:46:01.102 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 293, in _run_test
13:46:01.102 24964       stop_when_done)
13:46:01.102 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 52, in run_single_test
13:46:01.102 24964       return runner.run()
13:46:01.103 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 133, in run
13:46:01.103 24964       return self._run_sanitized_test()
13:46:01.103 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 153, in _run_sanitized_test
13:46:01.103 24964       driver_output = self._driver.run_test(self._driver_input(), self._stop_when_done)
13:46:01.103 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 192, in run_test
13:46:01.103 24964       self.error_from_test, crash_log = self._get_crash_log(text, self.error_from_test, newer_than=start_time)
13:46:01.103 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 215, in _get_crash_log
13:46:01.103 24964       return self._port._get_crash_log(self._crashed_process_name, self._crashed_pid, stdout, stderr, newer_than)
13:46:01.103 24964     File "/mnt/data/b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 1546, in _get_crash_log
13:46:01.103 24964       ['flock', sys.executable, sanitizer_filter_path, sanitizer_strip_path_prefix], input=stderr, decode_output=False, env=env)

Reproduced locally by 
$ time ./third_party/WebKit/Tools/Scripts/run-webkit-tests virtual/spv2/fast/clip/010.html

virtual/spv2/fast/clip/010.html is failing in a strange way?

Summary: webkit_tests is failing on WebKit Linux ASAN/MSAN (was: webkit_tests is failing on WebKit Linux ASAN)
Failures on Linux MSAN bots have the same error message, so they are also probably the same issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff

commit df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff
Author: hiroshige <hiroshige@chromium.org>
Date: Mon Aug 15 10:14:53 2016

Revert of Fix pylint warnings in webkitpy/common/. (patchset #4 id:60001 of https://codereview.chromium.org/2130093003/ )

Reason for revert:
Causing Linux ASAN bot failure:
 crbug.com/637664 

BUG= 637664 

Original issue's description:
> Fix pylint warnings in webkitpy/common/.
>
> Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
> Cr-Commit-Position: refs/heads/master@{#411710}

TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2248653002
Cr-Commit-Position: refs/heads/master@{#411952}

[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/prettypatch.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/read_checksum_from_png_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_mock.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_unittest.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace_mock.py
[modify] https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc

Status: Fixed (was: Started)
Two reverts are made:
https://codereview.chromium.org/2244193002/
https://codereview.chromium.org/2248653002/
and bots turned green.

Closing as Fixed.

Sign in to add a comment