New issue
Advanced search Search tips

Issue 637630 link

Starred by 2 users
Status: Fixed
Owner:
pkotw...@chromium.org
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

"Add" button in "Add to Homescreen" dialog can be enabled prior to launcher icon being received

Project Member Reported by pkotw...@chromium.org, Aug 15 2016 
Repro steps:
1) Comment out JNI call in AddToHomescreenDialogHelper::OnDataAvailable()
2) Go to http://www.google.com
3) Select "Add to Homescreen" from app menu. Notice that "Add" button is disabled.
4) Edit text in "Add to Homescreen" dialog

Expected:
"Add" button stays disabled
Actual:
"Add" button gets enabled
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d932dfbfe8c3c8e3252c98d04509a3bd639a216

commit 2d932dfbfe8c3c8e3252c98d04509a3bd639a216
Author: pkotwicz <pkotwicz@chromium.org>
Date: Mon Aug 15 22:03:08 2016

Keep "Add" button in "Add to Homescreen" dialog disabled till launcher icon is fetched

This CL fixes a bug where the "Add" button would be enabled if the user modifies
the dialog text prior to AddToHomescreenDialogHelper#onIconAvailable() being
called.

BUG= 637630 

Review-Url: https://codereview.chromium.org/2247633002
Cr-Commit-Position: refs/heads/master@{#412066}

[modify] https://crrev.com/2d932dfbfe8c3c8e3252c98d04509a3bd639a216/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

Comment 2 by kgna...@chromium.org, Aug 16 2016 

Issue 638095 has been merged into this issue.

Comment 3 by tedc...@chromium.org, Feb 21 2018

Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
pkotwicz@ is this resolved?

Comment 4 by pkotw...@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)
Yes it is
►

Sign in to add a comment