New issue
Advanced search Search tips

Issue 637626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 558575
issue 624534



Sign in to add a comment

Suppress scroll anchoring if anchor node ancestor changed any layout-affecting property

Project Member Reported by ymalik@chromium.org, Aug 15 2016

Issue description

Scroll anchoring has accumulated a lot of web compatibility hacks.

A new proposal is to supper anchoring if the anchor node ancestor changed any layout-affecting property.

See this doc for more details:
https://docs.google.com/document/d/1YxqdqXP6bzh-77acaWwfROsvpuoJ7LXUzHU-GXmv_WM/edit?usp=sharing
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f031d2a3e0b8e3d1e8cebe0e859262550137e406

commit f031d2a3e0b8e3d1e8cebe0e859262550137e406
Author: ymalik <ymalik@chromium.org>
Date: Tue Aug 16 17:24:17 2016

Simplify Scroll Anchoring Corner Tests.

The old tests would become irrelevant with the SANACLAP proposal.

BUG= 637626 

Review-Url: https://codereview.chromium.org/2250593002
Cr-Commit-Position: refs/heads/master@{#412272}

[modify] https://crrev.com/f031d2a3e0b8e3d1e8cebe0e859262550137e406/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

Comment 2 by skobes@chromium.org, Aug 17 2016

Cc: -skobes@chromium.org
Owner: skobes@chromium.org
Status: Started (was: Available)

Comment 3 by skobes@chromium.org, Aug 17 2016

Blocking: 624534
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98578a93aa90885ea8fc8a0d30c0823b7eb708ca

commit 98578a93aa90885ea8fc8a0d30c0823b7eb708ca
Author: skobes <skobes@chromium.org>
Date: Fri Aug 19 01:35:54 2016

Implement SANACLAP (http://bit.ly/sanaclap).

ScrollAnchor now suppresses anchoring if the anchor node or one of its ancestors
(up to the scroller) has just changed a layout-affecting CSS property.

Also removes bounce suppression, the 20-adjustment limit, and the exclusion of
absolute-positioned elements with non-zero left/top.

BUG= 637626 

Review-Url: https://codereview.chromium.org/2250523003
Cr-Commit-Position: refs/heads/master@{#413010}

[delete] https://crrev.com/e990f984ef8d2bc49909351ec105dc2f3098f99a/third_party/WebKit/LayoutTests/fast/layout/scroll-anchoring/feedback-loop.html
[delete] https://crrev.com/e990f984ef8d2bc49909351ec105dc2f3098f99a/third_party/WebKit/LayoutTests/fast/layout/scroll-anchoring/onscroll-bouncing.html
[modify] https://crrev.com/98578a93aa90885ea8fc8a0d30c0823b7eb708ca/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/98578a93aa90885ea8fc8a0d30c0823b7eb708ca/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/98578a93aa90885ea8fc8a0d30c0823b7eb708ca/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/98578a93aa90885ea8fc8a0d30c0823b7eb708ca/third_party/WebKit/Source/core/layout/ScrollAnchor.h
[modify] https://crrev.com/98578a93aa90885ea8fc8a0d30c0823b7eb708ca/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp
[modify] https://crrev.com/98578a93aa90885ea8fc8a0d30c0823b7eb708ca/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/98578a93aa90885ea8fc8a0d30c0823b7eb708ca/third_party/WebKit/Source/core/style/StyleDifference.h

Status: Fixed (was: Started)

Sign in to add a comment