<<
/ModDate (D:20160813162504-07'00')
/CreationDate (D:20160813162504-07'00')
/Creator (pdftk 2.01 - www.pdftk.com)
/Producer (itext-paulo-155 \(itextpdf.sf.net-lowagie.com\))
>>

Can I get the original Skia-produced pdf as well?

Also, there is no text in that pdf at all.

Ya, the original PDF was 8 MB, so I cut it down to 1 page with pdftk. Attached is the requested output as p.pdf.

Something like the following HTML snippet from w3schools also comes out broken:

<p>This text contains <sub>subscript</sub> text.</p>

See attached sub*.pdf

Deleted: p.pdf 137 KB

p.pdf 137 KB Download

Deleted: sub_m52.pdf 26.4 KB

sub_m52.pdf 26.4 KB Download

Deleted: sub_m54.pdf 26.3 KB

sub_m54.pdf 26.3 KB Download

unable to reproduce:

/Creator (Mozilla/5.0 \(Windows NT 10.0; Win64; x64\) AppleWebKit/537.36 \(KHTML, like Gecko\) Chrome/54.0.2824.0 Safari/537.36)
/Producer (Skia/PDF m54)

Deleted: crbug_637571_sub.pdf 31.4 KB

crbug_637571_sub.pdf 31.4 KB Download

Well, clearly I can on my machine running Windows 7. Is there anything you can gather from the PDFs I attached? If you provide a debug logging patch, I'd be happy to apply it and run it for you.

Figured out the difference. If I log in to my Windows machine directly, it's fine. If I connect to it via RDP, then it's broken. In my case, I'm running remote desktop from a Linux machine with xfreerdp.

halcanary@: Can we get an update on this blocker issue.

Is it possible that when you are using RDP you are getting bad advances from Windows?  if so, that would break things.

I get the advance from SkGlyphCache::getGlyphIDAdvance(SkGlyphID).fAdvanceX, which should never fail.  bungeman@, is that possible?

thestig@, can you patch in https://codereview.chromium.org/2268313002 and see if that fixes it?

Yes, the CL in comment 8 fixes it for me.

We don't understand the bug yet.  Here's the next thing to try:

build a version of Chrome that includes this Cl that landed today:

    https://chromium.googlesource.com/chromium/src/+/2510d9da 

and follow the instructions inside:

    1) launch chrome with:
       --enable-gpu-benchmarking --no-sandbox
    2) In the javascript console,
       chrome.gpuBenchmarking.printPagesToSkPictures('file.mskp')

Do this with and without RDP for the little subscript example and send me the two mskp files.

Here's the RDP version. If you need the non-RDP version from me, please say so and I'll hook up a monitor to the computer...

Deleted: rdp.mskp 1.0 KB

rdp.mskp 1.0 KB Download

I never got RDP working on my windows box, so thanks for that MSKP!

Here's the fix: https://crrev.com/2273073002

Blinck is assuming that the text is hinted when laying out the page.  This is wrong for vector backends and we should fix that to make more beautiful PDFs.

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/9df5a4c354de0c8f54983f33c792327d782d16f3

commit 9df5a4c354de0c8f54983f33c792327d782d16f3
Author: halcanary <halcanary@google.com>
Date: Wed Aug 24 17:08:13 2016

SkPDF: vector canvases can't hint!

BUG= 637571 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273073002

Review-Url: https://codereview.chromium.org/2273073002

[modify] https://crrev.com/9df5a4c354de0c8f54983f33c792327d782d16f3/src/pdf/SkPDFDevice.cpp

Just waiting for the Skia roller now?

yes.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5005b3d5d481d6777ffeb1b41603843e9df50458

commit 5005b3d5d481d6777ffeb1b41603843e9df50458
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Wed Aug 24 22:52:40 2016

Roll src/third_party/skia/ 3bf7509c3..168261287 (17 commits).

https://chromium.googlesource.com/skia.git/+log/3bf7509c3f68..168261287136

$ git log 3bf7509c3..168261287 --date=short --no-merges --format='%ad %ae %s'
2016-08-24 caryclark mark fuzz test flaky since it may fail on some platforms
2016-08-24 halcanary gyp/sfntly: set SK_SFNTLY_SUBSETTER uniformly
2016-08-24 mtklein GN: guard tools (except fiddle) by skia_enable_tools.
2016-08-24 mtklein SkPngCodec: voidp instead of forward-declares for png.h types.
2016-08-24 ajuma Fix leak in GrTextureStripAtlasTest
2016-08-24 bungeman s/invertable/invertible
2016-08-24 caryclark tiny line breaks gl render
2016-08-24 fmalita Fix SkTLazy(const T*) initialization
2016-08-24 mtklein GN: Fuchsia probably cannot link without this.
2016-08-24 halcanary SkPDF: vector canvases can't hint!
2016-08-24 mtklein GN: more optional components: jpeg, pdf, png, xml
2016-08-24 caryclark remove point aliases
2016-08-24 halcanary SkPDF: vertical writing: draw nothing
2016-08-24 bungeman Add simple font fallback on Mac.
2016-08-24 ajuma Make GrTextureStripAtlas flush pending IO on newly acquired texture
2016-08-24 msarett Parse ICC profiles from webps
2016-08-24 egdaniel Add addtional resolve calls to vulkan backend

BUG= 637678 , 640176 , 637571 , 637678 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2274283002
Cr-Commit-Position: refs/heads/master@{#414184}

[modify] https://crrev.com/5005b3d5d481d6777ffeb1b41603843e9df50458/DEPS