GN does not use "use_gnome_keyring"
Reported by
mfor...@gmail.com,
Aug 13 2016
|
||
Issue description
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36
Steps to reproduce the problem:
1. Try to build with GN
2. Notices that is asks for the gnome-keyring-1 package
3.
What is the expected behavior?
Gnome Keyring should be optional
What went wrong?
Looking at components/os_crypt/BUILD.gn
I can see that
if (is_desktop_linux) {
# Gnome-keyring is normally dynamically loaded. The gnome_keyring config
# will set this up.
pkg_config("gnome_keyring") {
packages = [ "gnome-keyring-1" ]
It should also check if you have use_gnome_keyring=false , gyp does this.
Did this work before? N/A
Chrome version: 54.0.2824.0 Channel: dev
OS Version:
Flash Version: Shockwave Flash 22.0 r0
,
Aug 16 2016
Cool, that's very nice. I tried with 54.0.2824.0 which was the latest I could find a tarball for and in that it wasn't working. Glad to see this was fixed. I'll apply the patch for that commit and if it works this bug can be closed.
,
Aug 16 2016
Yes, confirmed. That does indeed fix this. Please close this issue as fixed. Thank you.
,
Aug 17 2016
Thanks for confirming, closing this issue. Please raise a new issue if you come across the similar one on latest chrome version. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by vabr@chromium.org
, Aug 16 2016