New issue
Advanced search Search tips

Issue 637543 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 650607

Blocking:
issue 638055
issue 654664



Sign in to add a comment

CSS Motion Path: New names for properties

Project Member Reported by ericwilligers@chromium.org, Aug 13 2016

Issue description

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

We have already shipped with the earlier names. For a period of time we can alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

This patch doesn't include any of the additional options the spec provides for offset-path (<angle> [contain]) or offset-distance (closest-side / farthest-side / closest-corner / farthest-corner).


 
Blocking: 638055
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1

commit ba9dc4f32ee4a0a29ab99be8274e2605998d14b1
Author: ericwilligers <ericwilligers@chromium.org>
Date: Tue Sep 20 09:57:09 2016

CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

Intent To Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ

This patch doesn't include deprecation warnings for the old names, or the extra use counter for not-none motion-path discussed in the Intent To Ship.

This patch also doesn't include any of the additional options the spec provides for offset-path (<angle> [contain]) or offset-distance (closest-side / farthest-side / closest-corner / farthest-corner).
(They will be implemented behind a flag, for a future Intent to Ship.)

BUG= 637543 

Review-Url: https://codereview.chromium.org/2241993002
Cr-Commit-Position: refs/heads/master@{#419710}

[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/animations/composition/offset-distance-composition.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/animations/composition/offset-rotation-composition.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/animations/interpolation/offset-distance-interpolation.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/animations/interpolation/offset-rotation-interpolation.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/animations/responsive/offset-rotation-responsive.html
[rename] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/combine-motion-translation-and-rotation-expected.html
[rename] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/combine-motion-translation-and-rotation.html
[copy] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/combine-offset-translation-and-rotation-expected.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/combine-offset-translation-and-rotation.html
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/combine-rotation.html
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/combine-translation.html
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/compute-distance.html
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/offset-distance.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/offset-path.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation.html
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/offset.html
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/css3/motion-path/zero-length.html
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/platform/android/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/animation/BUILD.gn
[delete] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/third_party/WebKit/Source/core/animation/CSSMotionRotationInterpolationType.cpp
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.cpp
[rename] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/CSSProperties.in
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/BUILD.gn
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/StyleMotionData.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/StyleMotionData.h
[delete] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/third_party/WebKit/Source/core/style/StyleMotionRotation.h
[add] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/StyleOffsetRotation.h
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/third_party/WebKit/Source/core/style/StyleTransformData.cpp
[modify] https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1/tools/metrics/histograms/histograms.xml

Blockedon: 650607
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/824859c6bd1aad0b03e1b32dc8f504863b364f9f

commit 824859c6bd1aad0b03e1b32dc8f504863b364f9f
Author: ericwilligers <ericwilligers@chromium.org>
Date: Thu Oct 06 06:07:12 2016

CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhRAAAJ
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG= 637543 

Review-Url: https://codereview.chromium.org/2358433005
Cr-Commit-Position: refs/heads/master@{#423447}

[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-motion-path.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-motion.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset-path.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset-position.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html
[modify] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Blocking: 654664
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/824859c6bd1aad0b03e1b32dc8f504863b364f9f

commit 824859c6bd1aad0b03e1b32dc8f504863b364f9f
Author: ericwilligers <ericwilligers@chromium.org>
Date: Thu Oct 06 06:07:12 2016

CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhRAAAJ
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG= 637543 

Review-Url: https://codereview.chromium.org/2358433005
Cr-Commit-Position: refs/heads/master@{#423447}

[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-motion-path.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-motion.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset-path.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset-position.html
[add] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html
[modify] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f/tools/metrics/histograms/histograms.xml

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 10 by yio...@gmail.com, Nov 30 2016

Rename offset-rotation to be offset-rotate 😂

https://github.com/w3c/fxtf-drafts/issues/70

Sign in to add a comment