WebUIURLFetcher / WebUIUserScriptLoader should use RenderFrame ID, not RenderView ID |
|||
Issue description
The classes related to the WebUI user scripts use RenderView routing IDs instead of RenderFrame IDs in situations where downstream callees expect RenderFrame IDs. This should be fixed.
For example. WebUIURLFetcher::Start (permalink [1], codesearch [2]) contains
content::AssociateURLFetcherWithRenderFrame(
fetcher_.get(), url_, render_process_id_, render_view_id_);
... but AssociateURLFetcherWithRenderFrame expects a RenderFrame ID.
[1] https://chromium.googlesource.com/chromium/src/+/cfd9cd2aa814084af023e77e66fb5e1f42f71b88/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc#34
[2] https://cs.chromium.org/search/?q=%22WebUIURLFetcher::Start%22&sq=package:chromium
,
Aug 15 2016
Right you are. Codesearch was stale and I did not notice the issue was fixed when I generated the permalink.
,
Aug 15 2016
(swapping to fix, because I think WontFix messaging implies the bug wasn't a bug - whereas this was just one that happened to already be fixed. :)) |
|||
►
Sign in to add a comment |
|||
Comment 1 by rdevlin....@chromium.org
, Aug 15 2016