New issue
Advanced search Search tips

Issue 637509 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 3
Type: Bug



Sign in to add a comment

Replace ASSERT with DCHECK in WebAudio

Reported by hyungwoo...@navercorp.com, Aug 13 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.57 Safari/537.36

Steps to reproduce the problem:
There are some places in WebAudio where we are using ASSERT.

What is the expected behavior?
Replace ASSERT with DCHECK in WebAudio.

What went wrong?
Replace ASSERT(isGraphOwner()) is handled in https://bugs.chromium.org/p/chromium/issues/detail?id=626446

Did this work before? N/A 

Chrome version: 53.0.2785.57  Channel: beta
OS Version: 
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by rtoy@chromium.org, Aug 13 2016

Components: Blink>WebAudio
Status: Available (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261ef60b39f7bf1f3232b4fa595e6c78ff57c048

commit 261ef60b39f7bf1f3232b4fa595e6c78ff57c048
Author: hyungwook.lee <hyungwook.lee@navercorp.com>
Date: Wed Aug 17 09:29:19 2016

Replace ASSERT with DCHECK in WebAudio

BUG= 637509 
R=hongchan@chromium.org,rtoy@chromium.org

Review-Url: https://codereview.chromium.org/2159403002
Cr-Commit-Position: refs/heads/master@{#412483}

[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.h
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
[modify] https://crrev.com/261ef60b39f7bf1f3232b4fa595e6c78ff57c048/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.cpp

Comment 3 by with...@gmail.com, Aug 18 2016 

Need to change OS to All.

Comment 4 by hongchan@chromium.org, Aug 18 2016

Labels: -Pri-2 OS-All Pri-3
Status: Fixed (was: Available)
►

Sign in to add a comment