New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637488 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[payments] Shipping summary should be: name, address, phone, shipping option (each on its own line).

Project Member Reported by hs1217....@samsung.com, Aug 13 2016

Issue description

Steps to reproduce the problem:
1. save autofill profile(need to long address)
2. visit https://rsolomakhin.github.io/pr/multi/
3. click "buy" button.
4. check shipping summary section.

What is the expected behavior?
address lable will be locate left and name label will be locate right. 

What went wrong?
address label is locate right and name label is locate left.
when address label length is long, address label is truncated  both sides.

Did this work before? N/A 

Chrome version: 54.0.2828  Channel: stable
OS Version: 6.0.1
Flash Version:
 
wrong.png
297 KB View Download
expect.png
24.7 KB View Download

Comment 2 Deleted

i resolved this isssue.
refer to https://codereview.chromium.org/2244583002/

please review this CL.
when apply CL, label location was changed like expected.
apply_cl.png
306 KB View Download
Components: -UI UI>Browser>Autofill>Payments
Owner: hwi@chromium.org
Thank you for the patch! Let's check with UX (hwi@).

hwi@: What is the desired behavior?

Comment 6 by hwi@chromium.org, Aug 15 2016

Cc: dfalcant...@chromium.org
Thanks for reporting and CL! 

We're fixing this issue by separating each entry in separate lines in the bottom sheet view.

+dfalcantara@ fyi
hwi@, does the screenshot at https://bugs.chromium.org/p/chromium/issues/attachment?aid=246774&inline=1 show the desired solution?

Comment 8 by hwi@chromium.org, Aug 15 2016

No. Attaching the screenshot with the desired fix. Thanks!
shipping.png
35.6 KB View Download
Cc: hwi@chromium.org
Owner: ----
Status: Available (was: Unconfirmed)
Summary: [payments] Shipping summary should be: name, address, phone, shipping option (each on its own line). (was: [payments] address label should located at left and name label should located at right in shipping summary section.)
hs1217.lee@, if you're interested in working on this, please follow the mock in https://bugs.chromium.org/p/chromium/issues/attachment?aid=246903&inline=1.

Comment 10 by hwi@chromium.org, Aug 15 2016

Let me know for any questions! Thanks=)
Cc: -dfalcant...@chromium.org rouslan@chromium.org
Owner: dfalcant...@chromium.org
Status: Assigned (was: Available)
Yeah, this requires more than just a simple two-line variable switch and has been on my radar.  I'll take this on myself after downloads is more settled.
Issue 640815 has been merged into this issue.
Cc: dfalcant...@chromium.org
Owner: gogerald@chromium.org
I am looking this bug, just want to clarify my understanding of the expected result: shipping name in a single line on top, shipping address and post code in a single line, the shipping address can be elided at the end, contact phone number in a single line (what if no phone number, use email? otherwise hide?), shipping method summary in a single line. Am I correct?

Comment 15 by hwi@google.com, Oct 13 2016

Thanks for working on this gogerald@. 

1. Name in a single line on top: correct
2. Address and post code in a single line: correct
3. Address can be elided at the end: hoping to elide in the middle right before postal code. I guess it could be challenging since postal code lengths are different.
4. What if no phone number, use email? otherwise hide?: yes hide the entire row so the row doesn't take up the space. There's only phone number, no email for shipping. 
5. Shipping method summary in a single line: correct
Okay, here is the screenshot of the updated UI, the address is elided in the middle (before the post code in this case). 

Yes, it might be challenging to elide at the end of address but before the post code, and we might have to provide post code separately. Would like to leave it for now. 

hwi@ what do you think?
Screenshot_2016-10-13-17-20-01.png
179 KB View Download

Comment 17 by hwi@chromium.org, Oct 13 2016

Cc: zkoch@chromium.org
#16 - LGTM. Thanks! 

========
Question: I was about to ask for other refinements on Payment and Contact rows on the same bottom sheet (see the screenshot). They're related since it's an attempt to reduce the total height by compensating the increased height from the original fix. 

Should I file a separate bug? 
bottomsheet-payment-contact-comma.png
46.9 KB View Download
I think it's better to file a separate bug since 'Payment', 'Contact info' and 'Shipping' are in separate rows (separate in code).

Comment 19 by hwi@chromium.org, Oct 13 2016

Thanks! Filed:  crbug.com/655823     crbug.com/655822 
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
This issue is fixed in current M56 build 56.0.2895.3. UI appears as the screenshot in the comment 16.

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment