[payments] Shipping summary should be: name, address, phone, shipping option (each on its own line). |
||||||||||
Issue descriptionSteps to reproduce the problem: 1. save autofill profile(need to long address) 2. visit https://rsolomakhin.github.io/pr/multi/ 3. click "buy" button. 4. check shipping summary section. What is the expected behavior? address lable will be locate left and name label will be locate right. What went wrong? address label is locate right and name label is locate left. when address label length is long, address label is truncated both sides. Did this work before? N/A Chrome version: 54.0.2828 Channel: stable OS Version: 6.0.1 Flash Version:
,
Aug 13 2016
i resolved this isssue. refer to https://codereview.chromium.org/2244583002/ please review this CL.
,
Aug 13 2016
when apply CL, label location was changed like expected.
,
Aug 13 2016
Thank you for the patch! Let's check with UX (hwi@). hwi@: What is the desired behavior?
,
Aug 15 2016
Thanks for reporting and CL! We're fixing this issue by separating each entry in separate lines in the bottom sheet view. +dfalcantara@ fyi
,
Aug 15 2016
hwi@, does the screenshot at https://bugs.chromium.org/p/chromium/issues/attachment?aid=246774&inline=1 show the desired solution?
,
Aug 15 2016
No. Attaching the screenshot with the desired fix. Thanks!
,
Aug 15 2016
hs1217.lee@, if you're interested in working on this, please follow the mock in https://bugs.chromium.org/p/chromium/issues/attachment?aid=246903&inline=1.
,
Aug 15 2016
Let me know for any questions! Thanks=)
,
Aug 15 2016
Yeah, this requires more than just a simple two-line variable switch and has been on my radar. I'll take this on myself after downloads is more settled.
,
Aug 24 2016
Issue 640815 has been merged into this issue.
,
Oct 13 2016
,
Oct 13 2016
I am looking this bug, just want to clarify my understanding of the expected result: shipping name in a single line on top, shipping address and post code in a single line, the shipping address can be elided at the end, contact phone number in a single line (what if no phone number, use email? otherwise hide?), shipping method summary in a single line. Am I correct?
,
Oct 13 2016
Thanks for working on this gogerald@. 1. Name in a single line on top: correct 2. Address and post code in a single line: correct 3. Address can be elided at the end: hoping to elide in the middle right before postal code. I guess it could be challenging since postal code lengths are different. 4. What if no phone number, use email? otherwise hide?: yes hide the entire row so the row doesn't take up the space. There's only phone number, no email for shipping. 5. Shipping method summary in a single line: correct
,
Oct 13 2016
Okay, here is the screenshot of the updated UI, the address is elided in the middle (before the post code in this case). Yes, it might be challenging to elide at the end of address but before the post code, and we might have to provide post code separately. Would like to leave it for now. hwi@ what do you think?
,
Oct 13 2016
#16 - LGTM. Thanks! ======== Question: I was about to ask for other refinements on Payment and Contact rows on the same bottom sheet (see the screenshot). They're related since it's an attempt to reduce the total height by compensating the increased height from the original fix. Should I file a separate bug?
,
Oct 13 2016
I think it's better to file a separate bug since 'Payment', 'Contact info' and 'Shipping' are in separate rows (separate in code).
,
Oct 13 2016
Thanks! Filed: crbug.com/655823 crbug.com/655822
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f commit a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f Author: gogerald <gogerald@chromium.org> Date: Fri Oct 14 22:23:11 2016 Make shipping name, address, phone and option each on its own line in the shipping summary BUG= 637488 Review-Url: https://codereview.chromium.org/2421433004 Cr-Commit-Position: refs/heads/master@{#425493} [modify] https://crrev.com/a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java [modify] https://crrev.com/a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
,
Oct 19 2016
,
Oct 20 2016
This issue is fixed in current M56 build 56.0.2895.3. UI appears as the screenshot in the comment 16.
,
Jun 27 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by hs1217....@samsung.com
, Aug 13 201624.7 KB
24.7 KB View Download