Dup of  issue 333743 ? Does Win10 make it possible to give canary a different icon without having a distinct chrome.VisualElementsManifest.xml?

I think it would need a separate manifest, but since we generate that in the installer I guess this is possible by checking the channel at that point? (that should work for 10 at least, not sure about 8)

Hmm. Could work. Until now, the files have been identical between normal and SxS. I don't think this is a requirement, though.

Should work, does manifest support icon IDs or do we have to extract the resource into a .ico?

Neither. :) Has to be loose png or jpg.

The ones we use now for stable got moved to https://cs.chromium.org/chromium/src/chrome/app/visual_elements_resources/?type=cs&q=logo.png&sq=package:chromium, so in theory, it should be a matter of putting a couple canary ones there, making the installer work, and then the inevitably tricky testing.

Ah ok, then that's easy, just have two copy of the assets (one for Chrome one for Canary) and change the manifest being generated to point at those if IsChromeSxS(). Testing should be easy IMO (no toggling between the assets for a given product)

Hi cleer, grt realized we had some mixed up logic in the Chrome vs. Chromium icons, so we were building in the Chrome-y ones when someone built as Chromium. Would you mind doing a similar pair of tile icons that are blue-Chromium-style so I can put them in for the Chromium theme?

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/bcead437f80f912c0526b813936900763fc782da

commit bcead437f80f912c0526b813936900763fc782da
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Aug 25 16:27:44 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c120019e3da7d32e3f9deb23cc91a7db92ac541

commit 8c120019e3da7d32e3f9deb23cc91a7db92ac541
Author: scottmg <scottmg@chromium.org>
Date: Thu Aug 25 20:40:50 2016

Add a Canary-specific icon in VisualElementsManifest.xml

This will fix the tile in Win10 being always the full-colour version,
even for Canary.

Removes the now unused SecondaryTile.png. (I think it was for Metro mode in
Win8? I'm not sure... but it was already unused as of this CL.)

R=grt@chromium.org
BUG= 637477 

Review-Url: https://codereview.chromium.org/2253323002
Cr-Commit-Position: refs/heads/master@{#414529}

[modify] https://crrev.com/8c120019e3da7d32e3f9deb23cc91a7db92ac541/chrome/BUILD.gn
[add] https://crrev.com/8c120019e3da7d32e3f9deb23cc91a7db92ac541/chrome/app/theme/chromium/win/tiles/Logo.png
[add] https://crrev.com/8c120019e3da7d32e3f9deb23cc91a7db92ac541/chrome/app/theme/chromium/win/tiles/SmallLogo.png
[delete] https://crrev.com/1d692d1e0170d7b6b1670073b2be2c14edb2a65e/chrome/app/visual_elements_resources/Logo.png
[delete] https://crrev.com/1d692d1e0170d7b6b1670073b2be2c14edb2a65e/chrome/app/visual_elements_resources/SecondaryTile.png
[delete] https://crrev.com/1d692d1e0170d7b6b1670073b2be2c14edb2a65e/chrome/app/visual_elements_resources/SmallLogo.png
[modify] https://crrev.com/8c120019e3da7d32e3f9deb23cc91a7db92ac541/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/8c120019e3da7d32e3f9deb23cc91a7db92ac541/chrome/installer/setup/install.cc

OK, latest Canary has the yellow icon. Assigning back to you Chris for blue Chromium art -- I landed some very very ugly hue-shifted versions in the CL above  as placeholder: https://codereview.chromium.org/2253323002/diff/80001/chrome/app/theme/chromium/win/tiles/Logo.png .

Hi Scott, just uploaded Chromium assets to the same folder.

Thanks Chris, https://codereview.chromium.org/2310603002/.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0189329e1770e9f7b2949944ee145be3e8910d5

commit d0189329e1770e9f7b2949944ee145be3e8910d5
Author: scottmg <scottmg@chromium.org>
Date: Fri Sep 02 21:28:45 2016

win: Update Chromium tiles from previous placeholder art

R=oshima@chromium.org
BUG= 637477 

Review-Url: https://codereview.chromium.org/2310603002
Cr-Commit-Position: refs/heads/master@{#416346}

[modify] https://crrev.com/d0189329e1770e9f7b2949944ee145be3e8910d5/chrome/app/theme/chromium/win/tiles/Logo.png
[modify] https://crrev.com/d0189329e1770e9f7b2949944ee145be3e8910d5/chrome/app/theme/chromium/win/tiles/SmallLogo.png