New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637464 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Letters overlap on naver.com on Galaxy Note 2

Reported by k939...@gmail.com, Aug 12 2016

Issue description

Device name: KT Samsung Galaxy Note II

From "Settings > About Chrome"
Application version: 54.0.2826.2
OS:4.4.2 KOT49H

URLs (if applicable): www.naver.com

Behavior in Android Browser (if applicable):



Steps to reproduce:
(1)Go to www.naver.com
(2)input alphabet in Search Bar
(3)You can see alphabet is overlapped so I cannot read it.

Expected result: abcdegh on Searchbar


Actual result: Alphabet Overlapped



 
Screenshot_2016-08-13-08-34-13.png
212 KB View Download
Screenshot_2016-08-13-08-39-46.png
121 KB View Download
Components: UI>Input
Labels: -Pri-3 M-54 ReleaseBlock-Beta Pri-1 Type-Bug-Regression
Owner: changwan@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for the report!

I'm able to repro this on Note 2 (GT-N7100) with KOT49H too.  The cursor doesn't move forward after inputting, and so the inputted text are overlapped. 

Starts to occur in M54 - 54.0.2790.2.  Doesn't repro in latest M53 (53.0.2785.72).


I've attached logcat and video at http://go/chrome-androidlogs1/6/637464

Comment 2 by k939...@gmail.com, Aug 20 2016

Thanks for commenting.

About this bug, I've collected additional information and I received that Nexus 5X with Android N Developer Preview 5 with Chrome Dev 54.0.2826.2 has no issues.



If I get additional information, I'll leave comment. Thanks.



Components: -UI>Input Blink>Fonts Blink>Layout
Owner: ----
Status: Untriaged (was: Assigned)
I think this is more related to font rendering or layout in general. In any case, unassigning myself as I'm not familiar with this.

Comment 4 by e...@chromium.org, Aug 24 2016

Components: -Blink>Layout -Blink>Fonts Blink>Editing
Text input and caret positing is part of editing. Looks android specific, at least I cannot reproduce on any other platform. You might want to loop in the android team.
Cc: tedc...@chromium.org
tedchoc@ - do you know who best to take a look at this?

I was also able to repro on Note 4 (SM-N910C) with K.
Cc: aelias@chromium.org
aelias@ might have a better person to assign this too, but I'm not sure who handles font rendering or caret positioning.  I don't know if blink auto triages the components and maybe this will be auto picked up by someone.

Comment 7 by yosin@chromium.org, Aug 25 2016

Components: -Blink>Editing Blink>Fonts
Owner: drott@chromium.org
It seems Blink failed to get width of font. Pixel position of caret is calculated from layout block and font dimension.

drott@, WDYT?

Comment 8 by aelias@chromium.org, Aug 25 2016

Status: Assigned (was: Untriaged)
Bisected to https://codereview.chromium.org/2123653005 "Activate complex text path on Android"

Comment 9 by aelias@chromium.org, Aug 25 2016

Cc: e...@chromium.org
drott@, note that the bug only reproduces on the specific Samsung devices listed.  You might consider buying one for your office (make sure you get the exact right model number as Samsung brand names are vague), or if someone in MTV/SF can investigate, I can lend them a device.

Comment 10 by drott@chromium.org, Aug 25 2016

Cc: behdad@chromium.org
Could someone, perhaps candrada@, who has the device connect using DevTools, inspect the element that fails to render correctly, then look at Computed style and scroll down to the bottom to see the used font? Then, if possible, send me that font file by copying it from the device using adb pull from /system/fonts?
I am suspecting there is a bug in the font file.

Comment 11 by k939...@gmail.com, Aug 25 2016

http://drive.google.com/file/d/0BzPutWuhxY59Z0szUVNWNEUtbkk/view?usp=sharing


This is entire font file of KT Samsung Galaxy Note 2(SHV-E250K) kitkat 4.4.2 KOT49H


If you need additional file or log, leave comment please.(rooting is difficult to do because of KNOX)


Thanks.

Comment 12 by drott@chromium.org, Aug 25 2016

Thanks for the font files, I'll try with those. In the meantime, it would be good to know which font is used for rendering for the elements that occur overlapped. Could you follow the steps in #10, enable developer mode, go to chrome://inspect on your desktop borwser while the device is connected using adb, then inspect the element on the Naver page, look at the computed styles tab, scroll down to see the used fonts? Thanks.

I attached a screenshot of what I see there, let me know if you need anything else.
naver_search_font_inspector.png
832 KB View Download

Comment 14 by drott@chromium.org, Aug 25 2016

Thanks, if you could scroll down to the very bottom, do you see the information for rendered fonts there? Compare my screenshot.

Comment 15 by drott@chromium.org, Aug 25 2016

naver_search_rendered_fonts_example_mac.png
758 KB View Download
Cc: l...@chromium.org pfeldman@chromium.org
I do not see that information, sorry.  I think that's a missing feature of devtools remote inspection, the same complaint came up in https://bugs.chromium.org/p/chromium/issues/detail?id=637485#c6 .  A related request is assigned to luoe@ in http://crbug.com/593584
Summary: Letters overlap on naver.com on Galaxy Note 2 (was: Alphabet overlapped)
Maybe you could build an APK that LOG(ERROR)s the font information you're interested in and I can run it and send you the results.  I'd recommend just buying one for your office at the same time though in case the remote investigation isn't productive, these device models shouldn't be difficult to find online.

Comment 19 by k939...@gmail.com, Aug 25 2016

This bug also occured in S3 Kitkat and Note 3 Kitkat.
Maybe it is better to fix title to 'alphabet is overlapped on Samsung Kitkat devices in South Korea search site'
Even, I can repro it on 2 major search sites in South Korea (http://www.daum.net) (http://www.nate.com)

Also, Alphabet is not only overlapped on Searchbar.
It also overlapped entire site.

Naver use NanumGothic in their Mobile page but I don't know what Daum and Nate use. But, they never ever use NanunGothic because Nanum font was developed by Naver.


What is common things between 3 sites??
I can't figure it out.... But that's the key to silve this problem. 

Comment 20 Deleted

Comment 21 by k939...@gmail.com, Aug 25 2016

Sorry. Not entire site.

some parts print alphabet without any problem. 
I know what part print font properly and what parts didn't but I don't have skills to analyze it.... sad...ㅠ_ㅠ


Screenshot_2016-08-26-06-55-01.png
118 KB View Download
Screenshot_2016-08-26-06-55-21.png
121 KB View Download
Screenshot_2016-08-26-06-58-08.png
145 KB View Download

Comment 22 by drott@chromium.org, Aug 26 2016

Doing a quick contact sheet with the fonts in the fonts.zip archive (screenshot attached), it seems that the Padauk font has issues rendering, even when I use it on the Linux desktop version as a web font.

Could you attach the following files from the device:
system/etc/fallback_fonts.xml
system/etc/fonts.xml
system/etc/system_fonts.xml

The naver site only specifies a font available on iOS and "sans-serif" for the search field. I wonder why Padauk font is mapped to sans-serif here.


fonts_contact_sheet.png
527 KB View Download

Comment 23 by k939...@gmail.com, Aug 26 2016

I can't find font.xml in /system/etc

fallback_fonts.xml
5.9 KB View Download
system_fonts.xml
4.1 KB View Download

Comment 24 by drott@chromium.org, Aug 26 2016

Thanks for the quick reply. Do you see any additional *fonts* files in /vendor/etc/? E.g. /vendor/etc/fallback_fonts.xml?

Comment 25 by k939...@gmail.com, Aug 26 2016

unfortunately, no
Screenshot_2016-08-26-23-42-57.png
128 KB View Download

Comment 26 by drott@chromium.org, Aug 26 2016

Cc: kojii@chromium.org
Koji, do you happen to have one of those devices at the office? Any idea why we end up using the pretty broken Padauk font?

Comment 27 by drott@chromium.org, Aug 26 2016

Filed HarfBuzz issue https://github.com/behdad/harfbuzz/issues/305 for the Padauk rendering, although I believe the font is broken or only works correctly with Graphite. 

However, our main bug here is probably why we end up using the Padauk font. The fallback chain should definitely not select Padauk for sans-serif.


Comment 28 by drott@chromium.org, Aug 26 2016

I am trying to get the device internally.

aelias@, is the collapsed rendering reproducible with:
http://roettsch.es/ko_sans.html ? If yes, I could try to send you a logging-enriched APK to dig further.


Yes, the collapsed rendering is reproducible on http://roettsch.es/ko_sans.html

Comment 30 by kojii@chromium.org, Aug 27 2016

> However, our main bug here is probably why we end up using the Padauk font. The fallback chain should definitely not select Padauk for sans-serif.

From the screenshot in #25, I think the user customized the default font on his device. Galaxy ships a built-in feature to change the default font, and when user does it, "sans-serif" is replaced with the specified font. See "UI Font Customization" section in this doc[1].

[1] https://docs.google.com/document/d/1BI0OiWRUvsBOuPxPlF5J-_xtUZ49eVDUEXZXoF32ZcM/edit?usp=sharing

Comment 31 by k939...@gmail.com, Aug 27 2016

Yes. I use custom font named '365 Simple Daily' from Galaxy Apps.


But nothing changed when I use to default font like screenshot.
Screenshot_2016-08-27-14-46-51.png
133 KB View Download
Screenshot_2016-08-27-14-47-31.png
127 KB View Download

Comment 32 by kojii@chromium.org, Aug 29 2016

Can you reboot your device? There's no system API to change the default font for Android, so Galaxy's setting to change it is not an official way. Chrome may cache the font.

Comment 33 by k939...@gmail.com, Aug 30 2016

restart with default font, reinstall chrome dev makes nothing change

Comment 34 by drott@chromium.org, Aug 30 2016

Re #18, aelias@:

> Maybe you could build an APK that LOG(ERROR)s the font information you're interested in and I can run it and send you the results.  

I sent you an internal mail with APK info and some instructions - it would be great if you could run that for me and attach the adb logcat output. Thanks a lot in advance.

[Bulk edit]

This is marked as a beta blocker for Android M54.  We're looking to ship that very soon, so please try to have this bug fixed no later than next Wednesday 9/7 so that it can be merged to branch 2840 ASAP.

Know for sure this isn't a beta blocker?  Remove the label (or retarget to stable if appropriate).
Not sure if this should block beta or not?  CC me and ask!
Know this should block beta, but also know you won't be able to fix it in time?  CC me and let me know ASAP.

Thanks! 
If you are still blocked on information-gathering, have you bought a device yet?  I don't think it's a good tradeoff to risk delaying the 54 beta release to try to save Google a few hundred dollars expense.  I routinely approve expenses of rare bug-repro devices for folks on Clank team even if another site holds the device.


I sent back the logs from the special APK, for future reference they are:

I/chromium( 6832): [INFO:FontFallbackIterator.cpp(34)] new FontFallbackiterator
I/chromium( 6832): [INFO:FontFallbackIterator.cpp(93)] Returning typeface SamsungKorean. Next m_fallbackStage: 1
I/chromium( 6832): [INFO:FontFallbackIterator.cpp(85)] Skipping already returned SkTypeface SamsungKorean
I/chromium( 6832): [INFO:FontFallbackIterator.cpp(93)] Returning typeface á<80><95>á<80>­á<80><90>á<80>±á<80>¬á<80><80>á<80>ºá<80><85>á<80>¬á<80>¡á<80>¯á<80><95>á<80>º. Next m_fallbackStage: 4

The typeface string is valid UTF-8, it is "ပိတောက်စာအုပ်".  This is Burmese, as expected from Padauk font.
Workaround/Fix for broken Padauk font in https://codereview.chromium.org/2306383002

aelias@, I've sent you another APK - if you could try one last time with that, it should fix the issue. Thanks.

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17dc0df0ddb82ed1a2733316139856f67317b51b

commit 17dc0df0ddb82ed1a2733316139856f67317b51b
Author: drott <drott@chromium.org>
Date: Mon Sep 05 12:00:19 2016

Blacklist GDEF tables for Padauk fonts

The Padauk fonts have broken GDEF tables that define a set of Latin
characters as marks, which leads to collapsed advances. More details in
https://github.com/behdad/harfbuzz/issues/305

BUG= 637464 
R=behdad,eae,kojii

Review-Url: https://codereview.chromium.org/2306383002
Cr-Commit-Position: refs/heads/master@{#416533}

[modify] https://crrev.com/17dc0df0ddb82ed1a2733316139856f67317b51b/third_party/harfbuzz-ng/README.chromium
[modify] https://crrev.com/17dc0df0ddb82ed1a2733316139856f67317b51b/third_party/harfbuzz-ng/src/hb-ot-layout.cc

Status: Fixed (was: Assigned)
Marking this as fixed, verifying with the provided APK or a Canary APK once the CL is in it would be appreciated.
Labels: Merge-Request-54
Status: Assigned (was: Fixed)
Haven't tested locally yet, but requesting merge before I forget.

Comment 42 by dimu@chromium.org, Sep 6 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Confirmed fixed with the APK that has r416533 applied.
Project Member

Comment 44 by bugdroid1@chromium.org, Sep 6 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98bcb26c86ac882a1a088a604455f58f008a4095

commit 98bcb26c86ac882a1a088a604455f58f008a4095
Author: Alexandre Elias <aelias@chromium.org>
Date: Tue Sep 06 21:29:41 2016

Blacklist GDEF tables for Padauk fonts

The Padauk fonts have broken GDEF tables that define a set of Latin
characters as marks, which leads to collapsed advances. More details in
https://github.com/behdad/harfbuzz/issues/305

BUG= 637464 
R=behdad,eae,kojii

Review-Url: https://codereview.chromium.org/2306383002
Cr-Commit-Position: refs/heads/master@{#416533}
(cherry picked from commit 17dc0df0ddb82ed1a2733316139856f67317b51b)

Review URL: https://codereview.chromium.org/2311403002 .

Cr-Commit-Position: refs/branch-heads/2840@{#185}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/98bcb26c86ac882a1a088a604455f58f008a4095/third_party/harfbuzz-ng/README.chromium
[modify] https://crrev.com/98bcb26c86ac882a1a088a604455f58f008a4095/third_party/harfbuzz-ng/src/hb-ot-layout.cc

Status: Fixed (was: Assigned)
Remarking Fixed (doesn't call for Verified yet until it's observed on a release candidate).
Thanks for verifying using the APK and taking care of merging to 2840.

Comment 47 by e...@chromium.org, Sep 8 2016

Cc: drott@chromium.org js...@chromium.org
 Issue 637039  has been merged into this issue.
Status: Verified (was: Fixed)
Issue is fixed in current M54 - 54.0.2840.16. Verified on Samsung Galaxy Note 2 (GT-N7100) / KOT49H
Thanks for the verification, arunshan@, good to know it worked out.
Also confirmed fixed on Note 4 (SM-N910C) / KTU84P with 54.0.2840.16.
Project Member

Comment 51 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98bcb26c86ac882a1a088a604455f58f008a4095

commit 98bcb26c86ac882a1a088a604455f58f008a4095
Author: Alexandre Elias <aelias@chromium.org>
Date: Tue Sep 06 21:29:41 2016

Blacklist GDEF tables for Padauk fonts

The Padauk fonts have broken GDEF tables that define a set of Latin
characters as marks, which leads to collapsed advances. More details in
https://github.com/behdad/harfbuzz/issues/305

BUG= 637464 
R=behdad,eae,kojii

Review-Url: https://codereview.chromium.org/2306383002
Cr-Commit-Position: refs/heads/master@{#416533}
(cherry picked from commit 17dc0df0ddb82ed1a2733316139856f67317b51b)

Review URL: https://codereview.chromium.org/2311403002 .

Cr-Commit-Position: refs/branch-heads/2840@{#185}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/98bcb26c86ac882a1a088a604455f58f008a4095/third_party/harfbuzz-ng/README.chromium
[modify] https://crrev.com/98bcb26c86ac882a1a088a604455f58f008a4095/third_party/harfbuzz-ng/src/hb-ot-layout.cc

Sign in to add a comment