New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637463 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Delete the AVDA copying backing strategy

Project Member Reported by w...@chromium.org, Aug 12 2016

Issue description

This is currently dead code we should delete unless there's a good reason to keep it? 
 
+1 -- also, i just learned that a comment that says +1 isn't allowed, and prevents me from submitting the comment.  says "use stars" instead, to avoid "annoying other users".  but i don't want to use stars -- i'm not showing interest.  i'm agreeing that your idea is a good one.

i realize that there are many other ways to show agreement with an idea.  i could write "i agree with this idea", or "sgtm".  i might even say something more allegorical, like "alas, poor copying backing strategy", that would likely convey my intent while not tripping the regex for "+1 posts".

so why don't i just use one of these alternate, functionally equivalent methods?

BECAUSE OUR COMMUNICATIONS ARE MORE THAN FOOD FOR THE REGEX PATTERN MONSTER.  THEY INVADE OUR BUGS WEBSITES AND WE FALL BACK.  THEY REWRITE ENTIRE COMMENTS, AND WE FALL BACK.  THE LINE MUST BE DRAWN HERE!  THIS FAR, AND NO FARTHER!

PLUS ONE!


\+1

Comment 3 by w...@chromium.org, Aug 15 2016

✢1 to that comment haha
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b2ccc21abd7383301000507b1cdbf7696deb659

commit 4b2ccc21abd7383301000507b1cdbf7696deb659
Author: watk <watk@chromium.org>
Date: Wed Aug 31 23:28:45 2016

Delete AVDACopyingBackingStrategy and rename AVDADeferredRenderingBackingStrategy

AVDACopyingBackingStrategy is unused so it's now deleted. Since we only have a single
strategy left, it's renamed to AVDAPictureBufferManager, since its role is mostly
to associate PictureBuffers with MediaCodec buffers.

BUG= 637463 

Review-Url: https://codereview.chromium.org/2296513003
Cr-Commit-Position: refs/heads/master@{#415803}

[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/BUILD.gn
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/android_copying_backing_strategy.cc
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/android_copying_backing_strategy.h
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/android_deferred_rendering_backing_strategy.h
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/android_video_decode_accelerator_unittest.cc
[rename] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/avda_picture_buffer_manager.cc
[add] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/avda_picture_buffer_manager.h
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/avda_return_on_failure.h
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/avda_state_provider.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b2ccc21abd7383301000507b1cdbf7696deb659

commit 4b2ccc21abd7383301000507b1cdbf7696deb659
Author: watk <watk@chromium.org>
Date: Wed Aug 31 23:28:45 2016

Delete AVDACopyingBackingStrategy and rename AVDADeferredRenderingBackingStrategy

AVDACopyingBackingStrategy is unused so it's now deleted. Since we only have a single
strategy left, it's renamed to AVDAPictureBufferManager, since its role is mostly
to associate PictureBuffers with MediaCodec buffers.

BUG= 637463 

Review-Url: https://codereview.chromium.org/2296513003
Cr-Commit-Position: refs/heads/master@{#415803}

[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/BUILD.gn
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/android_copying_backing_strategy.cc
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/android_copying_backing_strategy.h
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/android_deferred_rendering_backing_strategy.h
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/android_video_decode_accelerator_unittest.cc
[rename] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/avda_picture_buffer_manager.cc
[add] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/avda_picture_buffer_manager.h
[delete] https://crrev.com/54d6d7be8c3073ff58e6725898800800b2e64f6d/media/gpu/avda_return_on_failure.h
[modify] https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659/media/gpu/avda_state_provider.h

Comment 7 by w...@chromium.org, Aug 31 2016

Status: Fixed (was: Assigned)

Sign in to add a comment