New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637454 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove the "card verified" message from PaymentRequest CVC prompt

Project Member Reported by rouslan@chromium.org, Aug 12 2016

Issue description

The merchant website has the final say in whether the provided credit                                                                                                                                                                    
card is usable for the purchase. The merchant notifies the browser via                                                                                                                                                                   
complete("fail") when the card is rejected. Chrome shows an error dialog                                                                                                                                                                 
to the user when this happens. Therefore, CVC unmask dialog should not                                                                                                                                                                   
show the "card verified" message. This is doubly true for local cards,                                                                                                                                                                   
which are not verified against the server due to the privacy model.
 

Comment 1 by kolos@chromium.org, Aug 16 2016

Components: Privacy
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ad99584c3051480f39d0a25173daad60ccf47b3

commit 7ad99584c3051480f39d0a25173daad60ccf47b3
Author: rouslan <rouslan@chromium.org>
Date: Tue Aug 16 17:07:41 2016

Remove the "card verified" message in PaymentRequest.

The merchant website has the final say in whether the provided credit
card is usable for the purchase. The merchant notifies the browser via
complete("fail") when the card is rejected. Chrome shows an error dialog
to the user when this happens. Therefore, CVC unmask dialog should not
show the "card verified" message. This is doubly true for local cards,
which are not verified against the server due to the privacy model. This
patch removes the "card verified" message from PaymentRequest. Autofill
card unmasking still has this message.

BUG= 637454 

Review-Url: https://codereview.chromium.org/2244893002
Cr-Commit-Position: refs/heads/master@{#412269}

[modify] https://crrev.com/7ad99584c3051480f39d0a25173daad60ccf47b3/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java
[modify] https://crrev.com/7ad99584c3051480f39d0a25173daad60ccf47b3/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
[modify] https://crrev.com/7ad99584c3051480f39d0a25173daad60ccf47b3/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
[modify] https://crrev.com/7ad99584c3051480f39d0a25173daad60ccf47b3/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment