New issue
Advanced search Search tips

Issue 637402 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add unit test for WebUSB same device name on the chooser

Project Member Reported by juncai@chromium.org, Aug 12 2016

Issue description

Need to add some unit tests for code that deals with displaying USB devices that have the same name on the chooser.
 

Comment 1 by juncai@chromium.org, Aug 19 2016

Labels: -OS-Android -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef45ff9caf531d43a366186a7c80d7307d91252

commit 2ef45ff9caf531d43a366186a7c80d7307d91252
Author: juncai <juncai@chromium.org>
Date: Wed Aug 24 01:33:57 2016

Add unit test for UsbChooserController

This CL adds some unit tests for code that deals with displaying USB
devices that have the same name on the chooser.

BUG= 637402 

Review-Url: https://codereview.chromium.org/2269993004
Cr-Commit-Position: refs/heads/master@{#413929}

[add] https://crrev.com/2ef45ff9caf531d43a366186a7c80d7307d91252/chrome/browser/usb/usb_chooser_controller_unittest.cc
[modify] https://crrev.com/2ef45ff9caf531d43a366186a7c80d7307d91252/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/2ef45ff9caf531d43a366186a7c80d7307d91252/device/usb/mock_usb_device.h

Comment 3 by juncai@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c1b74d2cec9fc150eef16be9ddfc122e656bba0

commit 3c1b74d2cec9fc150eef16be9ddfc122e656bba0
Author: juncai <juncai@chromium.org>
Date: Sat Aug 27 11:00:19 2016

Update UsbChooserController unit test

This CL added a MockUsbChooserView to test the UsbChooserController.

BUG= 637402 

Review-Url: https://codereview.chromium.org/2284033002
Cr-Commit-Position: refs/heads/master@{#414915}

[modify] https://crrev.com/3c1b74d2cec9fc150eef16be9ddfc122e656bba0/chrome/browser/usb/usb_chooser_controller_unittest.cc

Sign in to add a comment