New issue
Advanced search Search tips

Issue 637384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

rebaseline-o-matic failing due to Git error.

Project Member Reported by d...@chromium.org, Aug 12 2016

Issue description

webkitpy.common.system.executive: [DEBUG] "git diff HEAD --no-renames --name-only" took 0.51s
Traceback (most recent call last):
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 86, in <module>
    main()
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 81, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py", line 126, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py", line 118, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py", line 221, in execute
    revision_data = self.bot_revision_data(tool.scm())
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py", line 74, in bot_revision_data
    "revision": result.chromium_revision(scm),
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py", line 46, in __call__
    result = self._function(*args)
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 122, in chromium_revision
    revision = scm.commit_position_from_git_commit(revision)
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py", line 46, in __call__
    result = self._function(*args)
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 255, in commit_position_from_git_commit
    git_log = self.git_commit_detail(git_commit)
  File "/mnt/data/b/rr/tmp1q5ueT/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 304, in git_commit_detail
    args.append('--format=' + log_format)
TypeError: cannot concatenate 'str' and 'NoneType' objects
step returned non-zero exit code: 1

Any idea what's going on here?
 
Owner: qyears...@chromium.org
Status: Started (was: Untriaged)
Cause was:

  https://codereview.chromium.org/2130093003

Since I can see the mistake now, it might be easiest/quickest to fix by uploading just the fix CL instead of a revert then reland with fix.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faa9fe2108f48a8a31a44a5e4d75c632971b03ff

commit faa9fe2108f48a8a31a44a5e4d75c632971b03ff
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Aug 12 22:18:32 2016

Follow-up fix for CL 2130093003 (format -> log_format)

BUG= 637384 

Review-Url: https://codereview.chromium.org/2239943004
Cr-Commit-Position: refs/heads/master@{#411795}

[modify] https://crrev.com/faa9fe2108f48a8a31a44a5e4d75c632971b03ff/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54f8ab219ad04c900c20a8b62295c3a0aef0c979

commit 54f8ab219ad04c900c20a8b62295c3a0aef0c979
Author: hiroshige <hiroshige@chromium.org>
Date: Mon Aug 15 08:53:23 2016

Revert of Follow-up fix for CL 2130093003 (format -> log_format) (patchset #1 id:1 of https://codereview.chromium.org/2239943004/ )

Reason for revert:
https://codereview.chromium.org/2130093003 is causing Linux ASAN bot failure:
 crbug.com/637664 

Original issue's description:
> Follow-up fix for CL 2130093003 (format -> log_format)
>
> BUG= 637384 
>
> Committed: https://crrev.com/faa9fe2108f48a8a31a44a5e4d75c632971b03ff
> Cr-Commit-Position: refs/heads/master@{#411795}

TBR=dnj@chromium.org,dpranke@chromium.org,qyearsley@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 637384 

Review-Url: https://codereview.chromium.org/2244193002
Cr-Commit-Position: refs/heads/master@{#411948}

[modify] https://crrev.com/54f8ab219ad04c900c20a8b62295c3a0aef0c979/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py

Sign in to add a comment