New issue
Advanced search Search tips

Issue 637383 link

Starred by 4 users
Status: Assigned
Owner:
mef@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove disable_auto_flush from cronet_bidirectional_stream.h

Project Member Reported by xunji...@chromium.org, Aug 12 2016 
Flush() is a part of the BidirectionalStream API. The consumer of our Java API always calls disableAutoFlush(true) and uses flush(). 

We should remove disableAutoFlush() from Java, and make flush() required. We need to also update the JavaDoc to reflect the change. I am not sure whether the disable_auto_flush() in the C wrapper can be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb5b665ffd1ebf35811d48c595bd1396ed8b074c

commit cb5b665ffd1ebf35811d48c595bd1396ed8b074c
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Aug 18 14:07:23 2016

Remove BidirectionalStream.Builder.disableAutoFlush

This CL removes BidirectionalStream.Builder.disableAutoFlush to simply the
API.

BUG=637383

Review-Url: https://codereview.chromium.org/2245803002
Cr-Commit-Position: refs/heads/master@{#412821}

[modify] https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
[modify] https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
[modify] https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
[modify] https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java
[modify] https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
[modify] https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java
[modify] https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Comment 2 by mef@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)

Comment 3 by xunji...@chromium.org, Aug 29 2016

Owner: ----
Status: Available (was: Fixed)
Should we leave this open for the iOS part?

Comment 4 by mef@chromium.org, Aug 29 2016 

Good question. Previous iOS work was tracked under  issue 601972  including addition of disable_auto_flush flag. 

GRPC on iOS is yet to use it though, and I don't think we can remove it yet.

Comment 5 by xunji...@chromium.org, Aug 29 2016

Labels: -M-54
Summary: Remove disable_auto_flush from cronet_bidirectional_stream.h (was: Remove BidirectionalStream.Builder#disableAutoFlush() )
Understood. Thanks for the context! I will leave this open so it's in our TODOs.
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 29 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by sczs@chromium.org, Aug 30 2017

Owner: mef@chromium.org
Status: Assigned (was: Untriaged)
mef@ could you please triage
►

Sign in to add a comment