New issue
Advanced search Search tips

Issue 637376 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Blimp crash in blimp::CompressedPacketWriter::Compress

Project Member Reported by mlliu@chromium.org, Aug 12 2016

Issue description


What steps will reproduce the problem?
(1) sync code to latest
(2) build engine, and client
(3) "out-linux/Debug/bin/client_engine_integration run " to start the engine, and then "out-linux/Debug/bin/client_engine_integration load -p out-android/Debug/apks/Blimp.apk" to start the client

What is the expected output?
blimp displays the google page

What do you see instead?
blimp crashes

stack trace attached 

 
adb_logcat
51.1 KB View Download
Looks like zlib deflate.c thinks that we have SSE SIMD extensions enabled for the Android build. It's triggering an assert in a null implementation file:

08-15 16:57:28.225  5072  5100 F libc    : ../../third_party/zlib/simd_stub.c:30: void fill_window_sse(deflate_state *): assertion "0" failed

Working on a fix.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00397506bfb597772b87b1446828771c466a725

commit f00397506bfb597772b87b1446828771c466a725
Author: kmarshall <kmarshall@chromium.org>
Date: Tue Aug 16 21:45:00 2016

Disable zlib compression in Blimp until  crbug.com/637376  fixed.

There is a compiler/code optimization bug in zlib's SIMD implementation,
which will take time to investigate and fix. This CL restores
functionality in Blimp by disabling compression.

This CL can be rolled back once the root cause of crbug.com/637736
is addressed.

R=lethalantidote@chromium.org
CC=wez@chromium.org
BUG= 637376 

Review-Url: https://codereview.chromium.org/2248943003
Cr-Commit-Position: refs/heads/master@{#412346}

[modify] https://crrev.com/f00397506bfb597772b87b1446828771c466a725/blimp/net/stream_socket_connection.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4507bfea675457b628f51da133224f7b7f62ab3

commit e4507bfea675457b628f51da133224f7b7f62ab3
Author: kmarshall <kmarshall@chromium.org>
Date: Tue Aug 16 23:47:20 2016

Fix off-by-one error in counter array sizing in BlimpStats.

BlimpStats' Atomic32[] array was missing an element thanks to the
misapplication of a zero-indexed enum value. This lead to memory
corruption when certain counter values were incremented. In this case,
the zlib global flag "x86_cpu_enable_simd" was corrupted, leading zlib's
deflate() function down invalid SSE SIMD codepaths.

Also restored compression by reverting cl/2248943003.

BUG= 637376 
R=lethalantidote@chromium.org,wez@chromium.org

Review-Url: https://codereview.chromium.org/2253513004
Cr-Commit-Position: refs/heads/master@{#412380}

[modify] https://crrev.com/e4507bfea675457b628f51da133224f7b7f62ab3/blimp/net/blimp_stats.cc
[modify] https://crrev.com/e4507bfea675457b628f51da133224f7b7f62ab3/blimp/net/blimp_stats.h
[modify] https://crrev.com/e4507bfea675457b628f51da133224f7b7f62ab3/blimp/net/stream_socket_connection.cc

Status: Verified (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment