To allow for internal builds and waterfalls
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/c6255395674c45b38e0cebd6c391169125745a89 commit c6255395674c45b38e0cebd6c391169125745a89 Author: hinoka <hinoka@google.com> Date: Fri Aug 19 00:13:57 2016 Milo: ACL support This just includes a IsAllowed() helper function, that gets called by each module (buildbot, buildbucket, etc) BUG= 637375 Review-Url: https://codereview.chromium.org/2241853002 [add] https://crrev.com/c6255395674c45b38e0cebd6c391169125745a89/milo/appengine/settings/acl.go [add] https://crrev.com/c6255395674c45b38e0cebd6c391169125745a89/milo/appengine/settings/acl_test.go [modify] https://crrev.com/c6255395674c45b38e0cebd6c391169125745a89/milo/common/miloerror/error.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/63a9cfa4f98f04ab34e84f38c5304945575e5975 commit 63a9cfa4f98f04ab34e84f38c5304945575e5975 Author: hinoka <hinoka@google.com> Date: Wed Aug 24 21:13:22 2016 Milo: Internal buildbot masters support This CL finds all the places where the buildbot build or master entries are being fetched, and performs an ACL if the "Internal" flag on the build is set to see if the current user is part of the magic "buildbot-private" project. 404's are the errors of choice for internal buildbot builds. BUG= 637375 Review-Url: https://codereview.chromium.org/2271453002 [modify] https://crrev.com/63a9cfa4f98f04ab34e84f38c5304945575e5975/milo/appengine/buildbot/build.go [modify] https://crrev.com/63a9cfa4f98f04ab34e84f38c5304945575e5975/milo/appengine/buildbot/build_test.go [modify] https://crrev.com/63a9cfa4f98f04ab34e84f38c5304945575e5975/milo/appengine/buildbot/builder.go [modify] https://crrev.com/63a9cfa4f98f04ab34e84f38c5304945575e5975/milo/appengine/buildbot/master.go [modify] https://crrev.com/63a9cfa4f98f04ab34e84f38c5304945575e5975/milo/appengine/buildbot/pubsub.go [modify] https://crrev.com/63a9cfa4f98f04ab34e84f38c5304945575e5975/milo/appengine/buildbot/pubsub_test.go [modify] https://crrev.com/63a9cfa4f98f04ab34e84f38c5304945575e5975/milo/appengine/settings/acl.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/e8799958f18e1d896eb636c1cf2dd8b152f49a15 commit e8799958f18e1d896eb636c1cf2dd8b152f49a15 Author: hinoka <hinoka@google.com> Date: Tue Aug 30 21:46:15 2016 Milo: Add a login url So that users can authenticate themselves. BUG= 637375 Review-Url: https://codereview.chromium.org/2271483002 [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_no_builds.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_with_builds.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-frontend.testableFrontpage-Basic_frontpage.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-settings.TestableSettings-Settings.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-canceled.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-exception.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-hang.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-link.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-patch-failure.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-pending.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-timeout.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-unicode.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/expectations/buildbot-swarming.TestableLog-Basic_log.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/static/buildbot/css/default.css [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/frontend/templates/buildbot/includes/buildbot.html [modify] https://crrev.com/e8799958f18e1d896eb636c1cf2dd8b152f49a15/milo/appengine/settings/themes.go
Comment 1 by benhenry@chromium.org
, Aug 12 2016Labels: Type-Feature
Status: Assigned (was: Untriaged)