New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637366 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Unable to close Payment Request sheet via [x] while website is processing the transaction

Project Member Reported by rouslan@chromium.org, Aug 12 2016

Issue description

^^^
 
Closing via Android's < (back) button works.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d72ec4ded66ff9ad99497f5895433bccd179716

commit 4d72ec4ded66ff9ad99497f5895433bccd179716
Author: rouslan <rouslan@chromium.org>
Date: Sat Aug 13 06:21:13 2016

Enable closing while processing payment.

This patch allows closing PaymentRequest UI via the [x] button while
waiting for merchant to process the payment. This is accomplished by
switching off the "is processing pay clicked" flag when
showProcessingMessage() has been called. PaymentRequestImpl calls
showProcessingMessage() when payment app has closed and its info has
been sent to the merchant website.

BUG= 637366 

Review-Url: https://codereview.chromium.org/2247493002
Cr-Commit-Position: refs/heads/master@{#411881}

[add] https://crrev.com/4d72ec4ded66ff9ad99497f5895433bccd179716/chrome/android/java/src/org/chromium/chrome/browser/payments/OWNERS
[modify] https://crrev.com/4d72ec4ded66ff9ad99497f5895433bccd179716/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/4d72ec4ded66ff9ad99497f5895433bccd179716/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Status: Fixed (was: Started)
Labels: Merge-Request-53 M-53
Status: Started (was: Fixed)

Comment 5 by dimu@chromium.org, Aug 15 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 19 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 19 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a1d153e4ff3c681fb72a4290c575a52bdb6d2e9

commit 1a1d153e4ff3c681fb72a4290c575a52bdb6d2e9
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Aug 19 16:53:34 2016

[Merge M-53] Enable closing while processing payment.

This patch allows closing PaymentRequest UI via the [x] button while
waiting for merchant to process the payment. This is accomplished by
switching off the "is processing pay clicked" flag when
showProcessingMessage() has been called. PaymentRequestImpl calls
showProcessingMessage() when payment app has closed and its info has
been sent to the merchant website.

BUG= 637366 

Review-Url: https://codereview.chromium.org/2247493002
Cr-Commit-Position: refs/heads/master@{#411881}
(cherry picked from commit 4d72ec4ded66ff9ad99497f5895433bccd179716)

Review URL: https://codereview.chromium.org/2260503004 .

Cr-Commit-Position: refs/branch-heads/2785@{#679}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[add] https://crrev.com/1a1d153e4ff3c681fb72a4290c575a52bdb6d2e9/chrome/android/java/src/org/chromium/chrome/browser/payments/OWNERS
[modify] https://crrev.com/1a1d153e4ff3c681fb72a4290c575a52bdb6d2e9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/1a1d153e4ff3c681fb72a4290c575a52bdb6d2e9/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in M53-53.0.2785.80 build
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment