New issue
Advanced search Search tips

Issue 637364 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

No way to add condition to a breakpoint using the breakpoint list

Project Member Reported by eostroukhov@chromium.org, Aug 12 2016

Issue description

Edit breakpoint action is not shown in the breakpoints list popup menu.
 

Comment 1 by l...@chromium.org, Dec 2 2016

Cc: chowse@chromium.org l...@chromium.org
Components: Platform>DevTools
From chowse@chromium.org:

Steps to reproduce:
(1) Open https://developers.google.com/ (or any page with some Javascript)
(2) Switch to the Sources tab (or use Ctrl+P) and open a Javascript file.
(3) Add a breakpoint to any line of the file.
(4) Right click on the breakpoint and click 'Edit breakpoint...'
(5) Add a conditional expression and hit Enter
(6) Open the Breakpoints panel in the debugger (the list of all set breakpoints)
(7) Find the breakpoint you just set in the list
(8) Right-click on the breakpoint

Expected result:
(1) An 'Edit breakpoint...' command should be available to view/change the condition.
(2) There should be some indication the breakpoint has a condition attached to it.

Actual result:
(1) There are only options to remove the breakpoint.
(2) There is nothing to indicate a breakpoint is conditional.


There are a couple of ways to address this:
(1a) From the Breakpoints panel, "Edit breakpoint..." could take you to the breakpoint in the code and open the condition panel there.
(1b) The condition panel could be made a popup (e.g. like the color picker) instead of an inline panel. Then it could be opened from both the text editor and the breakpoint panel.
(2a) The checkboxes beside breakpoint could adopt the same colors used to indicate their type (e.g. blue for default breakpoints, orange for conditional).
(2b) The checkboxes could be replaced with debug markers and adopt the same styling as their text editor counterparts (e.g. dimmed if disabled, orange if conditional, etc.)

Comment 2 by l...@chromium.org, Dec 2 2016

 Issue 670697  has been merged into this issue.
Cc: -chowse@chromium.org -l...@chromium.org
Owner: l...@chromium.org

Sign in to add a comment