New issue
Advanced search Search tips

Issue 637361 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.3% regression in power.trivial_pages at 411485:411506

Project Member Reported by benjhayden@chromium.org, Aug 12 2016

Issue description

Looks like less than 5% regression. Maybe ignore?
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=637361

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgjojtqwoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 12 2016

Cc: erikc...@chromium.org
Owner: erikc...@chromium.org

=== Auto-CCing suspected CL author erikchen@chromium.org ===

Hi erikchen@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2234513002/ )
Author  : erikchen
Commit description:
  
Reason for revert:
Causes performance regressions when there are a lot of filters. Probably needs better IOSurface caching.

https://bugs.chromium.org/p/chromium/issues/detail?id=636884

Original issue's description:
> Enable promotion of RenderPassDrawQuads to CALayers.
>
> BUG= 581526 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c
> Cr-Commit-Position: refs/heads/master@{#411055}

TBR=ccameron@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 581526 

Review-Url: https://codereview.chromium.org/2238113002
Cr-Commit-Position: refs/heads/master@{#411505}
Commit  : 314269eae868551bb560428fce916863e4d60cb4
Date    : Fri Aug 12 01:21:28 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@411484  4483.8  29.7355  5  good
chromium@411495  4474.8  17.9639  5  good
chromium@411501  4482.0  16.2327  5  good
chromium@411504  4469.8  46.0293  5  good
chromium@411505  4738.2  41.3243  5  bad    <--
chromium@411506  4749.0  29.0086  5  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 637361

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests power.trivial_pages
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 5.91%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/829
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004511706475773696


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5900436838547456

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Expected, since my CL that was reverted reduces power consumption.
Status: WontFix (was: Assigned)

Sign in to add a comment