New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637351 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocked on:
issue 620801

Blocking:
issue 689686



Sign in to add a comment

Notification Center is not focused when pressing alt+shift+n

Project Member Reported by dtseng@chromium.org, Aug 12 2016

Issue description

- with or without ChromeVox (ctrl+alt+z) on
- alt+shift-n

result:
nothing receives focus, so spoken feedback (ChromeVox) or a keyboard user would have no idea anything happened. This makes Notification Center basically a no-op for a portion of Chrome OS users.
 

Comment 1 by dtseng@chromium.org, Aug 12 2016

Summary: Notification Center is not focused when pressing alt+shift+n (was: Notificaiton Center is not focused when pressing alt+shift+n)

Comment 2 by dtseng@chromium.org, Aug 12 2016

Blockedon: 620801

Comment 3 by dtseng@chromium.org, Aug 12 2016

Cc: abodenheimer@chromium.org
Owner: xiy...@chromium.org
Status: available (was: Untriaged)
xiyuan@, would you mind taking a look? Cc'ing abodenheimer to triage.

Comment 4 by xiy...@chromium.org, Aug 15 2016

Cc: -abodenheimer@chromium.org abodenha@chromium.org
Labels: OS-Chrome
Maybe we can speak something when the bubble widget shows up (with nothing to be focused).
There are a couple of issues here.

The first is lack of focus. The second is that if it DOES gain focus the focus rectangle that gets drawn doesn't meet UX guidelines.

dtseng@ had landed a change to make it gain focus, but UX and PMs weren't willing to let the resultant UI ship.

The right approach here is to figure out what the focus UI SHOULD look like and then make the notification panel be available for keyboard navigation.
 
kuscher@ is there someone who can own this on the PM side?
Components: UI>Notifications UI>Accessibility
Components: UI>Shell>Notifications
Labels: Proj-MaterialDesign-CrOS
Blocking: 689686
Labels: NewComponent-Accessibility NewComponent-Accessibility-ChromeVox
Labels: -NewComponent-Accessibility-ChromeVox NewComponent-Accessibility-Browser
Labels: -newcomponent-accessibility-browser -newcomponent-accessibility
#CBC-RS/TC-watchlist

Still happening in Stable, Beta and Dev.
Cc: trumbull@chromium.org
Labels: Hotlist-ConOps
Cc: lpalmaro@chromium.org
Cc: tetsui@chromium.org est...@chromium.org
Owner: sgabr...@chromium.org
Status: Assigned (was: Available)
Assigning to Sebastien for design feedback. See #5
Sorry I'm a bit confused and need some precisions.

What are we trying to address? System focus or Spoken feedback focus?
right now and after some testing I can access all notification center surfaces with system focus. Spoken feedback focus is not working very well post-first notification or on ARC.
NextAction: 2018-02-23
I believe this bug is fixed. I don't think it ever got attached to changes made to:
- give the notification center system focus
- add accessibility annotations

ARC++ notifications are extremely custom and should at least be browsable using Search+Left/Right with ChromeVox.




The NextAction date has arrived: 2018-02-23

Comment 19 by dymp...@gmail.com, Feb 23 2018

Not fixed on minnie, yuna, caroline 65.0.3325.89 beta

Alt  + Shift + N - opens the notification center, it does not focus it
Alt  + Shift + N > TAB  - does nothing

The only way to focus a notification is to click on the tiny expand arrow. Clicking anywhere else opens it in the app or a tab.

Video #1 open tab not focussed > alt + shift + N > tab

Video #2 open tab focussed

Secondary issues:
 
1. it is incredibly time consuming to have to move the cursor with the touchpad to click on the very tiny arrow to expand/focus a notification.

2. or on the tiny X to dismiss the notification

3. screenshot of download notification pop up while downloading the videos. The only ways to get that notification out of the way.

- click on X to dismiss
- alt + shift + N to open > alt + shift + N again to close







#1 Feb 23, 2018 7_58 AM.webm
3.8 MB View Download
#2 Feb 23, 2018 8_04 AM.webm
3.9 MB View Download
Screenshot 2018-02-23 at 8.42.21 AM.png
731 KB View Download

Comment 20 by dymp...@gmail.com, Feb 23 2018

BTW, I'm talking about system focus.

For comparison, alt + shift + s is immediately focussed, hit tab key to cycle through the functions.
Cc: sgabr...@chromium.org
Owner: ----
Status: Available (was: Assigned)
#19 is right, testing on canary. Tab nav doesn't work on the notification center when ChromeVox is NOT active. This should be fixed. Not sure who to assign this to. dtseng@?

Re: 1. it is incredibly time consuming to have to move the cursor with the touchpad to click on the very tiny arrow to expand/focus a notification.

The entire "row" of a notification (entire title section) is clickable to expand, it is not necessary to aim at the arrow indicator.

Comment 22 by dymp...@gmail.com, Feb 23 2018

sgabr...@, thank you. 

My primary use would be to hit "esc" to dismiss the notification and the whole message center quickly. 

Re: the entire row. I just figured that out as well. Can't remember if it  was present already on Beta 64 ;)
Cc: yoshiki@chromium.org

Comment 24 by na...@chromium.org, Mar 27 2018

What're the next steps here? yoshiki@, who's driving the Material Design project for CrOS?

Comment 25 by awdf@chromium.org, May 11 2018

NextAction: ----
I'm removing the next-action date that's causing this bug to hit our bug cop filters, because it looks like that served its purpose back in Feb, and the Chrome OS team members are cc'd already.

However I"m now curious - will the new-style Material Design notifications on Chrome OS fix this? What is the current status of Material Design notifications on Chrome OS?

Comment 26 by awdf@chromium.org, May 11 2018

Cc: awdf@chromium.org
Cc: osh...@chromium.org
Owner: yamaguchi@chromium.org
Status: Assigned (was: Available)
Yamaguchi-san, could you take a look? 

Previously, during the message center opened, pressing TAB key made the message center focusable and the message center got focus. But now it has been broken.

Oshima-san might help you about how we can hook TAB key.
Status: Started (was: Assigned)
Cc: yawano@chromium.org
I've got that we added logic to allow some keyboard inputs after mouse click ( Issue 740055 ). We'll need to apply that logic for this case as well.

Comment 30 by dymp...@gmail.com, May 15 2018

FYI The notification center has multiple issues. 

Issue 836523 (restricted)

 Issue 840119  - Crash after clicking X to dismiss a notification Beta 67 

 Issue 827850  - Swiping away notification launches the app when the notification should simply be swiped away in V66 - Crash after swiping on Beta 67 as well now.



Project Member

Comment 31 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/901ea08ea95759b78d836f6da98d319a2680e9e9

commit 901ea08ea95759b78d836f6da98d319a2680e9e9
Author: Tatsuhisa Yamaguchi <yamaguchi@google.com>
Date: Fri May 25 02:24:14 2018

Make notifications accessible by keyboard when opened by keyboard.


Bug:  637351 
Test: manually verified as in the bug
Change-Id: I27c833a2a9514af9b105126d1db2d0adffe358c0
Reviewed-on: https://chromium-review.googlesource.com/1059369
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561739}
[modify] https://crrev.com/901ea08ea95759b78d836f6da98d319a2680e9e9/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/901ea08ea95759b78d836f6da98d319a2680e9e9/ash/system/message_center/notification_tray.cc
[modify] https://crrev.com/901ea08ea95759b78d836f6da98d319a2680e9e9/ash/system/message_center/notification_tray.h

Status: Fixed (was: Started)
Labels: Hotlist-ConOps-CrOS
Cc: -awdf@chromium.org

Sign in to add a comment