New issue
Advanced search Search tips

Issue 637328 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

BrowserMainLoop::ShutdownThreadsAndCleanUp Short-circuits if Threads Haven't Started

Project Member Reported by robliao@chromium.org, Aug 12 2016

Issue description

BrowserMainLoop::ShutdownThreadsAndCleanUp only runs its cleanup code if BrowserMainLoop::CreateThreads succeeds, skipping any cleanup that might need to occur prior to that point (e.g. EarlyInitialization, PreMainMessageLoopStart, MainMessageLoopStart, PreCreateThreads, etc.)

One impact is that if CreateThreads hasn't succeeded, the task scheduler will not shutdown after its started.
 

Comment 1 by gab@chromium.org, Aug 12 2016

Interesting, I'd say that's probably not a big deal, if we fail to CreateThreads I don't even think we're passed the point where we grab the ProcessSingleton, so unclean shutdown isn't even in question yet.
Status: WontFix (was: Assigned)
WontFixing this bug as we've lived with it for quite a while and are unlikely to deal with it.

Skipping shutdown currently occurs here:
https://cs.chromium.org/chromium/src/content/browser/browser_main.cc?rcl=bce4015c3968a9b67041e8b97664986999fac714&l=48

Sign in to add a comment