Make metrics code robust about non-GUID backups of client id |
||
Issue descriptionMake metrics code robust about non-GUID backups of client id. For context, see: https://bugs.chromium.org/p/chromium/issues/detail?id=635255 Gab landed a temporary fix for things here: https://codereview.chromium.org/2236383002 This bug is about a more permanent fix.
,
Sep 13 2016
Alexei and I discussed this issue and it seems like Gab's fix already makes the metrics code robust (it generates a new GUID if the backup is not valid), so let's just remove the comment about the fix being a hack and the TODO. The real issue (about the Windows Registry being overriden/cleared on each test run) should be discussed at https://bugs.chromium.org/p/chromium/issues/detail?id=637324.
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4582c72d65e363b1fa6be6e7842888fdfc8dfd1e commit 4582c72d65e363b1fa6be6e7842888fdfc8dfd1e Author: lawrencewu <lawrencewu@chromium.org> Date: Tue Sep 13 18:42:14 2016 Remove unnecessary comment in metrics code BUG= 637322 Review-Url: https://codereview.chromium.org/2332393002 Cr-Commit-Position: refs/heads/master@{#418315} [modify] https://crrev.com/4582c72d65e363b1fa6be6e7842888fdfc8dfd1e/components/metrics/metrics_state_manager.cc
,
Sep 13 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Sep 12 2016