New issue
Advanced search Search tips

Issue 637316 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 510908
issue 646176



Sign in to add a comment

[Spv2] Represent svg root viewport clip in property tree

Project Member Reported by wangxianzhu@chromium.org, Aug 12 2016

Issue description

Currently svg root viewport clip outputs display items only (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp?rcl=0&l=57). It should be represented as a node in the property tree.

pdr@ has this already been in your task list?
 

Comment 1 by pdr@chromium.org, Aug 12 2016

Cc: pdr@chromium.org
Owner: ----
Status: Available (was: Assigned)
Yeah, this is a problem :/ My plate is full trying to get scrolling working in spv2 and removing the non-layer-list codepath. I'm setting this as available for now, but I should be able to pick it up in a few weeks.
Blocking: 510908
Blockedon: -510908
Blocking: 646176
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
I'm picking this bug to unblock  bug 646176 .
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00b1ddc91d630dfc1d836fbef415841dc01ae7da

commit 00b1ddc91d630dfc1d836fbef415841dc01ae7da
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Sep 15 01:37:28 2016

SVG root viewport clip in paint property tree

BUG= 637316 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2343673003
Cr-Commit-Position: refs/heads/master@{#418747}

[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.txt
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.txt
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/LayoutTests/svg/custom/viewport-update2-expected.txt
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/paint/BoxClipper.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp
[modify] https://crrev.com/00b1ddc91d630dfc1d836fbef415841dc01ae7da/third_party/WebKit/Source/core/paint/SVGRootPainter.h

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05f1d2ae71ddb73d9bab16ca5b1c29f1c5bffa71

commit 05f1d2ae71ddb73d9bab16ca5b1c29f1c5bffa71
Author: pdr <pdr@chromium.org>
Date: Tue Jan 10 04:43:10 2017

Remove 618 passing tests from FlagExpectations/enable-slimming-paint-v2

BUG= 644358 , 637316 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2621833002
Cr-Commit-Position: refs/heads/master@{#442475}

[modify] https://crrev.com/05f1d2ae71ddb73d9bab16ca5b1c29f1c5bffa71/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Sign in to add a comment