gsutil ls -l -- gs://chromeos-prebuilt/afdo-job/canonicals/latest-chromeos-chrome-amd64-52.afdo
        46  2016-08-03T03:59:59Z  gs://chromeos-prebuilt/afdo-job/canonicals/latest-chromeos-chrome-amd64-52.afdo

It's now older than 7 days as checked here:
https://cs.corp.google.com/chromeos_public/chromite/cbuildbot/afdo.py?rcl=4f2c557fea7b96d91980d95ab9329825404c06a4&l=360

+sheriffs

I'm trying to wrap my head around what this is doing and how it works, but it seems like part of the issue is that the AFDO updates are stale because there haven't been any builds on those branches in almost a week:
https://uberchromegw.corp.google.com/i/chromeos_release/builders/lumpy-pre-flight-branch%20release-R52-8350.B

This combined with the interaction of the changes https://chromium-review.googlesource.com/281195 and https://chromium-review.googlesource.com/285542 which prevent updating the ebuild on the last successful build:
https://uberchromegw.corp.google.com/i/chromeos_release/builders/lumpy-pre-flight-branch%20release-R52-8350.B/builds/192/steps/AFDOUpdateEbuild/logs/stdio
12:01:50: INFO: RunCommand: git status --porcelain -- Manifest chromeos-chrome-52.0.2743.117_rc-r1.ebuild chromeos-chrome-9999.ebuild in /b/cbuild/shared_internal/src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome
12:01:52: INFO: AFDO info for the Chrome ebuild did not change. Nothing to commit

+llozano@ who implemented the changes to not rev the ebuild.

I will take a look at this but why is this a P1? isn't this branch inactive?

Comment 4: We were still building off of it as late as last week. We may have one more stable release so it would be good to have the pfq up and running.

Xixuan/ Don will you please look into this? Thanks

Is 'afdo file is not updated in 7 days' expected? 

If so, release the restriction. If not, the problem becomes to why afdo file is not updated as scheduled.

What builders generate the AFDO profiles?

The one this builder is checking hasn't been updated since the 3rd.


gsutil -o 'Boto:num_retries=10' ls -l -- gs://chromeos-prebuilt/afdo-job/canonicals/latest-chromeos-chrome-amd64-52.afdo
        46  2016-08-03T03:59:59Z  gs://chromeos-prebuilt/afdo-job/canonicals/latest-chromeos-chrome-amd64-52.afdo

I will find a workaround for this.

I have a workaround in here for review. https://chromium-review.googlesource.com/#/c/373683/1
The real change is a little bit more complicated. I will need to test before I can put it on ToT.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/27873487e9b14f56eb7ea9ccdd3e3a5021c53fa3

commit 27873487e9b14f56eb7ea9ccdd3e3a5021c53fa3
Author: Luis Lozano <llozano@chromium.org>
Date: Mon Aug 22 08:35:53 2016

AFDO: increase allowed stale for profile on inactive branch.

R52 is mostly inactive. Chrome is not being uprevved anymore.
But the AFDO process is trying to check if the AFDO profile is
not stale and it is failing because it has not been updated in
the last 7 days. To workaround this, increase the stale limit
to 35 days which should be more than enough.

BUG= chromium:637307 
TEST=none

Change-Id: I3212eaf89c1328113f751d243fae3aece6ccf869
Reviewed-on: https://chromium-review.googlesource.com/373683
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Trybot-Ready: Luis Lozano <llozano@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/27873487e9b14f56eb7ea9ccdd3e3a5021c53fa3/cbuildbot/afdo.py

Pfq is green, marking this as fixed. Thanks!

bulk verified