New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637300 link

Starred by 1 user
Status: Fixed
Owner:
rmis...@chromium.org
Closed: Aug 2016
Cc:
█ andyb...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clicking on Revert, Cancel and Revert again adds tags twice

Project Member Reported by serg...@chromium.org, Aug 12 2016 
When creating a revert, the following tags are added to the description:

TBR=...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

If for any reason a user clicks on Revert button, then Cancel and then Revert again - these tags are added twice.

Comment 1 by serg...@chromium.org, Aug 12 2016

Labels: -Restrict-View-Google Proj-Gerrit-Migration

Comment 2 by benhenry@chromium.org, Aug 12 2016

Cc: andyb...@chromium.org
Components: -Infra Infra>Codereview>Gerrit
Labels: Pri-2 Type-Bug

Comment 3 by rmis...@google.com, Aug 15 2016

Owner: rmis...@chromium.org
Status: Started (was: Untriaged)
Sent out for review: https://gerrit-review.googlesource.com/#/c/82731/5

Comment 4 by rmis...@google.com, Aug 16 2016 

https://gerrit-review.googlesource.com/#/c/82731/ ('Do not repeatedly add the 'revert' message modifications') has been submitted.
It will be live the next time PG is pushed.

Comment 5 by rmis...@google.com, Aug 22 2016 

Hi Andy, looks like this is not live yet.
When do you plan to do the next PG deployment?

Thanks!

Comment 6 by andyb...@chromium.org, Aug 22 2016 

As soon as https://gerrit-review.googlesource.com/c/83090/ is deployed (this week).

Comment 7 by rmis...@google.com, Aug 28 2016

Status: Fixed (was: Started)
Looks like this is now working.
Tested by clicking revert twice in https://chromium-review.googlesource.com/c/366771/.

Marking as fixed.
►

Sign in to add a comment